From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D968A04DB; Thu, 15 Oct 2020 05:40:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE3D51DB8F; Thu, 15 Oct 2020 05:40:19 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 395D01DB8F for <dev@dpdk.org>; Thu, 15 Oct 2020 05:40:17 +0200 (CEST) IronPort-SDR: SX7FcJhCq3y+djW1gwJhuKD2pz+vwPXJNIprmW+NQP5X2PNPlrSJbhymiV3ejDnlZZpuOBLnL1 vzSO11Vkqwog== X-IronPort-AV: E=McAfee;i="6000,8403,9774"; a="250942655" X-IronPort-AV: E=Sophos;i="5.77,377,1596524400"; d="scan'208";a="250942655" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 20:40:14 -0700 IronPort-SDR: irnF/a9nMLJL3Fn8qcK2FUUS01RD7E5FT3TuvlHhuzNeSbAFv3OzRhl4EaysTSVNxEPYLQXevd 4r3mxxDZ2PPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,377,1596524400"; d="scan'208";a="318878970" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 14 Oct 2020 20:40:14 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Oct 2020 20:40:13 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 15 Oct 2020 11:40:11 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Thu, 15 Oct 2020 11:40:11 +0800 From: "Guo, Jia" <jia.guo@intel.com> To: "Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "Wu, Jingjing" <jingjing.wu@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Wang, Haiyue" <haiyue.wang@intel.com>, Olivier Matz <olivier.matz@6wind.com> Thread-Topic: [PATCH v8] net/iavf: support flex desc metadata extraction Thread-Index: AQHWoTosrATJDADdOEaLfCYF1kC8NamWg1yAgAAZsQCAAWflMA== Date: Thu, 15 Oct 2020 03:40:11 +0000 Message-ID: <e50136204911450f956d313dd4df4b56@intel.com> References: <20200909025415.6185-1-jia.guo@intel.com> <20201013081734.47507-1-jia.guo@intel.com> <0257ccb2-88eb-a49a-77f9-9e611f3c266a@intel.com> <20201014140336.GH1513@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201014140336.GH1513@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8] net/iavf: support flex desc metadata extraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Bruce Richardson <bruce.richardson@intel.com> > Sent: Wednesday, October 14, 2020 10:04 PM > To: Yigit, Ferruh <ferruh.yigit@intel.com> > Cc: Guo, Jia <jia.guo@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; > Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; > dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; Olivier Matz > <olivier.matz@6wind.com> > Subject: Re: [PATCH v8] net/iavf: support flex desc metadata extraction >=20 > On Wed, Oct 14, 2020 at 01:31:39PM +0100, Ferruh Yigit wrote: > > On 10/13/2020 9:17 AM, Jeff Guo wrote: > > > Enable metadata extraction for flexible descriptors in AVF, that > > > would allow network function directly get metadata without > > > additional parsing which would reduce the CPU cost for VFs. The > > > enabling metadata extractions involve the metadata of > > > VLAN/IPv4/IPv6/IPv6-FLOW/TCP/MPLS flexible descriptors, and the VF > > > could negotiate the capability of the flexible descriptor with PF > > > and correspondingly configure the specific offload at receiving queue= s. > > > > > > Signed-off-by: Jeff Guo <jia.guo@intel.com> > > > Acked-by: Haiyue Wang <haiyue.wang@intel.com> > > > --- > > > v8: > > > rebase patch for apply issue > > > > > > v7: > > > clean some useless and add doc > > > > > > v6: > > > rebase patch > > > > > > v5: > > > remove ovs configure since ovs is not protocol extraction > > > > > > v4: > > > add flex desc type in rx queue for handling vector path handle ovs > > > flex type > > > > > > v3: > > > export these global symbols into .map > > > > > > v2: > > > remove makefile change and modify the rxdid handling > > > --- > > > config/rte_config.h | 3 + > > > doc/guides/nics/intel_vf.rst | 16 + > > > doc/guides/rel_notes/release_20_11.rst | 6 + > > > drivers/net/iavf/iavf.h | 24 +- > > > drivers/net/iavf/iavf_ethdev.c | 394 +++++++++++++++++++= +++ > > > drivers/net/iavf/iavf_rxtx.c | 252 ++++++++++++-- > > > drivers/net/iavf/iavf_rxtx.h | 168 +++++---- > > > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 + > > > drivers/net/iavf/iavf_vchnl.c | 22 +- > > > drivers/net/iavf/meson.build | 2 + > > > drivers/net/iavf/rte_pmd_iavf.h | 250 ++++++++++++++ > > > drivers/net/iavf/rte_pmd_iavf_version.map | 13 + > > > 12 files changed, 1039 insertions(+), 114 deletions(-) > > > create mode 100644 drivers/net/iavf/rte_pmd_iavf.h > > > > > > diff --git a/config/rte_config.h b/config/rte_config.h index > > > 03d90d78bc..2c53072c3d 100644 > > > --- a/config/rte_config.h > > > +++ b/config/rte_config.h > > > @@ -127,6 +127,9 @@ > > > #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4 > > > #define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM 4 > > > +/* iavf defines */ > > > +#undef RTE_LIBRTE_IAVF_16BYTE_RX_DESC > > > + > > > > Hi Jeff, > > > > The 'RTE_LIBRTE_IAVF_16BYTE_RX_DESC' was already there, not > introduced > > with this patch, so I think better to add this change as different patc= h. > > > > Also not sure if we want to add more config options to the > > 'rte_config.h', indeed otherway around and we are trying to get rid of > > as much as compile time optios. > > cc'ed Bruce too. > > > Actually, there is also patchset [1] to consider, which changes the forma= t of > these values in the header file. It's better to not "undef" the not set v= alues, > as that prevents someone from setting them via cflags/c_args when buildin= g. >=20 > /Bruce >=20 > [1] http://patches.dpdk.org/project/dpdk/list/?series=3D11928 Ok, make sense, and I will flow the new policy when I update the new versio= n.