From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF18442C6F; Fri, 9 Jun 2023 16:20:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD09C42D8F; Fri, 9 Jun 2023 16:20:43 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) by mails.dpdk.org (Postfix) with ESMTP id B5FAD40EDB for ; Fri, 9 Jun 2023 16:20:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UY8vBo1aR+4iv2hcHjUx9OQY9dbGiOWlRxtaYR3Jh1ACiHCt6DUQX/f6N2wUmskVwKLUnqKhA1QzdtcCd7P/gGNj6wnz7X67UZV/huXP95KZj2UmRAmc0PkgfHah59pgSAOXklG08O20oTrc0ip8/FATdZ71iKQq25w/k9Tx5CXLXUvoe1ky03Eg8CRcVtfJheunMPzRfebKYAbLcpMNVLWzsaxL8eYUh4QWtcVu4pefPWznCMTaoy/XmrtFKEOQo1XmQ0uQzN58vKElFlBSvhYxeuGUdA4U55ZuaxFVSCmNQwQtjxD+fRtYHE5I9gB/nhQAmCA5CEW9kYNHZmA0EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6t6SUTyhJFscCZG/yB6SJ9iBYieNglr/2mwga8cPkQc=; b=BEoqERdF1Z/NlNV71l8TdRtnAaxWQniB3rFrdxCHkUP0MlVBbNzj4DxXjeOq9RV0jbIqsv2/vzOO0k56Pgkwx8CNZMq4SXGC1myHrmEFS6M+TltsQWYlJ/JLd4ZhaSKxhzLICUNu9m9dkvy4D9dxy0ER1uaMHsWvj9s7njI8rUIQJpuyFxeGe/olNVQsOXQHp2b2W+VoWpEghNUxi9zBBQ8e9UCe7hMl6MssWt/Txz4VJbsmd+y5X8svnZYwA61oFSwXp1COHlWIEikeg/HTdw93DYof4wSvczGHJAihtni9lyWWswXuZkUWU/AbgSviXVJ9Wkf7Pbx2cPg6t1THQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6t6SUTyhJFscCZG/yB6SJ9iBYieNglr/2mwga8cPkQc=; b=2YuhKhZbVY0GorhlWPOoeVPSM4Eip3ofgl0eggTqGPGIPLu1ngvkVy2SXD2j/C7yMiG9doK2EtgBaseBiFD0EOCkmbTz5g3TztyNzKyhl1m7a3PweOTBrcVguQpU3ElBu5kdmrSd1O1P2Ffx6agmi9B788LfRSKbWrDg08fVikw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5117.namprd12.prod.outlook.com (2603:10b6:5:390::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Fri, 9 Jun 2023 14:20:36 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6455.037; Fri, 9 Jun 2023 14:20:36 +0000 Message-ID: Date: Fri, 9 Jun 2023 15:20:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] net/dpaa2: change threshold value Content-Language: en-US To: "Sachin Saxena (OSS)" , Tianli Lai , dev@dpdk.org Cc: Hemant Agrawal , Sachin Saxena References: <20230508104133.3566-1-laitianli@tom.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0261.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5117:EE_ X-MS-Office365-Filtering-Correlation-Id: 78d24140-e2ba-453d-89ef-08db68f4b13d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cUOLLoGKWjlYg3YzdQR8FlakQJw9If2Wl+aJuw9F9sykOMGlBBnxaFjMLbt7VM3nEFTf3PGYgTsp2o0m4u1k3H+JU5f2dz5t/J2sHt0nWC5m5IpAc73UKzXaxrlV3XRMk2LNJJZVTBtzDPyRx4etJJsFGGGo/GaMDQMWEO8DqlaxIUMknq/QfpQzL5ueQNJ+X1fD4DyockhnV+NVmNjASyqeLp2JQOh/ZReq7pUW7hdBhA6nr8XD1Cjm6+S9vtcdOokDqcM4J5Qp0vACTsP2DTIfHibB1MX7asAhKCs+oj3fhvx9fTyWVRunJ3kEDE+LwZAPpiDu1Uy7KaBgNVdvyGpkUhssapceQ4AcS1iIy4JcZWsj3JlMw1REsuaKj+l+LK65ne2JPqmn99KaCbfnmM+RV+5dTtqCdiAjec95+/gNZ/HozcgW8HOJasq2chk/gnMEuQyEbXO3rLSrxJSS8Yt+SAGCnqvjqICPIawTzBs9XWJKTYE1+63h/nvrU7mMf0B93nrAMPMKaEYosvhds53M5V7DIb+Hkm6ZKu3Yf0kaP3CkjYmeD9+cJPkiwWQGr3kRCDsM8bco0j5rquKTApNOK9lbJUISuxoLIMX7GpXGf0vFOteE2TvZWVC23m2VotjF+0keK9WQCC3JVNlDuQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(366004)(376002)(39860400002)(396003)(451199021)(2906002)(83380400001)(36756003)(26005)(6506007)(6512007)(478600001)(53546011)(54906003)(110136005)(6486002)(6666004)(8936002)(8676002)(44832011)(41300700001)(5660300002)(2616005)(66946007)(66556008)(66476007)(4326008)(186003)(316002)(38100700002)(86362001)(31696002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2N4aUpJcE5nOEdoSVgvYWZ4VzM5VVBtNThpb25LWDFKem9aYUxrT2NvQldM?= =?utf-8?B?WHVFcjNjWW8zd0c5ajFhVmtmOXF0SHdsblBxYjNPMjJsVEhQRmorU29qY0pS?= =?utf-8?B?UVNOejdWZ1dQNGhIT0Y2MlhvT01KUldPN0IyY2FFSnBQVkYyVCsxdUpCMnFU?= =?utf-8?B?SCtXZG1xU0tMekJCcW5CVlJRNzQ0Mi9QWW1Wb3VCTGtpbnc2c1RlQWovS3lO?= =?utf-8?B?bldDQWYzUGN3NDQvUXRIb2VsanFSUFRGaXVGbVowelRRS0pzOG1GUVBzM2Fv?= =?utf-8?B?UFpjTlN5c1FOS1orM05CRTVrUlVPQkNRWVpEbFV5M3lBclQrTkVEU3VoV1pw?= =?utf-8?B?TzJSeFJLL2NmV3cxQXhNcTZSTys5eTdncjRtUWV5eGRyb2prTWZHNW9rZGRX?= =?utf-8?B?VU9scVVRazlxVjNrV25laUJVNFVxT1k3b3VvWXhPaW15VldzTGF0dmc3ME9n?= =?utf-8?B?bld2cXVYRHRRdmsybWhSMHZUcjVOeTZneW00TnpPa3NRSkhPK0ZGaVVXbzl4?= =?utf-8?B?Y0VpTStuV20zbVZFOXZrWmwwYmZwRkV4RGpiOExpcENOaGpBSU8vZno2WmdZ?= =?utf-8?B?b2NkckNvL1VUa1Z4cUwxV0lScmtRQVVLM0dxYU5OamFmYTduWVdtRWszN05z?= =?utf-8?B?NGtwTlhtZDk0Y1NpdGhJb3lWeU5MRkwrRFNRcGxVb2dYQlNGTGtCWU1IN3U0?= =?utf-8?B?TmFhaVRxWlZLeVU2ZjJSd1JrUkZXcktBaUNiUlRHbnh1cWtUWUJJMEtUbVA4?= =?utf-8?B?ZEg3RjczeHkxUnBMd3JOQjdKZHV5SUF3QXltOUtwWGw2bHpWd1hNUVRUcURG?= =?utf-8?B?K1JtcVErbXdYWHFKSDRNbThDd1d2YjdkUmpWaWlmYmZMbzZCNDNNTStuVmhw?= =?utf-8?B?YU01UmNNb05kNTlvTHZXQ1FRREJMMG5ZcHZZRDN4NklmN1oycEFMdGtJdFBz?= =?utf-8?B?NUFPeVh6VXBwY210VHBaSnZLZHR0ZUdqZE04Y2xDbW5MVVc3WXdPdnp1MXN2?= =?utf-8?B?RGdyVXdBcHNkT2xBWDlkSnF0SFRmaXo1L0lWd3hLZ2NnWGtyNmV5bjRxWFV1?= =?utf-8?B?L1NFcTdXWHVicDVudjdhalJhYWhVczFIS2RwWGxNdVpvL002U0Z0OWlONjlT?= =?utf-8?B?T0pXeDEyeTZ5Q1FaTGp1WXlSZTlCL2ZkRmxQODVxUldlb0xaN3FWdHlSL2tC?= =?utf-8?B?SnYvdEZCSlR5VmpiVUc3QXhpM1BxWUxNc0JvdEIwWi9UekROMnR5OXBEbThG?= =?utf-8?B?Z2gzei91OWl0WUZ5V2hlWjRuNWpGZ3JjNVVIMnk3M1RKNzNnL1hPajNvaHNh?= =?utf-8?B?UHA0ZlcyZ2tRcVlZUzREZWpUQ1hYNzNONjVjN0FEc2pYNHJLVzM1djV2Q0Q3?= =?utf-8?B?TU1RSnl0QXhubjlQMERIODB0M280RWtQeTBIQTRJZnZORXRJTC9WNWZrWXZD?= =?utf-8?B?c3pmY1hjUlhHQTBzZkM1SHdURFZTTkY1TEp1bnFiMmNvYWZuWUVVUmNQaTBW?= =?utf-8?B?UDlwcWlYU0tEb1duUlg1MytxOVEwWXNJU21IUzR5d043cW45QllPUGVyODdz?= =?utf-8?B?QzlkV3M1VWErUHBtUDJnRXN2d2F1OVZ4WStUZDhzVng5MTF6OE9SSWdCeU1V?= =?utf-8?B?RWNxYndFUTFNWkRZcWpVbEtwTFh1ZTF4eS82dGdvRC8wZUV5RE9jdjU3T0Rq?= =?utf-8?B?Mm5xck9TYVhsbE1oRXprYk9KWEppcVc2UUN4TzJyMkJSTkNGOEJTaDd6RWJC?= =?utf-8?B?bHlNN1J3WENBVGFwRWRLSGlLdHRtWmJTeE1oOWVGMVVGaEpqeFc0UlhOZTVJ?= =?utf-8?B?TWdwUmVVY0cvSVlTNDJzN1ZWZ3J3RnE5cFQrbU4zSVp4S0pvUFFaU0F4Q1c4?= =?utf-8?B?WUZhU2dLNEdER1puUFdIaE5vbG1qZ3N4VWdCOFhZMURhRjZaaGFiYkg4REM1?= =?utf-8?B?Y2RMbGxueDRJV21YQnRhSXpqeW9zWWlUWllMZmR6RlJKb0owZXhxTE5oOTVh?= =?utf-8?B?aWZMS3lOSjFJcUd3WDIvMnRIZWhBM1BKbnhidDBWTzBRTDJZaVZmQUJhYkI2?= =?utf-8?B?OUdzQ3RlRGMxay9nTkZhK2ZVMUI0cUdlWFExYUZRQnd0Q3U2ZTI4UEVCbFJV?= =?utf-8?Q?VlAy1/PN1AZlGavQp7jJdZuho?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78d24140-e2ba-453d-89ef-08db68f4b13d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2023 14:20:36.0242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lJt8gFnNGjQsoZyVGDJhkQLAZLBX4YnpU4e50Ei6XKbBYtxbEmwOgHDTTarpqIy/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5117 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/15/2023 9:16 AM, Sachin Saxena (OSS) wrote: > On 5/8/2023 4:11 PM, Tianli Lai wrote: >> Caution: This is an external email. Please take care when clicking >> links or opening attachments. When in doubt, report the message using >> the 'Report this email' button >> >> >> this threshold value can be changed with function argument nb_rx_desc. >> >> Signed-off-by: Tianli Lai >> --- >>   drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c >> b/drivers/net/dpaa2/dpaa2_ethdev.c >> index 679f33ae1a..ad892ded4a 100644 >> --- a/drivers/net/dpaa2/dpaa2_ethdev.c >> +++ b/drivers/net/dpaa2/dpaa2_ethdev.c >> @@ -829,7 +829,7 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev, >>                                                  dpaa2_q->cgid, >> &taildrop); >>                  } else { >>                          /*enabling per rx queue congestion control */ >> -                       taildrop.threshold = CONG_THRESHOLD_RX_BYTES_Q; >> +                       taildrop.threshold = nb_rx_desc * 1024; >>                          taildrop.units = DPNI_CONGESTION_UNIT_BYTES; >>                          taildrop.oal = CONG_RX_OAL; >>                          DPAA2_PMD_DEBUG("Enabling Byte based Drop on >> queue= %d", >> -- >> 2.27.0 >> > Hi Tianli, > > The number of bytes based tail drop threshold value > "CONG_THRESHOLD_RX_BYTES_Q" is an optimized value for dpaa2 platform. we > concluded this value after multiple benchmark experiments in past. > Although, number of frame based threshold value is "nb_rx_desc" based only. > We will further review this suggestion and get back. > Hi Sachin, What is the status of this patch?