From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35D79423EF; Mon, 16 Jan 2023 13:34:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D102640A7D; Mon, 16 Jan 2023 13:34:55 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2046.outbound.protection.outlook.com [40.107.212.46]) by mails.dpdk.org (Postfix) with ESMTP id F10C440042 for ; Mon, 16 Jan 2023 13:34:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4j7icKEI/rZITelVuBbbceQ6ctqCizDP5YtGua0yAfGv1RdO5XTjyu8W9NnDfUo1Gh73WpZ9VWD4cxebU2FkfBktqUyYoeCWhrpCSabJcatD2ynv8jzc6jM1Fu8jjw+guG2iYrHc8YJfl3GMD9D1a3Gi1GZA60UE2fGZegFX8m/0KanJ3HRvC4+efaII0eLJYTbFLIU/VV186zSQk1RWSVIE5XsPeW4TomQ26luxom4JYPiEZz+JHWV+pok1LDZaUq+2zrvfRxgN2SIC4lRrWUr8F+DlFz9wyPIsFTbCqcXkaGpMuhlvs3VlDV9EFexrHJojSkZh5g6pMoz7Lv+wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uegTEc8/4CblqOFxQFQXPmcFrdJI3njA8G4/VPzHMik=; b=fmCUotRR51YFRpAlpeint5ueeguggICjjQa4ro6zbLrG70IZ2w4ULzm5wmz9Soy60KohJACK7wXyO53ul2GkFOG3utrIVtIKQkO773hfS+48KTcXrRnOJ21v+1qoRxZPEXvelgcdkgowa7zsfWt9krBShsXus3dXM2rcmMn4bM4+UtYqRuNSH6YFBN5A5Y50zOXP22kMtjdl+eqk6m7+okwl5jk0Rv/VqzDAQhz7egVuQr0rwMzY8VWIjtlJn3yYsUUk6ek4328FPXmdHYcayMA1BmxkowR7EGq49sW/wcbcdDTXunMSE6cUd5h2dfj+wIOkXLcirTXimtcq12PszA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uegTEc8/4CblqOFxQFQXPmcFrdJI3njA8G4/VPzHMik=; b=E19AXImvtEctvHNhG3k1IIkAbdWMYISIc2lKXOe3pAQlEyB9JKyAZbuLb1rGKxPxN1SAnxG7n2+95Rj9j5RV61yRjB9OEbd2y037f52cVx0GBkTiVTwIUZD4TfumzaDdMoMA8uPK7ypGtC33nc7kefHexK2NH1oRsiZPKGeiRxE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7544.namprd12.prod.outlook.com (2603:10b6:208:42c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.19; Mon, 16 Jan 2023 12:34:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%7]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 12:34:52 +0000 Message-ID: Date: Mon, 16 Jan 2023 12:34:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 0/3] net/bonding: support device private dump Content-Language: en-US To: "lihuisong (C)" , "humin (Q)" , Chengwen Feng , thomas@monjalon.net, ferruh.yigit@xilinx.com Cc: dev@dpdk.org, chas3@att.com References: <20221205081051.25905-1-fengchengwen@huawei.com> <20221214061325.20272-1-fengchengwen@huawei.com> <83aae131-14f0-72b8-4dac-792abc6bb52f@huawei.com> <7c73a379-3775-8138-1fcf-23731f98bb0d@huawei.com> From: Ferruh Yigit In-Reply-To: <7c73a379-3775-8138-1fcf-23731f98bb0d@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0498.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1ab::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7544:EE_ X-MS-Office365-Filtering-Correlation-Id: 90d0fed9-714d-407e-7601-08daf7be1043 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GuEuWEWKKxAJ7ttHrGvlGajna95aibv523NwC4IqOLTYZ4K2+j8zCfNnue8sqJls8Ve+YnqAmtTiQeZab7Xq40HyRPQcT+pBQUlBhmFwhMeqpttIMjFUkUEUaWSGuUR6X3s+5E36WxaG1bLGdrzim/YX/VHc4kBy4oQBGIIFJkVJkU+5up+uXSq0WuXVVllb23wk5pPLgqZ2d3/Y9pgEqxlU+DfXFu2VNWikV3cZuCZjMjjSMJ7cbG8mdR8C18OmpHvMIJaojmuJ5usZwELXef2OXLx5kCrWyenasGqf9Apx9b6Nr8GSH80PVyaSrjZi6me2oF/q91EtrKj8I9QPTfplto8vgTDZuWRJwFxtfnF71QgzA/xBnizwdBQ2CF0zdvJwsUvBWxPFNpHI45m/eTgrNrjI402BpNHAEDG8w2vmivGP+/v3sRx/kDAbkmYjlcOleIW6mqg+h0KGYCh4AzW/SdLVZDoH3xZ1E8ehGNyvv7dT+LYYAGgqn8qb7+tFduUoQoYkvC4GoyWtkW0dU9zfKoiPEB0yZI5J1JWSdcKmVhM6H6GS0a41GfT2m74tF3K/Qaxx3f0BnvtPzfpZDfZRYatQmnG2mjelU6ZFJOvZOiIyZp5s5qAawl73WWmJFCLdMyYC01qwGWIRIF7mqzPOhqs1CvIM7vZQ4AGf6MPfDYRnZav8Gi8DYV1lhPQYavxcXk/6gDf2aDJt7MQ/QJELkRFj/emUiygXfJT8pC4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(366004)(396003)(39860400002)(346002)(136003)(451199015)(41300700001)(36756003)(31696002)(6512007)(5660300002)(8936002)(53546011)(44832011)(26005)(186003)(478600001)(66946007)(2616005)(6506007)(83380400001)(6666004)(110136005)(316002)(6486002)(66476007)(4326008)(8676002)(86362001)(66556008)(38100700002)(2906002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVdaRjlBUzViLzhlTEcwME0xRDdBZldLUGdPTjdRM3AxcG5KRFhXUUZPOWNj?= =?utf-8?B?ZFgrRE5obTRsM3hodmtMZDNac1dlWnF1WWV5aTNwR1oxZyt1cTZ3VVA4T2xE?= =?utf-8?B?ejQ4Q3c0U0NEYy9sM2svYjNLbFhGeTFGdTJMaTVjbWxpRzEyWHVKZ1cxY0Na?= =?utf-8?B?bnY4TWhJS1JRQ3ZTUnkyZFdHL2g2S2ZDeWQrTFRDeittdWZqSmxxM1JxTnRV?= =?utf-8?B?ZjVGUnFWc3dLcDd1T25HUEE0amp1dGVrNXhTSmI2eUZNcnpkSmhJQjJWdHhQ?= =?utf-8?B?REJlaDRSb0FsSFBGWW9BQmV5ZHpuelFiYTZJY1ZLU3F1ZkJtdXNpMEhIVjVM?= =?utf-8?B?UG1MbGtybXpLb2NpS1ZqbEF2N1gzekpHQk01SFp2VHdxcHNDUjlWakEzVVly?= =?utf-8?B?dHlYYndIV0J2bmwwV1VoN2xJZGs4VFFEbUo2bFhZbWtUdlBEb29HeloxMSsx?= =?utf-8?B?U2RmNURhalF5SWgwMit2YXJub0x1Mll4SHR6aGU1RGNxTGdOVVZNRDU3dG9R?= =?utf-8?B?RHhqdkpmajJacWtuVTNsMG5wbDNJRDNaV0pwOUNDNTRjQ2VXN29iMWwvUm5Q?= =?utf-8?B?M3UybXZOK2tBdVJlcy9oZ1pTRUVQM2dtNUQrSHdBY213eVNTRnlHQjRyUTB5?= =?utf-8?B?ajR4VmxKc3JkT240dUtFK0JJdXFCVW00VnhNVDZMK3BjdEUwdFhJRUJ6OXBh?= =?utf-8?B?TE16bGhDTTRmS3VibXcwU0xoZ2tNcnlqc3dGU0ZvZVZsMnJOSTAwY2tNSDJ0?= =?utf-8?B?WFdRRnF2N3B2WWljUDJYOHhsQ3JlbDYvV1UwdGNTMHNGMng0N1czc0FMaXhP?= =?utf-8?B?ZmIxTXdPSld6czhWTTBMSVJoK29obUFMR3RabGxpRGVmajhOOGVQaEtudWVy?= =?utf-8?B?RTZ5SFF3TVdwTVRES0I4NDVXK3B4WE5SaDlrYkF6cnZLU0FVSUw2UDFGTjli?= =?utf-8?B?MnJ0RnhwZVV3azBVRGpjZGFEUU01cnlzWVFBQk5BSXVRTmZ4MDJFU2U2b1Z2?= =?utf-8?B?QVd2WUVRbWhCNEdKUlpTVHAvV01sUlFNblp4dEVGY0VMckw4UElxU1l2U1dl?= =?utf-8?B?OGxaSXJLZTNYZGRRRG9zWjRPSUJNaE1zWTZDc0Uzb2pPVFhqbGZUczFNR1JI?= =?utf-8?B?VStqczlRck5ucDdIQnFYQm5JZkRpUlNOcjA0aG5zbVJWcEVRUVFCTHdRNDd4?= =?utf-8?B?a2pBWUxkNHVTSXVtZlRXdStxSk9XcmZNZGFBTTNPYSt3OUQvUmJURjJ4UDd5?= =?utf-8?B?cFFMMldUeVhwd0g3RHkrZU5yR2lIQTd5TTFESFVwTjFZc1dlU2hLVW9qYkhY?= =?utf-8?B?NG5MY0NzaVBTUnVmZ1JkdEo2NWIxOW1pVDlkWXlNSEdZZGFwRm5tSGpCeU5h?= =?utf-8?B?bW8yODJEOTRIWTZJaENHNW5vWEdEdnl4OHlzamljZUVvUEsrMVN6L2NmTkx3?= =?utf-8?B?S1J1MDJrcFMzQjBlYkl5eXVlcHpNS2ZvWE5nSGd0Zk8ybk0yQ0FPcjFVSjNJ?= =?utf-8?B?MEhMZEQycWNMd1lyYUE4K1d3VXgrQ3RvNHorbHlXcFZjb3dORk1SVFhsWlFN?= =?utf-8?B?SnFpTmxKTlFCWlMwTGRSZ2h5MGZheldPZXU3RkRDYXJDdWpCZmtKVlNKSjFX?= =?utf-8?B?YmxRRlpmTDdhcDc2Y0tKb3RJSjg0aU0vTG82a1c4dzMvbjgrNjlERUo2N3ZU?= =?utf-8?B?QitDU3NlaTJXbTZqSDdpK0hrVktaWGpaWTZqcVRxMS9leDg4dnBmVGYrNzFx?= =?utf-8?B?T3R5c2tRdEJHV2k4QUxGZWNwa0RCMWprcW9WTVpCSXpUR2EvT1llcyt6dVhT?= =?utf-8?B?N2xIbmRZOE1URHZUeUlQVER0bjJvNWEvMGtkSjJpVUlpbXZuUVNndGx0WjVW?= =?utf-8?B?MVYzY09LbUx6eTZvZFQwbzBHRk44S29YVGdLaUwwYnlaeWdvdEdZYXFmVERM?= =?utf-8?B?R3RRcTlBOXd6QW5IOTZWaUxNMkNJb3JxNXRGWnl4Wjc1UmdYVXRjeXRzcTk1?= =?utf-8?B?bkk3UUgrVzc5cEgrWHRJcWxtd05sVFZ5RVNYWkZjR2g1WElBTUo2RGpzUnBR?= =?utf-8?B?b2NUUHlxV3JORHFzR3A5bnRkdk4wUnFIVEUva2hub2ltR0R0U2Rhb3NFeXQ2?= =?utf-8?Q?whvq7L3hEsEHHtDR1av/whcwx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90d0fed9-714d-407e-7601-08daf7be1043 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2023 12:34:51.8955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e+9CYVs5Y0qz+d3LZsbVTtQ3OTqiICTOopIS8LAJcxsCgf3auWxsVxDjh6h3jn24 X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7544 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/15/2022 10:56 AM, lihuisong (C) wrote: > > 在 2022/12/14 17:55, humin (Q) 写道: >> >> 在 2022/12/14 14:13, Chengwen Feng 写道: >>> This patchset adds device private dump for bonding PMD, and use >>> rte_eth_dev_priv_dump API to implement testpmd show bonding command. >>> >>> Chengwen Feng (3): >>>    net/bonding: support private dump ops >>>    net/bonding: support dump LACP info >>>    net/bonding: use dump API to impl show bonding cmd >>> >>> --- >>> v2: >>> * address Min Hu's comment >>> * use rte_eth_dev_priv_dump API to implement testpmd show bonding >>>    command. >>> >>>   .../link_bonding_poll_mode_drv_lib.rst        |  13 +- >>>   drivers/net/bonding/bonding_testpmd.c         | 281 +----------------- >>>   drivers/net/bonding/rte_eth_bond_pmd.c        | 244 ++++++++++++++- >>>   3 files changed, 249 insertions(+), 289 deletions(-) >>> >> Acked-by：Min Hu (Connor) > > Indeed, it is better to move them to bonding PMD. lgtm > Series-acked-by: Huisong Li +1 to move code to bonding PMD & merge LACP info withing show bonding config command and remove the redundant one from bonding testpmd, For series, Acked-by: Ferruh Yigit Series applied to dpdk-next-net/main, thanks.