From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 35DD5457C0;
Wed, 14 Aug 2024 13:19:25 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 28A3F40E09;
Wed, 14 Aug 2024 13:19:25 +0200 (CEST)
Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12])
by mails.dpdk.org (Postfix) with ESMTP id 2E4CE40274
for <dev@dpdk.org>; Wed, 14 Aug 2024 13:19:23 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1723634363; x=1755170363;
h=from:to:cc:subject:date:message-id:mime-version:
content-transfer-encoding;
bh=2FVzmq+F2qnzxgf/q3CeqxjGjvnz/jWZfQDl3iXLqrg=;
b=iHO5dYzTk91WIBJgBk4qElnNV4dCUO7VWW+53u0mKb9zt5ABIDWX1yDq
0ry0Qff/VEYvvv1Fy6NZKb7iYQyB92280ssj86E0MIqvsrB7wjkot8Sc3
c9y+XDqs4+QZaLaJxJJeqoA44n5RkyKVH2OBlVHKrprPGYy6sqeg5e3Ea
N8viN4EysYi/IJ6bpJAVNCHHjE6AA5xn6/TufTtjXL4nD22E67Bkp/bKG
iHud1PG6rGnEStXBUy68NS7EzMADasnZlIDs9TYQPxKAldmOIRgYElDL9
T6jsRVIUB/KcoqSkuzFKdFloepgfdD9p3418jL8IyR/f4gDEiRM2s51so A==;
X-CSE-ConnectionGUID: L0CTyR0IR4q0GUmK5ZrLqw==
X-CSE-MsgGUID: onlkUkm2T3KiGevXUKWNHA==
X-IronPort-AV: E=McAfee;i="6700,10204,11163"; a="25705950"
X-IronPort-AV: E=Sophos;i="6.09,145,1716274800"; d="scan'208";a="25705950"
Received: from orviesa007.jf.intel.com ([10.64.159.147])
by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
14 Aug 2024 04:19:22 -0700
X-CSE-ConnectionGUID: U98g0/qsRUu8DHkPB4+gew==
X-CSE-MsgGUID: MBAZwqD2SfagsNFaPFWPrQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="6.09,145,1716274800"; d="scan'208";a="59554289"
Received: from silpixa00401119.ir.intel.com ([10.55.129.167])
by orviesa007.jf.intel.com with ESMTP; 14 Aug 2024 04:19:21 -0700
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org,
Robin Jarry <rjarry@redhat.com>
Cc: bruce.richardson@intel.com
Subject: [PATCH v1 1/2] usertools/cpu_layout: update coding style
Date: Wed, 14 Aug 2024 12:19:18 +0100
Message-ID: <e51d00fea7c535404dda4d63e483639b13c48b2d.1723634354.git.anatoly.burakov@intel.com>
X-Mailer: git-send-email 2.43.5
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Update coding style:
- make it PEP-484 compliant
- address all flake8, mypy etc. warnings
- use f-strings in place of old-style string interpolation
- refactor printing to make the code more readable
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
usertools/cpu_layout.py | 162 ++++++++++++++++++++++++++--------------
1 file changed, 104 insertions(+), 58 deletions(-)
diff --git a/usertools/cpu_layout.py b/usertools/cpu_layout.py
index 891b9238fa..843b29a134 100755
--- a/usertools/cpu_layout.py
+++ b/usertools/cpu_layout.py
@@ -3,62 +3,108 @@
# Copyright(c) 2010-2014 Intel Corporation
# Copyright(c) 2017 Cavium, Inc. All rights reserved.
-sockets = []
-cores = []
-core_map = {}
-base_path = "/sys/devices/system/cpu"
-fd = open("{}/kernel_max".format(base_path))
-max_cpus = int(fd.read())
-fd.close()
-for cpu in range(max_cpus + 1):
- try:
- fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
- except IOError:
- continue
- core = int(fd.read())
- fd.close()
- fd = open("{}/cpu{}/topology/physical_package_id".format(base_path, cpu))
- socket = int(fd.read())
- fd.close()
- if core not in cores:
- cores.append(core)
- if socket not in sockets:
- sockets.append(socket)
- key = (socket, core)
- if key not in core_map:
- core_map[key] = []
- core_map[key].append(cpu)
-
-print(format("=" * (47 + len(base_path))))
-print("Core and Socket Information (as reported by '{}')".format(base_path))
-print("{}\n".format("=" * (47 + len(base_path))))
-print("cores = ", cores)
-print("sockets = ", sockets)
-print("")
-
-max_processor_len = len(str(len(cores) * len(sockets) * 2 - 1))
-max_thread_count = len(list(core_map.values())[0])
-max_core_map_len = (max_processor_len * max_thread_count) \
- + len(", ") * (max_thread_count - 1) \
- + len('[]') + len('Socket ')
-max_core_id_len = len(str(max(cores)))
-
-output = " ".ljust(max_core_id_len + len('Core '))
-for s in sockets:
- output += " Socket %s" % str(s).ljust(max_core_map_len - len('Socket '))
-print(output)
-
-output = " ".ljust(max_core_id_len + len('Core '))
-for s in sockets:
- output += " --------".ljust(max_core_map_len)
- output += " "
-print(output)
-
-for c in cores:
- output = "Core %s" % str(c).ljust(max_core_id_len)
- for s in sockets:
- if (s, c) in core_map:
- output += " " + str(core_map[(s, c)]).ljust(max_core_map_len)
+from typing import List, Set, Dict, Tuple
+
+
+def _range_expand(rstr: str) -> List[int]:
+ """Expand a range string into a list of integers."""
+ # 0,1-3 => [0, 1-3]
+ ranges = rstr.split(",")
+ valset: List[int] = []
+ for r in ranges:
+ # 1-3 => [1, 2, 3]
+ if "-" in r:
+ start, end = r.split("-")
+ valset.extend(range(int(start), int(end) + 1))
else:
- output += " " * (max_core_map_len + 1)
- print(output)
+ valset.append(int(r))
+ return valset
+
+
+def _read_sysfs(path: str) -> str:
+ with open(path) as fd:
+ return fd.read().strip()
+
+
+def _print_row(row: Tuple[str, ...], col_widths: List[int]) -> None:
+ first, *rest = row
+ w_first, *w_rest = col_widths
+ first_end = " " * 4
+ rest_end = " " * 10
+
+ print(first.ljust(w_first), end=first_end)
+ for cell, width in zip(rest, w_rest):
+ print(cell.rjust(width), end=rest_end)
+ print()
+
+
+def _print_section(heading: str) -> None:
+ sep = "=" * len(heading)
+ print(sep)
+ print(heading)
+ print(sep)
+ print()
+
+
+def _main() -> None:
+ sockets_s: Set[int] = set()
+ cores_s: Set[int] = set()
+ core_map: Dict[Tuple[int, int], List[int]] = {}
+ base_path = "/sys/devices/system/cpu"
+
+ cpus = _range_expand(_read_sysfs(f"{base_path}/online"))
+
+ for cpu in cpus:
+ lcore_base = f"{base_path}/cpu{cpu}"
+ core = int(_read_sysfs(f"{lcore_base}/topology/core_id"))
+ socket = int(_read_sysfs(f"{lcore_base}/topology/physical_package_id"))
+
+ cores_s.add(core)
+ sockets_s.add(socket)
+ key = (socket, core)
+ core_map.setdefault(key, [])
+ core_map[key].append(cpu)
+
+ cores = sorted(cores_s)
+ sockets = sorted(sockets_s)
+
+ _print_section("Core and Socket Information "
+ f"(as reported by '{base_path}')")
+
+ print("cores = ", cores)
+ print("sockets = ", sockets)
+ print()
+
+ # Core, [Socket, Socket, ...]
+ heading_strs = "", *[f"Socket {s}" for s in sockets]
+ sep_strs = tuple("-" * len(hstr) for hstr in heading_strs)
+ rows: List[Tuple[str, ...]] = []
+
+ for c in cores:
+ # Core,
+ row: Tuple[str, ...] = (f"Core {c}",)
+
+ # [lcores, lcores, ...]
+ for s in sockets:
+ try:
+ lcores = core_map[(s, c)]
+ row += (f"{lcores}",)
+ except KeyError:
+ row += ("",)
+ rows += [row]
+
+ # find max widths for each column, including header and rows
+ max_widths = [
+ max([len(tup[col_idx]) for tup in rows + [heading_strs]])
+ for col_idx in range(len(heading_strs))
+ ]
+
+ # print out table taking row widths into account
+ _print_row(heading_strs, max_widths)
+ _print_row(sep_strs, max_widths)
+ for row in rows:
+ _print_row(row, max_widths)
+
+
+if __name__ == "__main__":
+ _main()
--
2.43.5