DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Emma Finn <emma.finn@intel.com>, dev@dpdk.org
Cc: john.mcnamara@intel.com, bernard.iremonger@intel.com,
	stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info
Date: Wed, 29 Aug 2018 17:24:25 +0100	[thread overview]
Message-ID: <e52bde72-d903-b456-9daf-b09586b953d1@intel.com> (raw)
In-Reply-To: <1535539649-7385-1-git-send-email-emma.finn@intel.com>

On 8/29/2018 11:47 AM, Emma Finn wrote:
> existing testpmd command "show port info" is too verbose.
> Added a new summary command to print brief information on ports.
> 
> console output:
> 	testpmd> show port summary all
> 	Number of available ports: 2
> 	Port MAC Address       Name          Driver   Status Link
> 	0    11:22:33:44:55:66 0000:07:00.0, net_i40e, up, 40000 Mbps
> 	1    66:55:44:33:22:11 0000:07:00.1, net_i40e, up, 40000 Mbps
> 
> Signed-off-by: Emma Finn <emma.finn@intel.com>

When header is used, I think no need "," between fields. Except from this,

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

  parent reply	other threads:[~2018-08-29 16:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 14:11 [dpdk-dev] [PATCH v1] testpmd: " Emma Finn
2018-08-28 16:55 ` Stephen Hemminger
2018-08-29  9:48 ` [dpdk-dev] [PATCH v2] app/testpmd: " Emma Finn
2018-08-29 10:47   ` [dpdk-dev] [PATCH v3] " Emma Finn
2018-08-29 15:37     ` Stephen Hemminger
2018-08-29 16:24     ` Ferruh Yigit [this message]
2018-08-30  9:26     ` Iremonger, Bernard
2018-08-30 11:03     ` [dpdk-dev] [PATCH v4] " Emma Finn
2018-08-30 13:12       ` [dpdk-dev] [PATCH v5] " Emma Finn
2018-08-31 16:33         ` Iremonger, Bernard
2018-09-25 10:32         ` [dpdk-dev] [PATCH v6] " Marko Kovacevic
2018-09-25 11:05           ` Iremonger, Bernard
2018-10-11 11:28             ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e52bde72-d903-b456-9daf-b09586b953d1@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=emma.finn@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).