From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A74D65A for <dev@dpdk.org>; Wed, 29 Aug 2018 18:24:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2018 09:24:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,303,1531810800"; d="scan'208";a="79330306" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga003.jf.intel.com with ESMTP; 29 Aug 2018 09:24:26 -0700 To: Emma Finn <emma.finn@intel.com>, dev@dpdk.org Cc: john.mcnamara@intel.com, bernard.iremonger@intel.com, stephen@networkplumber.org References: <1535536120-6934-1-git-send-email-emma.finn@intel.com> <1535539649-7385-1-git-send-email-emma.finn@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Message-ID: <e52bde72-d903-b456-9daf-b09586b953d1@intel.com> Date: Wed, 29 Aug 2018 17:24:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1535539649-7385-1-git-send-email-emma.finn@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: add new command for show port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 29 Aug 2018 16:24:29 -0000 On 8/29/2018 11:47 AM, Emma Finn wrote: > existing testpmd command "show port info" is too verbose. > Added a new summary command to print brief information on ports. > > console output: > testpmd> show port summary all > Number of available ports: 2 > Port MAC Address Name Driver Status Link > 0 11:22:33:44:55:66 0000:07:00.0, net_i40e, up, 40000 Mbps > 1 66:55:44:33:22:11 0000:07:00.1, net_i40e, up, 40000 Mbps > > Signed-off-by: Emma Finn <emma.finn@intel.com> When header is used, I think no need "," between fields. Except from this, Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>