From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 99C9F108F for ; Mon, 16 Jan 2017 20:59:02 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 16 Jan 2017 11:59:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,240,1477983600"; d="scan'208";a="923182303" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 16 Jan 2017 11:59:00 -0800 To: Shreyansh Jain , david.marchand@6wind.com References: <1484581107-2025-1-git-send-email-shreyansh.jain@nxp.com> <1484581107-2025-8-git-send-email-shreyansh.jain@nxp.com> Cc: dev@dpdk.org, thomas.monjalon@6wind.com From: Ferruh Yigit Message-ID: Date: Mon, 16 Jan 2017 19:58:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484581107-2025-8-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 7/8] eal: enable PCI bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2017 19:59:03 -0000 On 1/16/2017 3:38 PM, Shreyansh Jain wrote: > Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage. > > Signed-off-by: Shreyansh Jain > --- <...> > -/* Init the PCI EAL subsystem */ > -int > -rte_eal_pci_init(void) > -{ > - /* for debug purposes, PCI can be disabled */ > - if (internal_config.no_pci) > - return 0; Are we losing this feature? Should this check moved to rte_eal_pci_scan() ? <...>