DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask
@ 2018-11-21 21:20 Mody, Rasesh
  2018-11-21 21:20 ` [dpdk-dev] [PATCH 2/2] doc: update QEDE PMD firmware version Mody, Rasesh
  2018-11-22 10:05 ` [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask Ferruh Yigit
  0 siblings, 2 replies; 3+ messages in thread
From: Mody, Rasesh @ 2018-11-21 21:20 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: Shaikh, Shahed, dev, Dept-Eng DPDK Dev, stable

From: Shahed Shaikh <shahed.shaikh@cavium.com>

Following commit updated the Tx offload mask
commit 1037ed842c37 ("mbuf: fix Tx offload mask").

So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported
Tx offload mask breaks TSO support since application will fail in transmit
prepare function.

Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask")
Cc: stable@dpdk.org

Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
---
 drivers/net/qede/qede_rxtx.h |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h
index 0afadd8..454daa0 100644
--- a/drivers/net/qede/qede_rxtx.h
+++ b/drivers/net/qede/qede_rxtx.h
@@ -149,7 +149,9 @@
 				   PKT_TX_TCP_CKSUM             | \
 				   PKT_TX_UDP_CKSUM             | \
 				   PKT_TX_OUTER_IP_CKSUM        | \
-				   PKT_TX_TCP_SEG)
+				   PKT_TX_TCP_SEG		| \
+				   PKT_TX_IPV4			| \
+				   PKT_TX_IPV6)
 
 #define QEDE_TX_OFFLOAD_MASK (QEDE_TX_CSUM_OFFLOAD_MASK | \
 			      PKT_TX_VLAN_PKT		| \
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dpdk-dev] [PATCH 2/2] doc: update QEDE PMD firmware version
  2018-11-21 21:20 [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask Mody, Rasesh
@ 2018-11-21 21:20 ` Mody, Rasesh
  2018-11-22 10:05 ` [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask Ferruh Yigit
  1 sibling, 0 replies; 3+ messages in thread
From: Mody, Rasesh @ 2018-11-21 21:20 UTC (permalink / raw)
  To: thomas, ferruh.yigit; +Cc: Mody, Rasesh, dev, Dept-Eng DPDK Dev

Update QEDE PMD firmware version to 8.37.7.0

Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
---
 doc/guides/nics/qede.rst |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst
index cba3886..c0a3833 100644
--- a/doc/guides/nics/qede.rst
+++ b/doc/guides/nics/qede.rst
@@ -58,9 +58,9 @@ Supported QLogic Adapters
 Prerequisites
 -------------
 
-- Requires storm firmware version **8.33.12.0**. Firmware may be available
+- Requires storm firmware version **8.37.7.0**. Firmware may be available
   inbox in certain newer Linux distros under the standard directory
-  ``E.g. /lib/firmware/qed/qed_init_values-8.33.12.0.bin``.
+  ``E.g. /lib/firmware/qed/qed_init_values-8.37.7.0.bin``.
   If the required firmware files are not available then download it from
   `linux-firmware git repository <http://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qed>`_
   or `QLogic Driver Download Center <http://driverdownloads.qlogic.com/QLogicDriverDownloads_UI/DefaultNewSearch.aspx>`_.
@@ -106,7 +106,7 @@ enabling debugging options may affect system performance.
 - ``CONFIG_RTE_LIBRTE_QEDE_FW`` (default **""**)
 
   Gives absolute path of firmware file.
-  ``Eg: "/lib/firmware/qed/qed_init_values-8.33.12.0.bin"``
+  ``Eg: "/lib/firmware/qed/qed_init_values-8.37.7.0.bin"``
   Empty string indicates driver will pick up the firmware file
   from the default location /lib/firmware/qed.
   CAUTION this option is more for custom firmware, it is not
-- 
1.7.10.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask
  2018-11-21 21:20 [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask Mody, Rasesh
  2018-11-21 21:20 ` [dpdk-dev] [PATCH 2/2] doc: update QEDE PMD firmware version Mody, Rasesh
@ 2018-11-22 10:05 ` Ferruh Yigit
  1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-22 10:05 UTC (permalink / raw)
  To: Mody, Rasesh, thomas; +Cc: Shaikh, Shahed, dev, Dept-Eng DPDK Dev, stable

On 11/21/2018 9:20 PM, Mody, Rasesh wrote:
> From: Shahed Shaikh <shahed.shaikh@cavium.com>
> 
> Following commit updated the Tx offload mask
> commit 1037ed842c37 ("mbuf: fix Tx offload mask").
> 
> So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported
> Tx offload mask breaks TSO support since application will fail in transmit
> prepare function.
> 
> Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>

Series applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-22 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-21 21:20 [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask Mody, Rasesh
2018-11-21 21:20 ` [dpdk-dev] [PATCH 2/2] doc: update QEDE PMD firmware version Mody, Rasesh
2018-11-22 10:05 ` [dpdk-dev] [PATCH 1/2] net/qede: fix Tx offload mask Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).