From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0060.outbound.protection.outlook.com [104.47.42.60]) by dpdk.org (Postfix) with ESMTP id 7B2771B1A8 for ; Mon, 9 Oct 2017 11:19:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a22+Fkm4+Nrn/zLdBYcSiUwhL+hOoTLLun9hbGMQ/EU=; b=UzOr13DG5URvgS6vERoS472VkQs45hcwGzF4TgkoEtgwtBxJLeN0BnQlvAxUIQur6KN0jRE6DK1QaTe+bopFEB7esL6+XkRQblPObWWK/cle3vJh7ZcPce8Vs2Y0Bb19fO+dBqkDEugkVVFbn9UPEL91Za/3kewLF4tRidbRTz8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [10.89.1.4] (14.140.2.178) by MWHPR07MB3101.namprd07.prod.outlook.com (10.172.95.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 9 Oct 2017 09:19:49 +0000 To: Thomas Monjalon References: <20170831063719.19273-1-santosh.shukla@caviumnetworks.com> <0d07a0ca-5fb3-f275-9d5f-2f30a8503caa@caviumnetworks.com> <79352056.QgdvfuXRzQ@xps> Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, John McNamara , ferruh.yigit@intel.com From: santosh Message-ID: Date: Mon, 9 Oct 2017 14:49:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <79352056.QgdvfuXRzQ@xps> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: MWHPR02CA0019.namprd02.prod.outlook.com (10.168.209.157) To MWHPR07MB3101.namprd07.prod.outlook.com (10.172.95.7) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: adbb2d6b-4b59-4f74-13e8-08d50ef6e5d4 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:MWHPR07MB3101; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3101; 3:kARm7Efg3MrTmgIUJ7tcVso3LPGlwblZUYMOSO4bvM9wVNUo2S25qjnKVzZ/AbuMi2Dmj/C/Y+lvN2g/d+x9hpBKW9xFiSbrM/j9y/DX86Z6OUn2+zU8YGD8BaBXLxgJpclXt5KA8Hn4Uc35g1IlR2g35VSX3RNLzyw+X+b2wbZKNQEHiIBnvUUtp+w6D2LPD3e3e/MixUhXt6Pb3zAOx+cLfpTr31d9ZWtmTAIDO4Ren+OrpES/aR6Y15is+mTI; 25:qBJgi1EYpvBQ4ofzrrtrrjKJXSg4MTJV4azPkzGZqG/RBAnc7mh+jhkuUcdFT8ugjv0ohpc59XDLwjtBQe91mk8jNjpzm9/fLsDgpx7tuGAYdLRQOQdR3MyB+cUJP8yuAysW2LUifvxnrXOhhD6gfLsSlI8TqNe3wKTBPUjy6GzxMgYXxQ99QTMednjjYAO1JbPhWiMyAngt1w5MoJ0ejRyOlF9MCpSbukDk5HvoGTDMgJr2QluuihYE2d2Ej2ddOPApPBGXX4JYDyHypG0nEnjjnNN66ckFI0M6du4iDXUDSo/PbE6jC+p3W+ZvRWqRRNyYzsEvEsK88RdumASl3w==; 31:P8QERRKB7wWHnUVYBwOfBw6IRsiFTrA7RcxYuU1xKH06uhXKKGh5Q5Q5W0jzcxd6NFk7k/j3D9j6vptrdd6xwGIlWBrcSF3xv2CS7/AMIHwMjZq9mmHjrvHhKhI81skzM5dxYOpgaBgrHsLdGLcvCfImLXA+5mAXM3d/pgga08jhjAhORJxnw2vGZ6rDTsQ9UPcO25I03LQmSBcya3e4uGAg62IP/nEW03cNWGmjCtw= X-MS-TrafficTypeDiagnostic: MWHPR07MB3101: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3101; 20:nE++3k1APG5AG1jBjYbnCwKLstXbExOzdwBFhZxjKzWofOu31STphulsQKEe2gdjuW9zaOMTkIOmW5WCZdK/ZYCoqFE+BRMMfTMTPAKVmjgLAjneVlZCTnky9V1gVP+sz3zRai/3I4rCIJeRPE5LDrQ0F+f4Tg32zs3mrnaQLgijXKlor28wVeONjq4whbS/gEVI6QlECRChzYKqneYFwyG5JbStqf0QcpTacHek1FVXhXAmka1G5I7kLXaRoCb6OdoKlXpdx9XUDl8+GmE4uVcO7uqgfdW5ycbAE07KIFfvUITat+sLXBTt7uvlVy9f23IX84+SpZRJhb67zH/0RZAfaCKQ6mYzBHcyHpxmrcexDsckKa5/cj5Je87leiJmFCgZH6ZuJsa+PGrkk2QsXzSHNcIB+ObsgxiYm6yO+NHPi+6Z6+egXkbmVgODBct28S0RiJbKNH32Lx/BcBnEo3cCMR9LFJEJecuyNVwkL2sA9ZdiklyEfIC+a++jUKVjt7HSALkAlHeuQJZ0ycUigPHyfNAdussRbMmzumTbG6oODuep2LRbFvthMTk3y5ZuhH99mzL5sytr6fa/mWNGGHposOQ/Y2l0ks321jiaOy8=; 4:bdVs4RjaNO0k2yL8ZqRNymK4QqUjdhZyW3E+2dLqnypJR//QW1RiAFm5JHAQQoaEDUYUJQUCq2/azHUPzB19xqpmjl70ulibUykqm5zKfiZDEZdo+uMObCxFDW8lZiZVsj+3FVq8OTkUy6bv1D9NhxbbcRQ4M1d2vr9JWijBKORC+JO9vlfZY0rqGnH8QTPVHy9bvfBECHUMkJOnAIbIFUIrO7k/Rhwurps5B6Zc1iSz8W4a8orN2z3oQyyCQaizvva0cWlrt/AOuT+ETU8nezbr8F2Vmeb4oGlBAsMcfNI= X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(93006095)(100000703101)(100105400095)(3002001)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR07MB3101; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR07MB3101; X-Forefront-PRVS: 045584D28C X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(6049001)(346002)(376002)(24454002)(189002)(377454003)(199003)(42882006)(3846002)(50986999)(65826007)(68736007)(6116002)(65956001)(65806001)(6246003)(316002)(66066001)(86152003)(25786009)(8936002)(4326008)(81156014)(81166006)(189998001)(93886005)(106356001)(105586002)(77096006)(229853002)(16526018)(47776003)(23746002)(90366009)(83506001)(6666003)(6486002)(64126003)(58126008)(97736004)(50466002)(230700001)(6306002)(5009440100003)(31686004)(2906002)(478600001)(53376002)(966005)(53936002)(31696002)(72206003)(6916009)(101416001)(54356999)(76176999)(16576012)(8676002)(2950100002)(36756003)(305945005)(8656003)(33646002)(7736002)(5660300001)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3101; H:[10.89.1.4]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR07MB3101; 23:gScdGQQkR0MbiAMZ/hJjN8WpiaseVbDqa8be9?= =?Windows-1252?Q?3yNIo8fdPrKLkHaoUtAN0wrcQ3B5XObNUMXd+AF5XMA9daj8HwzAgiHY?= =?Windows-1252?Q?Olw4SqOLer9RJTuCow7T3KcluVIFG2ZaRu/Ww/TRCL6lIBdObSGxBkmv?= =?Windows-1252?Q?YA99269YbDYrOxEGotvPHM4YmTAsuyKvhW/tdYNbs/d55Rp637qph7x4?= =?Windows-1252?Q?EQaGXTrjNLw7pL820JuXi7khTU5vMDuqz9OHtdC+090A8kOyrYd9ZEzs?= =?Windows-1252?Q?g8SuT81DcdwPFFPbIfzMtms/tS1U0v4p5uY0re2p8pFy3dXKB0zzJd+0?= =?Windows-1252?Q?dns48Depgql0COvyxK4lt0mp+KtYPCCJ4B3tqSilUdPtSKb07XlJ5tAB?= =?Windows-1252?Q?eJAqxXWvOoR8T1BFMQp4vNhgnfDXWG4VP25xGuiAoGBl7wGGuAwKRmQK?= =?Windows-1252?Q?WMNxAr+YOBhgbOf1KGew4IouL5dKeBkISldFR9CrLT5/JZgJRbOSXmmW?= =?Windows-1252?Q?hyK9sLsLlE24VnmN8vFTgYM5z2MpDPe62nfh6GJfpVSio1Mow1VJgYD4?= =?Windows-1252?Q?FVXSIDPADFzuaYD+D4WiwddH5E7EZ4o78k+fbe5J21UwvQsLrJ9KHn+s?= =?Windows-1252?Q?l14timCQ425XRnJxnQk0wJ5H1nJwHDm44TW8cIa2ltLiuVlR9gv7cHfg?= =?Windows-1252?Q?NAzyXP6Rj+xsjcCaoOOWt6KC/FLe5aW5rfylAft6mxp6VIJrTNirFQXu?= =?Windows-1252?Q?UczfvcZ5qDU9/4c3eqkmun2IXfLVE3lOxIXQYLEZAH6xN8aQ3eYAREuJ?= =?Windows-1252?Q?VdnkTPNbXVb7/qyAU7lbzPETCbB9vHViSKncU+ORtCcRW+8RuwR7Khe6?= =?Windows-1252?Q?TdeD45yPaq8e9BkK0UyP1qslCsMHAS96j++e6Nz4Nh+IcHRq2SbE3gNM?= =?Windows-1252?Q?fjmc9Hofd+/gk5C3AAOKGbUTJjGKZfqGIpyoecMQ/aDaCSCikm4HijlP?= =?Windows-1252?Q?nOram4Cw5kncJ8W7HG91b+y2k+qakHoBRXdq5Vm7tuNLBs+SfDtCOTIU?= =?Windows-1252?Q?DqPZizqM9RC2fukFYyO3waFlCh8gbb/nU5MQ+0RTyniONreNCAWozgEK?= =?Windows-1252?Q?uj/+QUF706DpwW793F3bGhpCbbQUiMUyTuWIdnIIIyrFsXW79zjH5TQq?= =?Windows-1252?Q?jZlHNAmJOLSo43J9grgvwftIDltXfin1tkTPPoOyP1Wc4NyC3uuV9zRn?= =?Windows-1252?Q?gL1bhqBBLS/J8CbXRDUqdyQayY2A/iJLIGzBZI7775bJSOrNKwBVdycY?= =?Windows-1252?Q?lxxfGn1tpVnK58LLYxbXxzhuxa9ikeAlN3wPwNORjSavy+sJqmtea0s+?= =?Windows-1252?Q?4Fkm0a328mhDb++jrXKh86Qkcxuuj0z3+iOg1hwgqfbCDdsv/V5cfpcC?= =?Windows-1252?Q?VZXouAs5mIaCHe+eoqj9Da5KsEXLP6Y5+niUQdLwl3X6vXXOQYf6t0OD?= =?Windows-1252?Q?Su/iPgAT0K87VWF8d+wRAggKPTP3fdH4gd7t5CKL+e31j0uk3Y5qEmtx?= =?Windows-1252?Q?k1CoQRp6Ue9YCUxuCpmp6Te8mGvPdYapsLXSfpuiwB7sy1FYOW4DAOPq?= =?Windows-1252?Q?mXIce+2AL4pIEv//+GHSkT75gmiWFdRN2E7/DRySasp?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3101; 6:JDG5++vK5uzWg400MI4Oq79Gh2wl140THb/oze2PAwGpCZtetFukxMXpgr2nLAFlAy9lBXY1/3Kv6Ac1Z6l7DYrR8M3gBx3XRyBAEYRNS/dbWORwBPOk29fTW6o8RfoOmmd/+Wqzx703zvSc4PBfbJgQUFkApHIwIJHroatEQS/7XnvDT8Z+0e7Azk0eKNNt6u9TZxbkUmZJIEPqJBdw8pq6hiY+2pU1plVQryuQaBTj10tWyFNSd09eOmKet8WtohnOiVPP8uIgkbCU57gmsIkuW5zOb+M+HFWCh/y0OycMJAO3GlZuka6v4m8oUaiJKTBzR+sc/gcQ5xzkj8rXJQ==; 5:vntiVG+tVM7+0NflmrF28q1FjYP0jEyR5Z7LOe/y0yd+z0WTyTlUanmgr/2liq7U/QPqZaDPJaFIE7uIHGtjhpVYXjbQruqvd2mp+pWb3LttOC2Oc8l6ZFAaYHpHBInohji78hCjrsYJKJBfUOgcsQ==; 24:iQW/8Di9KITt0hYOBY/WmAc6dIOLIxa9cHujwM7b6JZ6rcNDbTi6QVKvuuRp36EJeBQ7XoJZrzw6l4kr8313kvUfcUo9O9p9uVDHzy/EXvI=; 7:IQ9H0zbhk1v40Jq9pY4nRnOtk38oxIItmYpO7JuYvKZH9cgZOD0C9E0pHLO8v5bF15SHjFl7sJBi9XDrsgPZjURvMu25aoXP1puAeSlY4WZWuvQRhmbpzxY98z5HE/PwNCPhu4MJQjnu9JH+mXxHnPWu+vZoysPAHkRLiaRGfbCfQfeoyLBAW5uaiI/WOP62Ek2Uh6sB9Dpp79+tCmSbrl5Qk4smqb6otfl0R6J4PKA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2017 09:19:49.1855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3101 Subject: Re: [dpdk-dev] [PATCH v3 10/10] doc: add mempool and octeontx mempool device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2017 09:19:57 -0000 On Monday 09 October 2017 02:18 PM, Thomas Monjalon wrote: > 09/10/2017 07:46, santosh: >> On Monday 09 October 2017 10:31 AM, santosh wrote: >>> Hi Thomas, >>> >>> >>> On Sunday 08 October 2017 10:13 PM, Thomas Monjalon wrote: >>>> 08/10/2017 14:40, Santosh Shukla: >>>>> This commit adds a section to the docs listing the mempool >>>>> device PMDs available. >>>> It is confusing to add a mempool guide, given that we already have >>>> a mempool section in the programmer's guide: >>>> http://dpdk.org/doc/guides/prog_guide/mempool_lib.html >>>> >>>> And we will probably need also some doc for bus drivers. >>>> >>>> I think it would be more interesting to create a platform guide >>>> where you can describe the bus and the mempool. >>>> OK for doc/guides/platform/octeontx.rst ? >>> No Strong opinion, >>> >>> But IMO, purpose of introducing mempool PMD was inspired from >>> eventdev, Which I find pretty organized. >>> >>> Yes, we have mempool_lib guide but that is more about common mempool >>> layer details like api, structure layout etc.. I wanted >>> to add guide which tells about mempool PMD's and their capability >>> if any, thats why included octeontx as strarter and was thinking >>> that other external-mempool PMDs like dpaa/dpaa2 , sw ring pmd may come >>> later. > Yes sure it is interesting. > The question is to know if mempool drivers make sense in their own guide > or if it's better to group them with all related platform specifics. I vote for keeping them just like Eventdev/cryptodev, has vendor specific PMD's under one roof.. (has both s/w and hw). >>> If above said does not make sense then will follow Thomas proposition >>> and propose a patch. >>> >>> Thoughts? >>> >> Additional input: >> >> mempool PMD logically can work across nics.. could be a reason >> to not to mention under platform/octeontx or platform/dpaa ..etc.. > I don't understand. OcteonTx mempool works only on OcteonTX? Can work on other external PCI-e nics though current pmd don;t support. > Are you saying that OcteonTX can be managed as a device? > Yes. For example: We have standalone test application for mempool for test purpose, so to test standlone mempool device, right? if user gives ]octeontx_fpavf' pool handle then test works just like for s/w ring. BTW: HW mempool offload behaves just like ring for example, Only difference buffer mgmt is ofloaded. Having said that In theory, offload mempool driver Or s/w pool driver should be agnostic. (my 2 cents). Thanks. >> IMO, Its worth adding a new section for mempool PMD. >> >> Thoughts? >> >> Regards, >> >>>> I choose to integrate this series without this last patch. >>>> I mark this patch as rejected. >>>> Please submit a new one separately. >>>> >>>>> It then adds the octeontx fpavf mempool PMD to the listed mempool >>>>> devices. >>>>> >>>>> Cc: John McNamara >>>>> >>>>> Signed-off-by: Santosh Shukla >>>>> Signed-off-by: Jerin Jacob >>>>> Reviewed-by: John McNamara >>>>> --- >>>> [...] >>>>> --- a/MAINTAINERS >>>>> +++ b/MAINTAINERS >>>>> @@ -340,6 +340,13 @@ F: drivers/net/liquidio/ >>>>> F: doc/guides/nics/liquidio.rst >>>>> F: doc/guides/nics/features/liquidio.ini >>>>> >>>>> +Cavium Octeontx Mempool >>>>> +M: Santosh Shukla >>>>> +M: Jerin Jacob >>>>> +F: drivers/mempool/octeontx >>>> A slash is missing at the end of the directory. >>>> >>>> Until now, the mempool and bus drivers are listed with net drivers. >>>> We could move them in a platform section later. >>>> For now, let's put it as "Cavium OcteonTX" in net drivers. >>>> >>>> I fixed and merged it with the first patch. >>> Thanks. >>> >>> IMO, for MAINTAINERS file: >>> Just like we have entry for "Eventdev Driver" and underneath >>> to that- all vendor specific PMD sits, I was thinking to >>> introduce "Mempool Drivers" such that we place all >>> external mempool PMDs + s/w PMD (example: Ring) sits underneath. >>> >>> thoughts? > No need to move SW mempool drivers in a different section. > They are maintained by Olivier with the mempool core code. > > I have the feeling that all platform specific stuff > (bus, mempool, makefile and config file) are maintained by > the same persons. > I think it is easier to know who contact for issues with a platform.