From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA420432F3; Fri, 10 Nov 2023 17:24:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D6FE42DB0; Fri, 10 Nov 2023 17:24:08 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2040.outbound.protection.outlook.com [40.107.243.40]) by mails.dpdk.org (Postfix) with ESMTP id 395DB40695 for ; Fri, 10 Nov 2023 17:24:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mF+yMKxCNg+RlCwDAkvLbNgka4UYYawIEkt5iGpsmteg04skTqrgjP+1Zr5pzRvcju40zEz4Y/YK+Qr7itYuZsqgTzQuEN9qta5TFf9gZ9TqMYcvagUUOTDr+QhMQjpDxr+99IFLUHFwj03CAB8ZnBZs1CzT7QevDTU3AA88ky0N+IMt6+BfIenxKYzygl1H4pFylXo2TTxYiOduEn7XB2q6P7JPgHX4RTE27TadzZmxlLgnkMc011o1LPWR+a+cgCkNuOikjvk+oVSLUjCQsFbWZ07VXmBtN1K0WGcopbGnkOvhDPwUHrhu6R0PbVnrn5BuzmYM+53OXf8ZBtpFbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2O8QsCHh3NwgCzIgF2C4/QQM++o2ePx2eHi3hAUIZPE=; b=Gtmi37o52a3Jg7GnF37j7IxtXX3gCDLaGgMZcvJ8mfxDC+VE+SB3/f6JqIkFtkIcvXMhMYatzyeg24psDhENCa+xinPP6aek5EX/iewAFLRjP2C6/3aw6f07KOvn2J5NrmO1LnXueqYJxD6SY0F3JHDUc9mbqSfuEji+jiup4sx2V6o/0Rbl2eIOSnBxfO5PvHhq8vig9dbsq3nj0mTG4zdB4h2zBfGYiGdm9/fqk0WbUHXZ4vXUZCyaNcMeYdVCVosT56tSuVs/u/wl9/VZiw92/4MCwWwWykoSuQ6P9SOutGkgoe3/Cjx9qnzPgZ0neImWaAM0XYHrO3SoCBU8pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2O8QsCHh3NwgCzIgF2C4/QQM++o2ePx2eHi3hAUIZPE=; b=snixVXZDs9BcPMoxU7m2hxfh2IrxK4unkxmayD7Oa8n9BwDusubL0GxeVVH8me4TsQ4MBPf+i8BTo1wc0plyW5/q8uQ+ayc205vrrGJJRUk6qZ7KGvy8BIFEhHP5NrnFCoef8DsMliNJL+29u4F8uSUUUVeKJ3mBKtypImNTbPM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4328.namprd12.prod.outlook.com (2603:10b6:610:a6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Fri, 10 Nov 2023 16:24:03 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Fri, 10 Nov 2023 16:24:03 +0000 Message-ID: Date: Fri, 10 Nov 2023 16:23:40 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] net/hns3: refactor send mailbox function Content-Language: en-US To: Jie Hai , dev@dpdk.org, Yisen Zhuang , Ferruh Yigit , "Wei Hu (Xavier)" , Chunsong Feng , "Min Hu (Connor)" , Huisong Li Cc: fengchengwen@huawei.com, liudongdong3@huawei.com References: <20231108034434.559030-1-haijie1@huawei.com> <20231110061331.3670158-1-haijie1@huawei.com> <20231110061331.3670158-6-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231110061331.3670158-6-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0283.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e6::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4328:EE_ X-MS-Office365-Filtering-Correlation-Id: 77a1d87c-7d6e-4597-4027-08dbe209740a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HDPVX56OyQ3cI9aMFFoOs30AX7U9lx6vPq5TwtZqcF2gGTprGXS4e94mFPDjCRq5XHtkDq1OgxosmRZ37YowkKnmtC6isK5M/lH/LRCuWL9ZKDEnkaixl+GBw7woE6KD3WXCDmjyQl9YexLjMBESrmWMuq1TtaU1wqWdbIXn9UOa5CN9Jx4jfhny/J9naC3WAtHx9tBL07+haTWIsktB1HYeagNFolpbMhG82KuzlTQa4gFQ8tH0dVI81+U8ndIQCqrcQXyZrHjmLBkKA4J4Hk40PUa2SMmvUwEbEnjH3DpAU5GEzjLhVjKiD8WgaNMxdJgvB8Ht+0buMaEkeiLuRU9eEa1nCirQoXvSOVeFhKVSBPpMa2v6BCuEdLxN/aH4JJRtYOOq5y7O1aqIgeIaczfKfMVT5radWfmphY7eOOd0oVkoxuMA0uQyBeJ83zrwCNP5dKyylFMcyCq3Qm3zE6iq+DyzlITgGYuysVT9CjwpfSt1ZgxIvcXV5lHkNjff3oS5oLTpz8VOyZq8BChxHc3evh+8HqGEnQO85JHI+vN4gR5RtC9QlslmYioSKNrvKcbyU3wqrdlpboupdnrVhtT3jwS8h48deAXeaiDNxOy+7/z4erRjUbft04gMe9J5cQTAbF+Gd4pEdzkdOWq58g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(136003)(376002)(396003)(346002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(83380400001)(6512007)(2616005)(53546011)(6506007)(478600001)(6486002)(6666004)(2906002)(26005)(41300700001)(66946007)(66476007)(66556008)(8936002)(4326008)(110136005)(8676002)(15650500001)(7416002)(316002)(38100700002)(36756003)(86362001)(5660300002)(31696002)(44832011)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGgyZDQ4dUZ0OEg2MWVLeW1ab2hjdFBHenUraUFTcTJnbWtST2VmYmd2Tmpy?= =?utf-8?B?dVUzVkUvTzNTMSt5SDczbU42S0hhQTZlOC9WYlI0NmhKVXNqRWZsZ3Z0T2dr?= =?utf-8?B?RDFSSFliZDEycHJVZjFldU9lMGFZYTVIS2t2QnBNbHpwKzZHZEtBbW9rRnZw?= =?utf-8?B?WWNhZzZQWkhnL1ZINFZ0VlAwQktVZlF0MXB4SlF4QkxCNDQ5dm1RV3pxcjA1?= =?utf-8?B?Y2JJWmw2UTBnWmFKdEpzS2dWaExDSHUya1VLUC9qV2xYV1dpT0wrMjBBZktE?= =?utf-8?B?NkllZEhwbDZoVUdWZGVZLzBrbUt5SUV3WVNWSE9kb1E4Z2FGV3BWdDdFcWR4?= =?utf-8?B?MGVkSE9UMlFaSEloSjh0dHc3NDU4bW1CNHQxQ2RaaFJ5VWptdlRzSjYzeWs3?= =?utf-8?B?NWZnL0ZZOTBlZmx4cWt5UHVCazllN3hYTGNQa2hMZ1Zobm8rZ2hhMmtSMXdT?= =?utf-8?B?ZVJZK3NlQjlsdE5kYzNRVEpZV3QrNzZDc0UrMnV5R3R3Q284NmwzS0F5ZENJ?= =?utf-8?B?RlE3TjlPTXFocXlEOHpnZHY1d1RXUXdLQW4yRFlNTDFLa0p4S3V5aDBLd2Nn?= =?utf-8?B?dEk4d3JtSW13ekN3VjRTNFJUTWhUK29raU9Dem9yb0tydTU3c0JYMWRIREpD?= =?utf-8?B?UnpBbW42N3pXOXJuNWczWktXRGh0M2hUcE9YUFRyYlZjZHllSENhUG5QeFdv?= =?utf-8?B?SjJjZE94dXZTdlhWd3hUMXBaV2oxZHF4c1p5UWFrUXBsSXh2MTUramZDeGps?= =?utf-8?B?M3A3aTNVbnZRTWZGYUduTy9Uanh1OHArWmpUa3l2alNHLzBNMnNlYWpGc3Vk?= =?utf-8?B?M05iZ3Fock9pVm1DVjFZa2x3dllxTC9lZjM5UjRpSTlhbkxyOFRiaFA4TU9h?= =?utf-8?B?T3ZJTTlENGlUZ3VhaG4weUhqcTBDeElncjllSUlJZ21JcTQ2ZndYTkl0OFhh?= =?utf-8?B?UHVBNGlvSkRibmo5c1ZwTmRRMG9ndjNQOGo5d0xnNHhaQVpZWE9DMUlYL1B6?= =?utf-8?B?c1dXNFJBaXZxV3U0dng3WC92TktXVkhsNm1SdUo3S092Mmt1YmtQR0tqbEJR?= =?utf-8?B?L05YVFpXUEdUS2RJWmMrMllSZDdsYVdNaVBYL3I4MSs2c2NxK2hFVDdIWkw2?= =?utf-8?B?WnJGWUk4VUx1WS83UnBpRG1GZXh6aUJrTGF0MEtTblVGdTVxRnlqN2dOdnZW?= =?utf-8?B?VkZlUkNpWTAydko0UjM0M1BpeHZ5aHh4R0YvR0IrbEtNdlRCdjBLTFM4R1hS?= =?utf-8?B?TzF4T2NVMEVxbGRDdVlaZEhialVPam1yMW5iYUJJL2ljbERKRGlIR1JrbEp1?= =?utf-8?B?WkxBWmZzNmFRckk2cHBzRHBEQ3BZUnNXa1ZxUGVWK1ZyNElCcExZajJ3Mi85?= =?utf-8?B?SzdNSzJJUWJtd1BKcDBHeVNvM2h5K0JsRFMrUEtHRWVyUFc2ZFpNNUxqOThN?= =?utf-8?B?RlVUK3lOWHlTNjRUbW0wWUZ2dWxkcVZwNTk0VnJoeDQ4QUFXeUdLWVRyK3R1?= =?utf-8?B?RDJVWmErOFBnU3ViWlNlOTcwSHlseDRNOHFTL2V1WlFWbnpWR2RJVkwvMDB6?= =?utf-8?B?dzMyemNMUkdZa2NhYVVVYWtJMFlSdThlQjRXVWhFYXI5N2YyTnVGWG9LVG9D?= =?utf-8?B?TnFTZjJjNlVJc1Q0emNKZ1UzSWZ5WDR3WHlCVmxKeVc1R3VWS0RRbCtCc3Vx?= =?utf-8?B?YnlxL3Y3ZW1DWGJwQlFSTFk1N3Y0d3hXMENBcHZNNlBkbkxwL2txL3MyRUZD?= =?utf-8?B?d1lqRGJWbjVacUtuQWorY3oreWN4RHh3WGZUVzgwY2NmYzkvZTh4TEphNVFz?= =?utf-8?B?OHYxZ2szcy9UWDRkbmN1cXFOT3FuTnZiL2huekVPWDNxd2dWbHBHS1MyUWF6?= =?utf-8?B?cVpCczlZVy95NXBNZVd5Uk5nemhtKyszaklWcWhsNzlpTVBEelFxbXV2U2Y0?= =?utf-8?B?eXUvMDJPeHNQZFJPaTlTQnpKVWxkV3hPNDB2VlJuU2tEUUQ0R3RiYkdrWGU5?= =?utf-8?B?MmkzS0g4RnFxMmZvMzVaLzIzQnRNTlE1ZkRheFZ2TXE4dVgrb1dxeWNFNFps?= =?utf-8?B?TWFCWGlDeVBZc0lxdUNnWGVVbUpNVklJSnRKLzZUakFoQzhuYjFJZUxLczJ3?= =?utf-8?Q?K8d0=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77a1d87c-7d6e-4597-4027-08dbe209740a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2023 16:24:03.7370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /x6tMCpO23Lh0iYrhX01MirGCBgMuKct3/dJIsv88ill4oF8itzKagcILoIhrK9N X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4328 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2023 6:13 AM, Jie Hai wrote: > From: Dengdui Huang > > The 'hns3_send_mbx_msg' function has following problem: > 1. the name is vague, missing caller indication. > 2. too many input parameters because the filling messages > are placed in commands the send command. > > Therefore, a common interface is encapsulated to fill in > the mailbox message before sending it. > > Fixes: 463e748964f5 ("net/hns3: support mailbox") > Cc: stable@dpdk.org > > Signed-off-by: Dengdui Huang > Signed-off-by: Jie Hai <...> > @@ -635,8 +642,8 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw) > rte_atomic_store_explicit(&vf->pf_push_lsc_cap, HNS3_PF_PUSH_LSC_CAP_UNKNOWN, > rte_memory_order_release); > > - (void)hns3_send_mbx_msg(hw, HNS3_MBX_GET_LINK_STATUS, 0, NULL, 0, false, > - NULL, 0); > + hns3vf_mbx_setup(&req, HNS3_MBX_GET_LINK_STATUS, 0); > + (void)hns3vf_mbx_send(hw, &req, false, NULL, 0); > 'req' is not declared in this function scope but used.