From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3713A0560; Tue, 18 Oct 2022 14:27:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6242C40395; Tue, 18 Oct 2022 14:27:12 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2086.outbound.protection.outlook.com [40.107.223.86]) by mails.dpdk.org (Postfix) with ESMTP id E0DF84021E for ; Tue, 18 Oct 2022 14:27:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=llflBFvnngz4tetEHB2XiwSu/zYcleaRhVLWVCVGWRTJOKM5s8kiMUGe7GMzeS/+KrQKdgwmIXTpBs7MLvryJ3QfmiqvDua5wNmq1cOySb/DDo8VuLnqUbzRUpCS2noK2ooQw52+7swwz6pkV0RGzuV47DckYYcKP8SSRnIazlEvPiUtHx7q6uSRRixnCkIQ3a5gg7uUh4MwiLvT6bmOayvRKCuF4d7Eq+Zq1NT9D3yplXnSpP9LaHscve8u8UYn8LoWVttr4sNp5iNPIFsvHZDQr+pjGjFLFVeC9mYQy+4uiLI+p1EF8odCzJ29K3ytrZY+yxmhh4IrHf28J5XL0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dvCivHUWf3e92KhY+tm5JMeSQLOmBCWtD+5BMgbcAAs=; b=UH7YtzMR3rFshFjJxbda0bprKiR54GVtGy/ihsPUABhtzN9rQROQImLYEW8uk/26+gwhqoUEtvg0QsxA8vKsxzA/xld1/PLAfX+nl+iNn8lyUYFz/DkYbZIwQ6NWo0IpsJQTv2ZruMSsDWLYKfq2K0akGswmNmjVwuvXvN4ONCaAvyp42rkVXnn2jGwF/+2MFt/ONRb47ALjb/GXxBBIPdWWwnfTgaOyLgzLDUnZwewq9x4UIqOUtL/2m7VhILoyqZSoWGbzpt1WThg3yYncBZWj09xCZ2Guh2ST/VKMikvJBF4sd5PX72KT5V9nQ+nAoV1Axx3ncmR7ecAJyEitYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dvCivHUWf3e92KhY+tm5JMeSQLOmBCWtD+5BMgbcAAs=; b=Hs/j3LwPVUwiTh6h2kvfwNfbzB1TcgmPX9W+8aD2Kh8DnN+B/Bza8SF5C584WNaUpIeO+QMNGbtJFKsdB9ngGLkzykLCkBe5UNfSK8n7M8KjfuB7x3asw7AnPGlx2INyEIvF0KYoS+nAnOxxhV4z2dqdCZD275BkcBOM1T4DEVI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by PH7PR12MB6762.namprd12.prod.outlook.com (2603:10b6:510:1ac::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 12:27:05 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 12:27:05 +0000 Message-ID: Date: Tue, 18 Oct 2022 13:27:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v4 00/25] add the basic rte_flow offload support of nfp PMD Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1666092434-10357-1-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1666092434-10357-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0326.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::26) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|PH7PR12MB6762:EE_ X-MS-Office365-Filtering-Correlation-Id: cff1de74-6826-41db-d840-08dab1041152 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bz5zdMt0g1rXMnTOpN3PrJ6Rcn7vt2Or8Ffl+kfhHmB5WFtTQYUlrevcgrINzpgNqSWTF6CiJ8mYVKXkYDO7Q+YOgbjEDPs3N2eeKcyn1XtwvzKginaGXGIRRRZ1PwUCI3RcxUmk26wfeB9VQ8ahxmYyprmO4+WblIsEsV+jKTPvoxlTX73v9Ozxw2C/yVNKrNqwDGr1NTC6gbHGJyUz9HgozDDmQVrpnAyb6eUKyLAy1Z+6hDlAdwRw8VJGC8CDeVyWkUN1C01P6CPB2W7IAGu7aEc94L4XKdLx2yR4qTo42U8JU+O1KhTvp8O8256g7wLYioHt0BOtNMs5uB06eNPbN7BW40pCH0zkuEmCVYpZaG7Jp+W3jdaWYMpRFeVGXyzNOQsH3GC2ThTmIhzY2LkEjrAia6tBne+r26b/tNvp8FKlMewq/2qu4GHEGK9o2+JvF/3YkzfVID0PhoLp8KM5RIXAXU+ST0/kjYQimEfxptBRuI1D1nYNC8wQVQfhrVx4Xl26rkF4dtcoPe0QYIHZsaQmu+4K7qqKpfdkIsiZNlF+MM/UrJ+gGKy2BSuy4D+OSn/mIuNtOeR/Yn3u5WA/yU/0aXiW8SgMmEacmrM5nwsvhDOtuwNHZiYtzetcslq3iASPY0BsMBCuCl1vJhe4JPRzkbSnqezKHeiJanLf4+NiVwoLaK3FZmlYTA9BD7TyYM7OCfCkCoVuPtUyu4xh2zCMiG/JiIHGDba1fjHCVJR6bK/tHBws02gyGyCcvxIdtlg6mg6kWbaMaTSPK1/7KrJByExPaPurpujeYAvMZr5wKp+F1S/82eWMDHVr X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(136003)(366004)(396003)(39860400002)(346002)(451199015)(38100700002)(6486002)(966005)(31686004)(478600001)(2616005)(186003)(316002)(66556008)(66946007)(66476007)(4326008)(6666004)(8676002)(6506007)(36756003)(53546011)(26005)(41300700001)(6512007)(8936002)(86362001)(5660300002)(44832011)(31696002)(2906002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmQxWXNtVkhXNldDTkJrRGNQaVQyRXFHY2x6b1docmw5RUVXTTVZVFI1bStq?= =?utf-8?B?RllIS2Jrb3N2dHFIMFZFVDdIMWZKekNpdHBiTkpFMFJRNnpaNG5pRENiTnV5?= =?utf-8?B?Q2xzMkFXcUZVVWZOMnNVb0M3Vy80OEJ0YkdXRU9wZjBUWkJuTzk3N3VzTUMw?= =?utf-8?B?KytxejNiNitpOXlTUEpRdTlpbWFjSWloZGZoeDhlK1o4OVpxMVM3N2dHN2dS?= =?utf-8?B?S1FhMWZUK240NnFYcEF0Qnd3ekFLbnlkT0t0WUtOSWxxUUJMNzM4eXUvZ2xH?= =?utf-8?B?Ukdvc25OSVdGSk9KQTJHdmhZdk1vNDMzOHgwdFRVNTF2TEpZRnQwWEpWQWF3?= =?utf-8?B?RzJ4bUUyK09UUWhnd010NFNMVU1iZXZTL2Z4UUJudzdDbkRPVEF1dFJsZ0NJ?= =?utf-8?B?RERQN1VaY1U3YjZRa1RsZHhDbUpCc3hHRllZTVRVby9qbFRhTGNLNWprdEN4?= =?utf-8?B?ZVVaWm1xdUJ0ZE1oU0o5NUU0NzZxdHFEdVArcjVjbFpManlaalN4T3Z3WDRI?= =?utf-8?B?THRLODdNYTlUK3hSd2VxZCs3UUFOcjFwNmxHSkNmWVNMQTlDenVsODUzb0I1?= =?utf-8?B?YjNUQnpkYW5tanA0Z2E4bDJZR052NVltWHJ0K1U5WnF5RzUyNnU3OWw5UzlG?= =?utf-8?B?NjVNejEvb3BTRy8yUExuQkhzbnJkTUJnaEQ5aDB0ODRNd0FVYjVZMnZtOFAy?= =?utf-8?B?MEtTYkdzT1dKTnMwQjBjWGIwWm5XTDhQNGtjNXVoN01zSDJlZlF0T2ZMQm9D?= =?utf-8?B?cVRwZUtHUGdkczd2aVpuYTZLaGZPV2cza3Mzb2hTeWlhMEhxL213dFZ1dWtz?= =?utf-8?B?V05yTktlcEtQcjVUMkM5enJ1UEV4bGFhVmNqb2RkdkJUTHkvOXBja0daV2Vl?= =?utf-8?B?aEFWSjRxSDN0cVI4K3dnd3AydklJL2dQQ01HK1VXeHlkVnJ6alNEOVdkdmdl?= =?utf-8?B?UzZKNUNnTzhGVlNmUXhXNGFkejNuZjhsRHJGdFRPUW9ZQnF6a1RoQ2dPNHpJ?= =?utf-8?B?UnJtUzJMaytycDd5TThvajN4VzZnZEJ4aityQTh5ak0wMU9qWjVRQTBuMGgw?= =?utf-8?B?bFpjMXg1b3o5TFd4R3pnc2ZEUFZVV2ZxeGU5NXYrV01pL2xsczhXNFlVUTUz?= =?utf-8?B?eEM4M096ZXJkYWlFQkVFWU91Skl2QUZmaGxzK0dlSDhPR1JCR2tUWEhSMEFD?= =?utf-8?B?YStmNkwxcExjcytnb3pzOWRFeVhaQk5yaTNSbkF1ZUNRaDZnMGdvYk1nZ3Zn?= =?utf-8?B?QnZhQUFTUndid1NtaGl0QXEzSjcxWVQ5by9ZeHU0MzdhNTJLQWhlbXBtV0pu?= =?utf-8?B?SWxvaXpwRFVxWk1lL015dVhvZDlENnpzVkZmZ1VxakVJMkM1RVB0NWtlVzFF?= =?utf-8?B?SEhkS3B1S0JLblZibVErbkpSTDgxK3p2d0cvZitYR29CdmRBKzBuZmRuTDZn?= =?utf-8?B?YlRmcDU2YkdpWnMxZHUvZlltanI4SnYwNlpFdVV1aE1JLy9lamFOa2ZTWDNR?= =?utf-8?B?M2ZUQWtkMDhKTzJaRmtWSnhwTFhjaVNGaUV6aHVjcTlOSmhwWXNiNCtKQUdS?= =?utf-8?B?Y0JNVUJ1RWhzVGpuMzFvS0ZLWDl6N2xURjZPMjdrZzFHdjJUc1RTYTIzR2xp?= =?utf-8?B?VjV3bG1TUjhRMjNCUHducmNGVFZJZkdrMVBoaEJqdXFHZEpxOXBjTk13T1Vh?= =?utf-8?B?Unh2emVxZVhHVTBXQ1VoSkdzdWM1Tk11a3hWUGRONTA5OE5Fek5penIzRzNk?= =?utf-8?B?RDk1Nll0eTBmbUxRUkVLN1dxR1JZRkhJN2t1aThpVkZwQWY3OTFiOFFpbXlF?= =?utf-8?B?cy9HcTZweUlqak1rbnBacXE5N2J3d01rWTNhZnNBUDBZQi9Mem4xVDdQcU51?= =?utf-8?B?TlMxa09nS2FJeXBPZzJxNkdXd3lzeFd5L2czN3kwdkhjMjhGRHFpMHZMMVUz?= =?utf-8?B?VmxjSTJxc0hCQmQ1ZmhrVHoxVFZscGw3ZDRIMWR2UHNidXd5U28zK3djQjAy?= =?utf-8?B?ZExpejBQdk92SDFzRXZTQndoZzBXclBKdE9iRzBRV0pqRy83VFRFVENkUXdq?= =?utf-8?B?VGpGUUY1UkxXTzZFaFI2QlZuYmdpam1QOVhZbmNXcEljSkVVS0ZLVHZoYmpL?= =?utf-8?Q?8HY46uzMS+gmBQeK0/io2JfZz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cff1de74-6826-41db-d840-08dab1041152 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 12:27:05.7318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E1rp6UlviAMol1DcNZra0GiLdhmxagyaeDYxUB5LC8gvrHg4mMOTfpGYxNGknS+S X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6762 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/18/2022 12:26 PM, Chaoyong He wrote: > This is the second patch series to add the support of rte_flow offload for > nfp PMD, includes: > Implement the rte_flow related API > Implement the offload framework of nfp card > Add the offload support of common rte_flow pattern items > Add the offload support of common rte_flow actions > > * Changes since v2 > - Change the release note. > - Change the headline of commit message. > - Adjust the order of commits to prevent the memory problem. > > * Changes since v2 > - Fix one problem import by the first patch series > > * Changes since v1 > - Add the 'Depends-on' tag > > Chaoyong He (25): > net/nfp: fix the requirement of cpp bridge service > net/nfp: add the structures and functions for flow offload > net/nfp: add the stats process logic in ctrl VNIC service > net/nfp: add the flow APIs of nfp PMD > net/nfp: support basic flow items > net/nfp: support basic flow actions > net/nfp: support VLAN flow item > net/nfp: support IPv4 flow item > net/nfp: support IPv6 flow item > net/nfp: support TCP flow item > net/nfp: support UDP flow item > net/nfp: support SCTP flow item > net/nfp: support SRC MAC flow action > net/nfp: support DST MAC flow action > net/nfp: support pop VLAN flow action > net/nfp: support push VLAN flow action > net/nfp: support SRC IPv4 flow action > net/nfp: support DST IPv4 flow action > net/nfp: support SRC IPv6 flow action > net/nfp: support DST IPv6 flow action > net/nfp: support TP SRC flow action > net/nfp: support TP DST flow action > net/nfp: support TTL flow action > net/nfp: support IPv4 DSCP flow action > net/nfp: support IPv6 DSCP flow action > Hi Chaoyong, It seems comment to first patch (v2 1/24) applied and rest ignored again. Please check all comments [1]. Also there are some questions, can you please response to them? And when you send new version can you please use '--in-reply-to' and reply to previous version to keep all versions in same email thread, otherwise it is too hard to find previous versions and comments to previous versions. More details can be found in the documentation: https://doc.dpdk.org/guides/contributing/patches.html#sending-patches [1] https://inbox.dpdk.org/dev/1665382142-21684-1-git-send-email-chaoyong.he@corigine.com/