From: "Ding, Xuan" <xuan.ding@intel.com>
To: "Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring
Date: Wed, 5 Feb 2020 03:07:44 +0000 [thread overview]
Message-ID: <e5a48562a7194f6ab2267207ea35db3c@intel.com> (raw)
In-Reply-To: <20200205021108.370141-1-tiwei.bie@intel.com>
Hi Tiwei,
Corrected on my local, thank you for your fix in advance.
Regards,
Xuan Ding
> -----Original Message-----
> From: Bie, Tiwei <tiwei.bie@intel.com>
> Sent: Wednesday, February 5, 2020 10:11 AM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Wang, Zhihong
> <zhihong.wang@intel.com>
> Cc: Ding, Xuan <xuan.ding@intel.com>
> Subject: [PATCH] net/virtio-user: do not reset virtqueues for split ring
>
> Add missing braces to avoid resetting virtqueues unconditionally during
> reconnection.
>
> Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode")
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> Cc: Xuan Ding <xuan.ding@intel.com>
>
> drivers/net/virtio/virtio_user_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user_ethdev.c
> b/drivers/net/virtio/virtio_user_ethdev.c
> index f3b35d1bd..e61af4068 100644
> --- a/drivers/net/virtio/virtio_user_ethdev.c
> +++ b/drivers/net/virtio/virtio_user_ethdev.c
> @@ -89,10 +89,11 @@ virtio_user_server_reconnect(struct virtio_user_dev
> *dev)
> dev->features &= dev->device_features;
>
> /* For packed ring, resetting queues is required in reconnection. */
> - if (vtpci_packed_queue(hw))
> + if (vtpci_packed_queue(hw)) {
> PMD_INIT_LOG(NOTICE, "Packets on the fly will be dropped"
> " when packed ring reconnecting.");
> virtio_user_reset_queues_packed(eth_dev);
> + }
>
> ret = virtio_user_start_device(dev);
> if (ret < 0)
> --
> 2.24.1
next prev parent reply other threads:[~2020-02-05 3:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 2:11 Tiwei Bie
2020-02-05 3:07 ` Ding, Xuan [this message]
2020-02-05 7:52 ` Maxime Coquelin
2020-02-05 9:45 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5a48562a7194f6ab2267207ea35db3c@intel.com \
--to=xuan.ding@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).