From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7117AA0539; Wed, 5 Feb 2020 04:07:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B05D11C1ED; Wed, 5 Feb 2020 04:07:50 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2E4651C1AC for ; Wed, 5 Feb 2020 04:07:48 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 19:07:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,404,1574150400"; d="scan'208";a="430024902" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 04 Feb 2020 19:07:47 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 19:07:46 -0800 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 5 Feb 2020 11:07:44 +0800 Received: from shsmsx605.ccr.corp.intel.com ([10.109.6.215]) by SHSMSX605.ccr.corp.intel.com ([10.109.6.215]) with mapi id 15.01.1713.004; Wed, 5 Feb 2020 11:07:44 +0800 From: "Ding, Xuan" To: "Bie, Tiwei" , "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "Wang, Zhihong" Thread-Topic: [PATCH] net/virtio-user: do not reset virtqueues for split ring Thread-Index: AQHV28mh3OFz6skVaUO7P992FiS0aqgL6kLg Date: Wed, 5 Feb 2020 03:07:44 +0000 Message-ID: References: <20200205021108.370141-1-tiwei.bie@intel.com> In-Reply-To: <20200205021108.370141-1-tiwei.bie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tiwei, Corrected on my local, thank you for your fix in advance. Regards, Xuan Ding > -----Original Message----- > From: Bie, Tiwei > Sent: Wednesday, February 5, 2020 10:11 AM > To: dev@dpdk.org; maxime.coquelin@redhat.com; Wang, Zhihong > > Cc: Ding, Xuan > Subject: [PATCH] net/virtio-user: do not reset virtqueues for split ring >=20 > Add missing braces to avoid resetting virtqueues unconditionally during > reconnection. >=20 > Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode") >=20 > Signed-off-by: Tiwei Bie > --- > Cc: Xuan Ding >=20 > drivers/net/virtio/virtio_user_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/virtio/virtio_user_ethdev.c > b/drivers/net/virtio/virtio_user_ethdev.c > index f3b35d1bd..e61af4068 100644 > --- a/drivers/net/virtio/virtio_user_ethdev.c > +++ b/drivers/net/virtio/virtio_user_ethdev.c > @@ -89,10 +89,11 @@ virtio_user_server_reconnect(struct virtio_user_dev > *dev) > dev->features &=3D dev->device_features; >=20 > /* For packed ring, resetting queues is required in reconnection. */ > - if (vtpci_packed_queue(hw)) > + if (vtpci_packed_queue(hw)) { > PMD_INIT_LOG(NOTICE, "Packets on the fly will be dropped" > " when packed ring reconnecting."); > virtio_user_reset_queues_packed(eth_dev); > + } >=20 > ret =3D virtio_user_start_device(dev); > if (ret < 0) > -- > 2.24.1