From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8BE755F2A; Wed, 27 Mar 2019 11:29:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5E33C063D04; Wed, 27 Mar 2019 10:29:51 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58B3D60C18; Wed, 27 Mar 2019 10:29:50 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stephen@networkplumber.org, stable@dpdk.org References: <20190325041215.30266-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 27 Mar 2019 11:29:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325041215.30266-1-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 27 Mar 2019 10:29:51 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 10:29:52 -0000 On 3/25/19 5:12 AM, Tiwei Bie wrote: > This patch fixes the multi-process support for virtio-user. > Currently virtio-user just provides some limited secondary > process supports. Only some basic operations can be done in > secondary process on virtio-user port, e.g. getting port stats. > Actions which will trigger the communication with vhost backend > can't be done in secondary process for now, as the fds are > not synced between processes. The processing of server mode > devargs is also moved into virtio_user_dev_init(). > > Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 15 +++++ > drivers/net/virtio/virtio_ethdev.h | 2 + > .../net/virtio/virtio_user/virtio_user_dev.c | 3 +- > .../net/virtio/virtio_user/virtio_user_dev.h | 3 +- > drivers/net/virtio/virtio_user_ethdev.c | 61 +++++++++++-------- > 5 files changed, 56 insertions(+), 28 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A37ECA05D3 for ; Wed, 27 Mar 2019 11:29:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 793FF7D52; Wed, 27 Mar 2019 11:29:53 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8BE755F2A; Wed, 27 Mar 2019 11:29:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D5E33C063D04; Wed, 27 Mar 2019 10:29:51 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58B3D60C18; Wed, 27 Mar 2019 10:29:50 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stephen@networkplumber.org, stable@dpdk.org References: <20190325041215.30266-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Wed, 27 Mar 2019 11:29:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325041215.30266-1-tiwei.bie@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 27 Mar 2019 10:29:51 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] net/virtio-user: fix multi-process support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327102948.-pLRr5B_kcxoBK1c6Q0GHH776YUa7ytJwpYI4pynQdU@z> On 3/25/19 5:12 AM, Tiwei Bie wrote: > This patch fixes the multi-process support for virtio-user. > Currently virtio-user just provides some limited secondary > process supports. Only some basic operations can be done in > secondary process on virtio-user port, e.g. getting port stats. > Actions which will trigger the communication with vhost backend > can't be done in secondary process for now, as the fds are > not synced between processes. The processing of server mode > devargs is also moved into virtio_user_dev_init(). > > Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") > Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 15 +++++ > drivers/net/virtio/virtio_ethdev.h | 2 + > .../net/virtio/virtio_user/virtio_user_dev.c | 3 +- > .../net/virtio/virtio_user/virtio_user_dev.h | 3 +- > drivers/net/virtio/virtio_user_ethdev.c | 61 +++++++++++-------- > 5 files changed, 56 insertions(+), 28 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime