From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9999A0A02; Thu, 14 Jan 2021 11:23:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9449C1410B5; Thu, 14 Jan 2021 11:23:22 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 026801410B4 for ; Thu, 14 Jan 2021 11:23:20 +0100 (CET) IronPort-SDR: L8KWh6Ja1W9bCoLvAgg7gY4cuh+t6DHoWojemZ78VnSLJp6Ak9BsTvRAH/yJlXRot9S7Qlnry2 0n8c3Dnkme1Q== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="165430928" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="165430928" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 02:23:19 -0800 IronPort-SDR: EDcXjRu7zl6Atag3TnLBk+jIlaKntv7zGeQ3aucc2uW1qXsY06NM6VKfpVUZ699K9MzIeHx0V2 VwgnUw+S5LUw== X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="465208975" Received: from spuligad-mobl2.ger.corp.intel.com (HELO [10.213.255.126]) ([10.213.255.126]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 02:23:16 -0800 To: "Ananyev, Konstantin" , "dev@dpdk.org" Cc: "McDaniel, Timothy" , Jerin Jacob , Ruifeng Wang , Jan Viktorin , David Christensen , "Richardson, Bruce" , "thomas@monjalon.net" , "Hunt, David" , "Macnamara, Chris" References: <0eee7584-7b3c-303a-e3a1-222eeaa0e322@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 14 Jan 2021 10:23:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v16 03/11] eal: change API of power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 13-Jan-21 6:01 PM, Ananyev, Konstantin wrote: > >> On 13-Jan-21 1:01 PM, Ananyev, Konstantin wrote: >>> >>>> >>>> Instead of passing around pointers and integers, collect everything >>>> into struct. This makes API design around these intrinsics much easier. >>>> >>>> Signed-off-by: Anatoly Burakov >>>> Acked-by: Konstantin Ananyev >>>> --- >>>> >>>> Notes: >>>> v16: >>>> - Add error handling >>> >>> There are few trivial checkpatch warnings, please check >>> >> >> To paraphrase Nick Fury, I recognize that checkpatch has produced >> warnings, but given that i don't agree with what checkpatch has to say >> in this case, I've elected to ignore it :) >> >> In particular, these warnings related to comments around struct members, >> which i think i've made to look nice and also took care of correct >> indentation in terms of code looking the same way with different tab >> widths. So, i don't think it should be changed, unless you're suggesting >> to re-layout comments on top of each member, rather than at the side >> (which i think is more readable). > > If top is not an option, it is possible to move comment on next after actual field lines: > uint32_t x; > /**< > * blah, blah > * blah, blah, blah > */ > AFAIK that would keep checkpatch happy. > It's not as much "not an option" as it would look less readable to me than what there currently is. If we're going to keep comments not on the side, then on the top they go. I'd prefer to keep it as is, but if you feel strongly about it, i can change it. -- Thanks, Anatoly