From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Lance Richardson <h.lance.richardson@gmail.com>
Cc: Lance Richardson <lance.richardson@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: limit per-poll Rx representor pkts
Date: Thu, 7 Jan 2021 15:33:29 +0000 [thread overview]
Message-ID: <e5dee933-65d4-614e-e208-cfdc57451dd5@intel.com> (raw)
In-Reply-To: <CAH5C7_1Q01uVaEEVaDD9APDtOnspN0tYUGDuQG2g397iJ1vOfg@mail.gmail.com>
On 1/6/2021 8:54 PM, Lance Richardson wrote:
> On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/14/2020 6:53 PM, Lance Richardson wrote:
>>> Limit number of representor packets transferred per poll
>>> to requested burst size.
>>>
>>
>> Hi Lance,
>>
>> Can you please describe the impact of the change? Since it has a fixes line, it
>> seems it is fixing something but it is not clear what is fixed.
>>
> Hi Ferruh,
>
> How does this look:
>
> Without some limit on the number of packets transferred from the
> hw ring to the representor ring per burst receive call, an entire ring's
> worth of packets can be transferred. This can break assumptions
> about ring indices (index on return could be identical to the index
> on entry, which is assumed to mean that no packets were processed),
> and can result in representor packets being dropped unnecessarily
> due to representor ring overflow.
>
> Fix by limiting the number of representor packets transferred per
> poll to requested burst size.
>
Thank you, updated the commit log in next-net.
prev parent reply other threads:[~2021-01-07 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 18:53 Lance Richardson
2020-12-17 23:54 ` Ajit Khaparde
2021-01-06 9:27 ` Ferruh Yigit
2021-01-06 20:54 ` Lance Richardson
2021-01-07 15:33 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5dee933-65d4-614e-e208-cfdc57451dd5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=h.lance.richardson@gmail.com \
--cc=lance.richardson@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=venkatkumar.duvvuru@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).