Re: [PATCH] net/mlx5: fix decreasing the reference count of a Tx queue

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,


On 03/07/2025 6:02 PM, Bing Zhao wrote:
> When changing the order of the Tx queues startup, the depth of the
> queue is compared. If not equal to the current big log2 value, next
> queue will be checked and the current one will be skipped for the
> next iteration.
> 
> The mlx5_txq_get() will increase the reference count number, and the
> size check no match is not an error and the startup will continue but
> not fall into the error roll-back label. The reference count should
> be decreased by 1 to dereference the count, or else in the device
> close stage, the queue cannot be released in the FW and the TIS, PD
> will be leaked as well.
> 
> By calling the mlx5_txq_release() before continue will recover the
> reference count to the initial state and solve the leak.
> 
> Fixes: 6f356d3840e6 ("net/mlx5: pass DevX object info in Tx queue start")
> 
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh