From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99F1745A1C; Tue, 24 Sep 2024 10:02:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60DD440295; Tue, 24 Sep 2024 10:02:29 +0200 (CEST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by mails.dpdk.org (Postfix) with ESMTP id 6B0914028E for ; Tue, 24 Sep 2024 10:02:28 +0200 (CEST) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c241feb80dso11933005a12.0 for ; Tue, 24 Sep 2024 01:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1727164948; x=1727769748; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kdlOo8MGZemykR97zI0j6J89ma8ecSJt/IV4oTp6U20=; b=UPb/mylckW+9w6nMEa+TEzeHm2Ytg83YSI+c+sZCwYy/mfWDe+eNlSZMcJyzOSJEk4 aLWY0MyzclzbNZFphlQuD4tH8Pm0C9I2DtuP4uD3LiDwkpuAfDaFjGopprkeNlhpMerM fTenpYedSHcc7cp6LUQTd+Kwim7Ox6AQXr3awlTrzHDlOQgIrgfiKDV0Ak+WqmnPuF9C TvgfbAde7ni23lO1a2RLgdclsPliJW50UuRQgLf7JCksPcdDRL1k+T1w8kZ1+w/JrjIc c+MHMhWoEIChehV+lz/YsQqjy0AIDZExs8tY0+MoSpBkPBjSfwVhXm9tq0E/9O0se9aI 3DEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727164948; x=1727769748; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kdlOo8MGZemykR97zI0j6J89ma8ecSJt/IV4oTp6U20=; b=f3uD0yMy7A/LOy1oYTnwWM+mjMrOhZ7WqyR5GG8NOhP/R66CFicalBsYFD+K1f77It DZfHI1mJrW8uoZgFRBEm841tM9Wvsk7rImVRok5fUvVtHZxi3qh8g7mRHEcuxPZmg5mS MjiPh9OkJjOneNRm6pH+WCZhWqGljfpcG/3b91bqIl9cHohrhXt+KYZJHCPNv75fczkM sCwLHjJk6q9rdIp38vKP694e2m31wn3reuS7/pT5r/q18QODg0x0B3MivgGu8g11rJsk IFPeNVssmLpD4YgQFKnFadqI41wM0ySZO7nqS8kYo7kLfHKylqdTb+wjc2ryv60+sK80 S9bQ== X-Forwarded-Encrypted: i=1; AJvYcCUKCsnkzZ6UKBuSOtZQd0puNWeqGH15n4BcEH+CVgoPdSw/bekRhCACUWrGnMxSl2+//FQ=@dpdk.org X-Gm-Message-State: AOJu0YwUBhwkZAiyOlLb9PalFncpigXILagTPoN2liu1kmcfDsso/Ox2 dJDr06teHBs5biRZ2ooGYrssUVCCgHazZG2z1SUMoy93qVvzICfGwqQDzMwRKx4= X-Google-Smtp-Source: AGHT+IHQQfsUkjm1o/+Cpg5MTKaz7xmrMt7CyDlhFBLh5GPYJGxUKKxsQKsvczC3mGBP2sGqRkZAPg== X-Received: by 2002:a17:907:7b8e:b0:a6f:996f:23ea with SMTP id a640c23a62f3a-a92c4870d58mr271463566b.15.1727164947953; Tue, 24 Sep 2024 01:02:27 -0700 (PDT) Received: from [10.12.0.236] (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9393138b68sm51906866b.222.2024.09.24.01.02.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 01:02:27 -0700 (PDT) Message-ID: Date: Tue, 24 Sep 2024 10:02:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/11] dts: add NIC capability support To: Jeremy Spewock Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, alex.chapman@arm.com, probb@iol.unh.edu, npratte@iol.unh.edu, dmarx@iol.unh.edu, dev@dpdk.org References: <20240301155416.96960-1-juraj.linkes@pantheon.tech> <20240923150210.57269-1-juraj.linkes@pantheon.tech> <20240923150210.57269-6-juraj.linkes@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 23. 9. 2024 21:26, Jeremy Spewock wrote: > On Mon, Sep 23, 2024 at 11:02 AM Juraj Linkeš > wrote: >> >> Some test cases or suites may be testing a NIC feature that is not >> supported on all NICs, so add support for marking test cases or suites >> as requiring NIC capabilities. >> >> The marking is done with a decorator, which populates the internal >> required_capabilities attribute of TestProtocol. The NIC capability >> itself is a wrapper around the NicCapability defined in testpmd_shell. >> The reason is Enums cannot be extended and the class implements the >> methods of its abstract base superclass. >> >> The decorator API is designed to be simple to use. The arguments passed >> to it are all from the testpmd shell. Everything else (even the actual >> capability object creation) is done internally. >> >> Signed-off-by: Juraj Linkeš >> Reviewed-by: Dean Marx > > Thank you for addressing all my comments! Thanks you for giving them. Very helpful. > Reviewed-by: Jeremy Spewock