From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3224A04B1; Mon, 23 Nov 2020 17:09:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D1DF6C8E6; Mon, 23 Nov 2020 17:09:41 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 88F37160 for ; Mon, 23 Nov 2020 17:09:38 +0100 (CET) IronPort-SDR: vuIMS9fStvQDbf04EOFKfK7TvWwX0RlFaM1ln26FmSrEYFEOjA0jaQbUVL7KLHzlk66HRhziXN pDt8ln9FeyoQ== X-IronPort-AV: E=McAfee;i="6000,8403,9813"; a="151634426" X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="151634426" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 08:09:34 -0800 IronPort-SDR: hqAq1o7TGvLS+UpIQc90zj9oavSvSHE/4+hu3w4nzgtXCjPi7LqrbsocoGGrCpxcoJGQPIJAsq AEBTbzD03x4g== X-IronPort-AV: E=Sophos;i="5.78,363,1599548400"; d="scan'208";a="327245809" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.20.15]) ([10.252.20.15]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2020 08:09:24 -0800 To: Guoyang Zhou , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko Cc: bluca@debian.org, cloud.wangxiaoyun@huawei.com, luoxianjun@huawei.com, yin.yinshi@huawei.com, luojiachen@huawei.com, chenlizhong@huawei.com, zhaohui8@huawei.com, chenchanghu@huawei.com References: From: Ferruh Yigit Message-ID: Date: Mon, 23 Nov 2020 16:09:21 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 0/2] remove some limitations and operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/23/2020 1:12 PM, Guoyang Zhou wrote: > The maximum number of queues on the chip can be any value greater > than 0, it does not have to be the power of two, and remove the > operation of optical modules in the link function. > > -- > v1: > - remove the limitation for max queue num > - remove the operation of optical modules in the link function > > Guoyang Zhou (2): > net/hinic/base: remove the limitation for max queue num > net/hinic: remove the operation of optical modules > Hi Guoyang, How critical is this set, can you please describe the impact of the fixes? If they are not critical, let's postpone them to next release, since the release is a few days away. btw, both patches has [1] as a fixed patch, but that patch looks unrelated with both, that patch only cleans up the uninit/destroy path. Can you please elaborate why that patch is fixed? As far as I can see the condition removed in first patch introduced in v19.08 ([2]) and the calls in second patch added in v19.11 ([3]). [1] Fixes: 511b7371d32b ("net/hinic: fix hugepage memory leaks") [2] Fixes: 828d3e15a9dc ("net/hinic/base: support context and work queue") [3] Fixes: 54ac33869932 ("net/hinic: set link down and up")