DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, stephen@networkplumber.org,
	Gagandeep Singh <g.singh@nxp.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Nipun Gupta <nipun.gupta@amd.com>,
	Nikhil Agarwal <nikhil.agarwal@amd.com>,
	Sachin Saxena <sachin.saxena@nxp.com>,
	Anoob Joseph <anoobj@marvell.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Abdullah Sevincer <abdullah.sevincer@intel.com>,
	Igor Russkikh <irusskikh@marvell.com>,
	Steven Webster <steven.webster@windriver.com>,
	Matt Peters <matt.peters@windriver.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	Apeksha Gupta <apeksha.gupta@nxp.com>,
	Junfeng Guo <junfeng.guo@intel.com>,
	Simei Su <simei.su@intel.com>, Long Li <longli@microsoft.com>,
	Vamsi Attunuru <vattunuru@marvell.com>,
	Harman Kalra <hkalra@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>,
	Alok Prasad <palok@marvell.com>, Chenbo Xia <chenbox@nvidia.com>,
	Jochen Behrens <jbehrens@vmware.com>,
	Rosen Xu <rosen.xu@intel.com>,
	Tianfei Zhang <tianfei.zhang@intel.com>,
	Xiao Wang <xiao.w.wang@intel.com>
Subject: Re: [PATCH] drivers: use dedicated logtypes
Date: Fri, 12 Jan 2024 14:53:32 +0100	[thread overview]
Message-ID: <e617f257-e4cb-4ac6-8c82-d5139ae3c761@redhat.com> (raw)
In-Reply-To: <20231218135932.1497163-1-david.marchand@redhat.com>



On 12/18/23 14:59, David Marchand wrote:
> diff --git a/drivers/net/virtio/virtio_logs.h b/drivers/net/virtio/virtio_logs.h
> index 9b1b1defc5..01911514bd 100644
> --- a/drivers/net/virtio/virtio_logs.h
> +++ b/drivers/net/virtio/virtio_logs.h
> @@ -16,19 +16,20 @@ extern int virtio_logtype_init;
>   
>   #ifdef RTE_LIBRTE_VIRTIO_DEBUG_RX
>   #define PMD_RX_LOG(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args)
> +	RTE_LOG(level, VIRTIO_DRIVER, "%s() rx: " fmt "\n", __func__, ## args)
>   #else
>   #define PMD_RX_LOG(level, fmt, args...) do { } while(0)
>   #endif
>   
>   #ifdef RTE_LIBRTE_VIRTIO_DEBUG_TX
>   #define PMD_TX_LOG(level, fmt, args...) \
> -	RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args)
> +	RTE_LOG(level, VIRTIO_DRIVER, "%s() tx: " fmt "\n", __func__, ## args)
>   #else
>   #define PMD_TX_LOG(level, fmt, args...) do { } while(0)
>   #endif
>   
>   extern int virtio_logtype_driver;
> +#define RTE_LOGTYPE_VIRTIO_DRIVER virtio_logtype_driver
>   #define PMD_DRV_LOG(level, fmt, args...) \
>   	rte_log(RTE_LOG_ ## level, virtio_logtype_driver, \
>   		"%s(): " fmt "\n", __func__, ## args)

For Virtio part:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2024-01-12 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 13:59 David Marchand
2023-12-18 17:14 ` Stephen Hemminger
2024-01-12 13:53 ` Maxime Coquelin [this message]
2024-02-01  9:35 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e617f257-e4cb-4ac6-8c82-d5139ae3c761@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=abdullah.sevincer@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anoobj@marvell.com \
    --cc=apeksha.gupta@nxp.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=chenbox@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dsinghrawat@marvell.com \
    --cc=g.singh@nxp.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=irusskikh@marvell.com \
    --cc=jbehrens@vmware.com \
    --cc=jingjing.wu@intel.com \
    --cc=junfeng.guo@intel.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=longli@microsoft.com \
    --cc=matt.peters@windriver.com \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    --cc=palok@marvell.com \
    --cc=rosen.xu@intel.com \
    --cc=ruifeng.wang@arm.com \
    --cc=sachin.saxena@nxp.com \
    --cc=simei.su@intel.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=stephen@networkplumber.org \
    --cc=steven.webster@windriver.com \
    --cc=thomas@monjalon.net \
    --cc=tianfei.zhang@intel.com \
    --cc=vattunuru@marvell.com \
    --cc=xiao.w.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).