From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5966A04DF; Tue, 11 Aug 2020 19:51:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB5941C025; Tue, 11 Aug 2020 19:51:50 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id F2C6E1C022 for ; Tue, 11 Aug 2020 19:51:49 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200811175149euoutp02afb8db8393a7d387e60fe2f4b890558d~qSB1qGhLd2439224392euoutp02P; Tue, 11 Aug 2020 17:51:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200811175149euoutp02afb8db8393a7d387e60fe2f4b890558d~qSB1qGhLd2439224392euoutp02P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1597168309; bh=s+fsP+DsWXJDomRQyjfj5CKa6RBmXaNSKOAt6Cby9qM=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=JG6A9xZMTtVB8W1BKAYt2QqBC14NI1QAe/5OVLDU9/dQVUmFjQU48ozdoSaD1gGvM SsPpbgbDSbvtw2xWuBhir/9CU5RzDYafcnvXKHpPimOE1rZWhElfP5wPh37u825MYK KI4nS/mDoc6/RKcEFdO776Rgp9QpZk92gyLA91Z8= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200811175148eucas1p222f1534bcde49a4ffe16934c1b63d4ae~qSB06ZaTN1461714617eucas1p2N; Tue, 11 Aug 2020 17:51:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id BF.C2.06318.4BAD23F5; Tue, 11 Aug 2020 18:51:48 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200811175147eucas1p137a6a1eb136cb64621fbb50cb18a8f6d~qSB0O9vpY2856728567eucas1p1m; Tue, 11 Aug 2020 17:51:47 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200811175147eusmtrp1bcff192f2636d45431cc020f2461ac56~qSB0IPChl0974509745eusmtrp1N; Tue, 11 Aug 2020 17:51:47 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-9e-5f32dab4b66e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id C6.4A.06314.3BAD23F5; Tue, 11 Aug 2020 18:51:47 +0100 (BST) Received: from [106.109.129.29] (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200811175145eusmtip2d194a1fcdb822c0ab69069c8ccc6a674~qSByGtqJg0088500885eusmtip2y; Tue, 11 Aug 2020 17:51:45 +0000 (GMT) To: Stephen Hemminger Cc: dev@dpdk.org, v.kuramshin@samsung.com, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@intel.com, arybchenko@solarflare.com, wei.zhao1@intel.com, jia.guo@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, wenzhuo.lu@intel.com, mb@smartsharesystems.com, nicolas.chautru@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, radu.nicolau@intel.com, akhil.goyal@nxp.com, declan.doherty@intel.com, skori@marvell.com, pbhagavatula@marvell.com, jerinj@marvell.com, kirankumark@marvell.com, david.hunt@intel.com, anatoly.burakov@intel.com, xiaoyun.li@intel.com, jingjing.wu@intel.com, john.mcnamara@intel.com, jasvinder.singh@intel.com, byron.marohn@intel.com, yipeng1.wang@intel.com From: Ivan Dyukov Message-ID: Date: Tue, 11 Aug 2020 20:51:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200811084711.62f06560@hermes.lan> Content-Transfer-Encoding: 8bit Content-Language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0yTZxTGfb97Gysv1YUTN91sNM5lihSXnC2LTqPZp/zjMk0WMwfd+AJG qKQVpkuWACqDiuXmvBTFAjO4zskm5TIGKF1mwdohLGSwOUUkdioFxLkIop3lq5H/fs9zznnP eZJXYvUXhPnSDvNuxWI2pRkELddwaaJruftPY+LKAyclrL1SQXDwejWLA4f/FvDg2H4G+1xr sKXxBI+lN7IZtJfeZ7DxjE3A4YFcDkfGGxm81uoTcdwTEPFQVznBwNRdFo87HxDsqqjncaK9 WcDRqSoO7ZO9BIvcHQS9hfc5PPxTE8E8G8Wxb2tErL62EMcHOjj09deJePZhN4v1V54QLPHW EvTnhfj3XpMnnad5ubrlDiOXVXaz8qX+I6Jc2FnByD+ONDHyaFuvINvdLiJfHjzIyt8NPRI2 a7dp301W0nZkKZbY1Una1GBBO5NxW7snmF1Gssk9yUY0EtBVsL/gHGsjWklPzxB4HKrkVPEv gZK8v4gqHhAIDjeQ5yM3f8gR1UINgfK2sYgYJeD7L1cMd82lCXD1j1/4MM+jRnAF8qefYmmI h18PDAnhgkBfB19+BWMjkqSjq6HFbw7bHF0C4zkTbJhfoh9BqPQWF2YdjYbO40PTrKFxMFQS mmaWvgr76stZlWNgrLFdCO8C+pUGmi9/I6hnr4dj9nOiynPhrtcd4VfAV1bIRQaehW6oE1VR TGBfeTDStQbc934Tw5eydBnUNseq9lo4G3BNBwA6B/qC0eoRc6C04Sir2jrIz9Or3Qa42NkT sQGePJ5dTAyOGckcM9I4ZqRxvFjrJJyLxCiZ1vQUxRpvVj5fYTWlWzPNKSs+25V+njz71r6n 3odNpG3qUw+hEjHM1jlLjIl63pRl3ZvuISCxhnm6dX7fJ3pdsmnvF4plV6IlM02xesjLEmeI 0cVX3dmupymm3cpORclQLM+rjKSZn02yAkJP8eZbs3yanRvFU+5VSY+eJnx4M+pYXfT2N01f 1yzY0PrzW2/nFFRBv/G00W/Z8PHtd2pGEoaLfl9yfc/WTUndgS19oY6lrT0ObxJfaf9ycV9a 3FaP/H7lykF++IQTbVELPlh04/vlRalHcv+5urg11jixZXJh8rpFRVF+Od7SXmDgrKmmuDdY i9X0Pw/OhbDSAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUzMcRzHfX9P96u57eeq+cpGbrOZh+N3PX0yYmz2w2yMP8xDuemnmu6u 3e/OhFnJyKFcNdaxW4SoPFYu5OFCqatROA8jlx0NPfmJKZHOsfXfa5/35/X57LN9WFL1mA5n Uw1m0WTQpamZYMr9u6F9VuUrbeKconYVXGp2IHjXXkKCt/ANAwf79hLwomwB1DpP0JD/NpOA 3PwvBDjPWRno8u6hoEd2EvD6llsBcl2nAg4/Oo6gc+gTCUXFXxE8clTTMOC6wUDv0CkKcgef Icireoig4dAXCgqv1yDYZ+Wg73ypAkpeTwLZ+5AC98tKBVR8ayWhuvkXAlvDJQQt+4bphRHC YPEZWiip/UgIBSdbSaH+5VGFcKjRQQhXemoIoff2M0bIrSpDQtO7g6RQ7vvBrAxep5lnMlrM YkSKUTLPV6/nQavh40CjjYrT8JGxG+dqo9Wz4+cliWmp20TT7PhNmpTuAy4i/UPw9u7MApSJ PrNWFMRiLgp3XM5SWFEwq+LOIHys3kNaETsSYPzZRwZ6QvCQx8oEeroR/nDxI+0PQrjl+PHz e385lNPiss4c5GeSG6bx09PjAkIhgT2tXsIfMNw07M5xEP4FSi4e17YY/GWKm4rlrIG/y8K4 tfir6z7jZyU3DjcW+Sg/B3E89tmGqcD8GOyo7CADPBlnVx//x+Nxn9PFHEEq+yjdPkqxj1Ls o5RiRJWhUNEi6ZP1Eq+RdHrJYkjWbDbqr6KRb7pWP1BZg9qurK5DHIvUY5XFNm2iitZtkzL0 dQizpDpUuajFnaBSJukydogmY6LJkiZKdSh65DgbGR622TjymwZzIh/Nx0IcHxsZGxkD6vHK HM61QcUl68ziVlFMF03/PYINCs9Ehp+31shP0pQ3292bJvSGT4isyGsp3V3YtCz1QVjCi4UD eRFvZv5YIU+tXvFrdf7ZLN8Jy/f9D24WHM5etfRCf8nvmhB5TMKasUsiPHJCz67FXeUemsyO bpso39XYnbPm6rT9O3uaYqb0JzV6977nphd05k3+XjVYu6Brj22m6k7plhlqSkrR8dNJk6T7 AznnSq1jAwAA X-CMS-MailID: 20200811175147eucas1p137a6a1eb136cb64621fbb50cb18a8f6d X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200811085304eucas1p150bf23b6f183a28fbceca06b0bced5af X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200811085304eucas1p150bf23b6f183a28fbceca06b0bced5af References: <20200427095737.11082-1-i.dyukov@samsung.com> <20200811085246.28735-1-i.dyukov@samsung.com> <20200811085246.28735-3-i.dyukov@samsung.com> <20200811084711.62f06560@hermes.lan> Subject: Re: [dpdk-dev] [PATCH v9 02/24] ethdev: add a link status text representation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11.08.2020 18:47, Stephen Hemminger пишет: > On Tue, 11 Aug 2020 11:52:21 +0300 > Ivan Dyukov wrote: > >> Link status structure keeps complicated values which are hard to >> represent to end user. e.g. link_speed has INT_MAX value which >> means that speed is unknown, link_duplex equal to 0 means >> 'half-duplex' etc. To simplify processing of the values >> in application, new dpdk function is introduced. >> >> This commit adds function which treat link status structure >> and format it to text representation. User may create custom >> link status string using format string. If format string is NULL, >> the function construct standard link status string. >> >> Signed-off-by: Ivan Dyukov > Why pander to driver specific link messages? > This should come from core code in one format for all drivers. > I'm not sure that I understand your question correctly, but there is no driver specific messages.The function is intended for application usage only, not for drivers. The function has default format of link status, but application can customize it for own needs. We have disscussed it before. some dpdk applications like testpmd has custom status formating which lays on few lines of screen. so the function supports custom link messages just to not break screen layout of applications.