From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 495D0A0C47; Tue, 12 Oct 2021 20:08:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C315410E5; Tue, 12 Oct 2021 20:08:31 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id E5F9F410DC for ; Tue, 12 Oct 2021 20:08:28 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="250634749" X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="250634749" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 11:08:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,368,1624345200"; d="scan'208";a="547545402" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 12 Oct 2021 11:08:27 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 11:08:27 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 11:08:26 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 12 Oct 2021 11:08:26 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 12 Oct 2021 11:08:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EoeozzqIxmCsWt8+y1hHwLhrsxxpf3E2+l1904ALdsP+2N3ueh8D4++WKzWF9a1xlsMqX9/DXRkFL/VUCtuFR9gOIi7dajmJbgY7RIRWKrMu5rfTBDkCkHMNyaTGaMR6NUGI1sSSxEJgen7NFDrQifNavA5o5g/HwDkt3y7DICmxBXsTwbohqs9osQzp3la2yo0SQnYZ2CYt5yTzSiXiRXPsIb5X39tupVEjK/eDxBPL9ul9pLws79nUHgml7VDz0IrZJ/iUnic6LBtTKGHORZrfvXD9VEWaUnB7YbNiTxbiFlJxgG5/osnVdtPgDpxiJ29Ds+kiVzla+sCYsmXZJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4NT1WiaqEGEwfN0QaqMq0q+Gn2Ggau8HgyzW9mcUwMg=; b=n1+Djggu1Ua+zYPVsAyceI/7kP08ZaLbk0i1BmtKKC7DvU2B/7dXRASMEky04co12X5Y34vpEu+Uv532fzCN7YHL56TbgWhaWEiL2UsqNHbFdNjG5DtzIcneqNzJpMXy06CwKjnLCoq2YjBGRshgpKS8eClzPLU7i5SPE2VQESlMnlMgy1Yo1Eh5plj6F3o2yI25IHRU+rbhdBM2rZ587A7cDQ6EKiTl1LOlZiX7xe+zmbflqgfrCVG7ziKy9ptzGI3ElklWHv4CkSCREJCd3xWSb5zJDM6rvye8SiQ2DH0DdxMnNotnnqsROCpsOBNPc7tbImC39waqIqQxUAghlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4NT1WiaqEGEwfN0QaqMq0q+Gn2Ggau8HgyzW9mcUwMg=; b=kZiX5Bzxo6W3UpPzTuh483YLz1VrVPUCBz4sT1oL8FekDaOJvwfEfxHT6iFSyUJY9gV8Rz1dhW3KVhs6f180cZhiAmJ4oafELAXW7IQB7ZUZZEn/++Rq+iIi50ipM/RJqBASbbpomjP6wMTGj6cmC2+BRLIoDxQJhgYYwSlBqLU= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH7PR11MB5916.namprd11.prod.outlook.com (2603:10b6:510:13d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Tue, 12 Oct 2021 18:08:24 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 18:08:24 +0000 Message-ID: Date: Tue, 12 Oct 2021 19:08:16 +0100 Content-Language: en-US To: Ivan Malov , CC: Ray Kinsella , Jerin Jacob , "Thomas Monjalon" , Ori Kam , Ajit Khaparde , Andrew Rybchenko , Andy Moreton References: <20210923112012.14595-1-ivan.malov@oktetlabs.ru> <20211005155639.12277-1-ivan.malov@oktetlabs.ru> <20211005155639.12277-6-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211005155639.12277-6-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0088.eurprd03.prod.outlook.com (2603:10a6:6:30::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Tue, 12 Oct 2021 18:08:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c9da68f-261a-4536-3ac2-08d98dab4801 X-MS-TrafficTypeDiagnostic: PH7PR11MB5916: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ec820Rib2TvqIL67Y85sbjtW4KwTDDjOwMCIANX6g61Dje3MnyzZTDWqK06f+miG6uLAtlGyaplLatR7WQhgS4aw3g7rojjLStkfN4AsJZ+0TPALeVAcFQzu0UwOc032+ZDmK7FsdTFwLgs+T5UiC5UwZDJHv95fKNzsKtDIA8JUk/TOrWlHl4EgE6cgzrgDZqGtxOI8PVpPotRC1I4clxA4O3ZHeWrqfL48XcCjcOW1rtL7p7vumF5vVia+gNe97HgVaUXbbF9mKex6qjoQIFRt83v5GnpA26vTCjKDo+59VFa3tApHe5BoSqcxMhYH09TdCbPar80T86oRgCTAexzAzrtzeOsVrAUppv2ZjIBipqPEeAVXvWXPzaEhtYDzUS8lyKZhu14dffShbnSSRxObE8RxrZ0HC4lzq59Uf+SaSNSAvCgEJaO4MUoX5vORsYZaJFZkeHoz7tdVkj/Owc5cwd6UaFHFWO607LnRFD8fics0jWYhEdE6DjqJrpBUlHU30fgRQo9HK6N+UafbCAz1jrKRtoDN7/zJfa0Md7lsWXRMm8amvULlUhBhPC3l0svZOpSGv6zokfPLDq8bEh7+Bsx2JhNOKVvs6elF/mYrvJUYhAia1ItzltFTjsKmBYC8KW/nBU7dyt7F+/4wAtnem0djcZ2uM7zO4N62NQ+0nVW1Ue/5AeQa2r93ihMNm4f35MvEvwHCftv8X8NIlg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(8936002)(44832011)(5660300002)(8676002)(66556008)(83380400001)(4326008)(38100700002)(6666004)(26005)(66476007)(66946007)(508600001)(316002)(2616005)(6486002)(2906002)(956004)(54906003)(186003)(16576012)(53546011)(31696002)(86362001)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2M1N29JVm5tMFZ3U2I0dkEwZVNJc29QcklyUFN1MGlrYnZsOGFKNmNlRlpV?= =?utf-8?B?V1F4M1ZHTUJpQ2tyWHVYWDJORmFQNnZJSVcyWjhGYzZkSTNuWGxlRnlPUDd5?= =?utf-8?B?enNQQU40OThqcUg1TkZMZkpJdEJVOHFZL0R3WHd4Ri8wMnBiUkV2SElxbk5T?= =?utf-8?B?eEZBTnZVaGdka3dYVXUvbXhEVXVGOEhvSTl1SnBWUGxIOWxXb3pLRU9lNng1?= =?utf-8?B?WWY2cWtYb3I2d3ExYjVIb0wyTmljS1MvQTdXckpyRkZ2UUxlbkYwdnZ6UU9H?= =?utf-8?B?MjVLQk5zbEJXTzFqK2k0U3VDRjFpNDVXeXNzQmo5UUtXT3BMNGpKTE1qVGR6?= =?utf-8?B?cGh1RmdWUlRDNkNsbmRITTY2T1FiQnFGdCthUHRESmxESmhZM2krUXE1a3hR?= =?utf-8?B?VjNkOENVRC8rUWRSU2xSQXAyYWRTYzNJTjBSWXRUOUVza09hMXN0VDQ0cnhG?= =?utf-8?B?RzRsWXhxS1d3OUx2T3dqVFd2enJHUzN6ekduNzBMaGxoWnNLcU93dzYrbk5q?= =?utf-8?B?NUtaeDVpWUxPK1JjZENiTzNCaXA3MW4xMHJSVzdKbEJGY2IraXdnV1JxRlJz?= =?utf-8?B?Y0ZSMUFRb3dMS3pMVWJ3ZVQ4Z2JXajZlRkJuWnBubE4vZ2dlUVVsbjNQMU81?= =?utf-8?B?bEx0Q2lhbStabHBrRUNhWEJtbExLdDZmQ01ZWUhLbko2eTVFUTBZdzJxTVg3?= =?utf-8?B?dWFOQzZudW9wNG83K1NTMFB2UlFjb05xOExHUVA0RlZjWCtrTHhBcjcwMmtZ?= =?utf-8?B?QnVMVjh0WlZGMHNMV01oTGtkYXkxRWtzRThaYXZjZlVWSm9yZ2hoMTdXYVFH?= =?utf-8?B?MlA4SThiZ0dCTDBlOVFyQUhVeURXVW04Tm1kQnBrUDlxdWtBQlE3MFM5a3J1?= =?utf-8?B?bitQcFQwaWc4UU16cUl0WU5QVEZQL2ZNZkNxU3VDaGphWlVHVEt4TFR3bDAx?= =?utf-8?B?QTFsUTd0V2RwRmJwenJrclo0czg2b0VhZEZCdFdlRi9NcDJNd3RwaVFIWDhu?= =?utf-8?B?cTVRbVRpVlpuK3hJRUdIbDhYbklVcENtY2R5cHFDUkppOEZxWUpvY3ppaUY0?= =?utf-8?B?UTQ2UGtNOXhyQWRqVVR5aUhyTHRrK2NIamdIWWEwZnA2Uzd3K3o1Y3RrOTZo?= =?utf-8?B?ZElweWV0VWx2UW04YSsza1BjZkw0VG9EQ3BmTU5aTjdWL2NRTXJjMitIS1VG?= =?utf-8?B?UTQ5ZEMzUURsdEhXRVVPWFN2Y1lqb3dSSlRZUkQwMlRVMGVHeVRWTzZVcDgx?= =?utf-8?B?Z3B5U0RYbGEwMUErSlpvbjdibndFVFNpcWVuZHcveFJzYjduTTd3Q2pUUG0y?= =?utf-8?B?MHhGZlZ1bmFJVy8zcytDM3FmdGJVcTBDTkFUZkVKaWgvNldCWHM0NkJyYnoz?= =?utf-8?B?a1RYWitRZU1uNXVyNHRuQmx3OC9sTllubmtlYlV6aDg3TjJlNUs2TUdnSGJa?= =?utf-8?B?cmk2OTVOOUthMGM3NEh2THZsQVRvSjdwdUpVaW9TZUFlaFNhWFJZVGZ0b3Na?= =?utf-8?B?Yko0TlJCWmc4bHpoQitNVzNjVEw0ZjlmVHdXeGtHMHVWN0p0ZTRDUGNKRXJy?= =?utf-8?B?VlNJYmRjaDNSS3pSNlFuTzZlbzcvdkVTYkwzVWtLTjM5aW9rRDFraGtyWGI1?= =?utf-8?B?QUdzcTloL3NaQlZTSmZKbkkzOC9FZlZ2d3VsN01NVE00VlVlN2FDclRkYXlG?= =?utf-8?B?UXd3dzFGVmUwUmtvWWREQWlvUk10bUdvUk5ITEkyNFM4Q2RwUW1vY2FzcnRZ?= =?utf-8?Q?RCqq1vvYw/8t4xKYeRPbXwPVSUp7pFItfhqm8ZX?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5c9da68f-261a-4536-3ac2-08d98dab4801 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 18:08:24.5530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fU8nGMHewBkQYLGqiAlh7M7EadGPd2qLmEJkRt2FpnX2U67PbpZ637T+GCmjiS8zg8BVEXIiuSMtMLGBoVEZew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5916 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 5/5] net/sfc: report user flag on EF100 native datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/5/2021 4:56 PM, Ivan Malov wrote: > Detect the flag in Rx prefix and pass it to users. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy Moreton <...> > @@ -407,6 +409,15 @@ sfc_ef100_rx_prefix_to_offloads(const struct sfc_ef100_rxq *rxq, > ESF_GZ_RX_PREFIX_RSS_HASH); > } > > + if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { > + uint32_t user_flag; > + > + user_flag = EFX_OWORD_FIELD(rx_prefix[0], > + ESF_GZ_RX_PREFIX_USER_FLAG); > + if (user_flag != 0) > + ol_flags |= PKT_RX_FDIR; > + } > + Hi Ivan, This cause a build error after another sfc patch merged into next-net [1]. Following change [2] seems fixing the issue, but to be sure nothing is missed can you please send a new version rebasing on top of latest next-net? [1] Commit d86c6ced8732 ("net/sfc: use xword type for EF100 Rx prefix") [2] diff --git a/drivers/net/sfc/sfc_ef100_rx.c b/drivers/net/sfc/sfc_ef100_rx.c index 704c62c0ac90..8237b772f151 100644 --- a/drivers/net/sfc/sfc_ef100_rx.c +++ b/drivers/net/sfc/sfc_ef100_rx.c @@ -415,7 +415,7 @@ sfc_ef100_rx_prefix_to_offloads(const struct sfc_ef100_rxq *rxq, if (rxq->flags & SFC_EF100_RXQ_USER_FLAG) { uint32_t user_flag; - user_flag = EFX_OWORD_FIELD(rx_prefix[0], + user_flag = EFX_XWORD_FIELD(rx_prefix[0], ESF_GZ_RX_PREFIX_USER_FLAG); if (user_flag != 0) ol_flags |= PKT_RX_FDIR;