Re: [dpdk-dev] [PATCH] net/tap: add support for fixed mac addresses

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/11/2017 8:18 AM, Pascal Mazon wrote:
> Hi Keith,
> 
> I have a few comments on your patch, see inline.
> 
> On Mon, 10 Apr 2017 13:18:50 -0500
> Keith Wiles <keith.wiles@intel.com> wrote:
> 
>> Support for a fixed MAC address for testing with the last octet
>> incrementing by one for each interface defined with the new 'mac=fixed'
>> string on the --vdev option. The default option is still to randomize
>> the MAC address for each tap interface.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>

<...>

>>  RTE_PMD_REGISTER_VDEV(net_tap, pmd_tap_drv);
>>  RTE_PMD_REGISTER_ALIAS(net_tap, eth_tap);
>> -RTE_PMD_REGISTER_PARAM_STRING(net_tap, "iface=<string>,speed=N");
>> +RTE_PMD_REGISTER_PARAM_STRING(net_tap,
>> +			      "iface=<string>,"
>> +			      "speed=N,"
>> +			      "remote=<string>,"
>> +			      "mac=fixed");
> 
> Indeed, I forgot to update that when I introduced the remote!

Hi Pascal,

If you can send a patch for this, it can be quickly merged, so it won't
have to be in this patch.

> 
> That's it for me,
> Thank you.
> 
> Pascal
>