From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BC9575587 for ; Tue, 11 Apr 2017 10:31:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491899484; x=1523435484; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=Dj9K0j+aAXzsKhRiZ7wrSh12JX+FY8sFNG3FuZsjmSU=; b=r1Ki0jVrl6EMlu2AW/ZYgutbbkDAHCOaL902VdwmmOxk3ugJK6DRTXGz h24uWBF+zr8pzyGIWx1sb/Km2ag/MQ==; Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2017 01:31:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,184,1488873600"; d="scan'208";a="1133864252" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga001.fm.intel.com with ESMTP; 11 Apr 2017 01:31:22 -0700 To: Pascal Mazon , Keith Wiles Cc: "dev@dpdk.org" References: <20170410181850.44845-1-keith.wiles@intel.com> <20170411091851.62ab28ad@paques.dev.6wind.com> From: Ferruh Yigit Message-ID: Date: Tue, 11 Apr 2017 09:31:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <20170411091851.62ab28ad@paques.dev.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/tap: add support for fixed mac addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 08:31:25 -0000 On 4/11/2017 8:18 AM, Pascal Mazon wrote: > Hi Keith, > > I have a few comments on your patch, see inline. > > On Mon, 10 Apr 2017 13:18:50 -0500 > Keith Wiles wrote: > >> Support for a fixed MAC address for testing with the last octet >> incrementing by one for each interface defined with the new 'mac=fixed' >> string on the --vdev option. The default option is still to randomize >> the MAC address for each tap interface. >> >> Signed-off-by: Keith Wiles <...> >> RTE_PMD_REGISTER_VDEV(net_tap, pmd_tap_drv); >> RTE_PMD_REGISTER_ALIAS(net_tap, eth_tap); >> -RTE_PMD_REGISTER_PARAM_STRING(net_tap, "iface=,speed=N"); >> +RTE_PMD_REGISTER_PARAM_STRING(net_tap, >> + "iface=," >> + "speed=N," >> + "remote=," >> + "mac=fixed"); > > Indeed, I forgot to update that when I introduced the remote! Hi Pascal, If you can send a patch for this, it can be quickly merged, so it won't have to be in this patch. > > That's it for me, > Thank you. > > Pascal >