DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com
Subject: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds
Date: Mon, 11 May 2020 11:25:13 +0100	[thread overview]
Message-ID: <e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com> (raw)

Now that kernel modules aren't built by default, we can be more
strict with their build process, and fail the build if they were
requested to be built, but weren't.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
 kernel/linux/meson.build | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build
index 1796cc6861..da79df1687 100644
--- a/kernel/linux/meson.build
+++ b/kernel/linux/meson.build
@@ -5,8 +5,7 @@ subdirs = ['igb_uio', 'kni']
 # if we are cross-compiling we need kernel_dir specified
 if get_option('kernel_dir') == '' and meson.is_cross_build()
-	warning('Need "kernel_dir" option for kmod compilation when cross-compiling')
-	subdir_done()
+	error('Need "kernel_dir" option for kmod compilation when cross-compiling')
 kernel_dir = get_option('kernel_dir')
@@ -20,8 +19,7 @@ endif
 make_returncode = run_command('make', '-sC', kernel_dir + '/build',
 if make_returncode != 0
-	warning('Cannot compile kernel modules as requested - are kernel headers installed?')
-	subdir_done()
+	error('Cannot compile kernel modules as requested - are kernel headers installed?')

             reply	other threads:[~2020-05-11 10:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 10:25 Anatoly Burakov [this message]
2020-05-11 10:27 ` Bruce Richardson
2020-05-19 16:01   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).