From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C9ADA0350; Mon, 11 May 2020 12:25:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D9C471C138; Mon, 11 May 2020 12:25:15 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id B45891C129 for ; Mon, 11 May 2020 12:25:13 +0200 (CEST) IronPort-SDR: 0oD9W57UF+8a0KMjjLHlr9iFWUffz3X/H5GmDJIIApysAsyZEXeb9FS3oDxYtFfDejYnrzHRfs WrIzoB8jlhmQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 03:25:12 -0700 IronPort-SDR: NEGnMHczsXNJ8zEwYVhxHEZaXfwSP+Xrm824KpOuqcX2nhiHBOufVJD3QJZ1+Y6Xi0nE9mgUlX TTsrjvZR98Pw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,379,1583222400"; d="scan'208";a="265110472" Received: from silpixa00399498.ir.intel.com (HELO silpixa00399498.ger.corp.intel.com) ([10.237.222.52]) by orsmga006.jf.intel.com with ESMTP; 11 May 2020 03:25:11 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: bruce.richardson@intel.com Date: Mon, 11 May 2020 11:25:13 +0100 Message-Id: X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Now that kernel modules aren't built by default, we can be more strict with their build process, and fail the build if they were requested to be built, but weren't. Signed-off-by: Anatoly Burakov --- kernel/linux/meson.build | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build index 1796cc6861..da79df1687 100644 --- a/kernel/linux/meson.build +++ b/kernel/linux/meson.build @@ -5,8 +5,7 @@ subdirs = ['igb_uio', 'kni'] # if we are cross-compiling we need kernel_dir specified if get_option('kernel_dir') == '' and meson.is_cross_build() - warning('Need "kernel_dir" option for kmod compilation when cross-compiling') - subdir_done() + error('Need "kernel_dir" option for kmod compilation when cross-compiling') endif kernel_dir = get_option('kernel_dir') @@ -20,8 +19,7 @@ endif make_returncode = run_command('make', '-sC', kernel_dir + '/build', 'kernelversion').returncode() if make_returncode != 0 - warning('Cannot compile kernel modules as requested - are kernel headers installed?') - subdir_done() + error('Cannot compile kernel modules as requested - are kernel headers installed?') endif # DO ACTUAL MODULE BUILDING -- 2.17.1