From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC30BA0548; Thu, 1 Apr 2021 14:27:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B86B141152; Thu, 1 Apr 2021 14:27:19 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id BF37114114B for ; Thu, 1 Apr 2021 14:27:18 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3B16E7F530; Thu, 1 Apr 2021 15:27:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3B16E7F530 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1617280038; bh=YWG5irCLql/5N19yXkP0ZGE1WhwPFoRHDEUa6TIx+yI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=lIfSQeZDnDvCoSBC4gJYF6WNGW2hS7JHILAa9F5KQFaRelJn1hYfoNxIIklqoKZj4 e+8c2CXeQvkqRjqDGPLXk1dp5BxwKj4lDF3WFKbD/Tmq7UcqZx8xgn4hksikxgDf/7 1xvW1ljzGBpEoS3/ZpGMpOvGTcq5LtA4Qt43QPAM= To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, bluca@debian.org References: <20210401115009.1063844-1-bruce.richardson@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 1 Apr 2021 15:27:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210401115009.1063844-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH 00/14] Build file update proposals X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/1/21 2:49 PM, Bruce Richardson wrote: > This RFC contains 5 changes/updates to the DPDK build and build files. These > updates all assume that the minimum version for DPDK has increased to at least > meson 0.49 as proposed in [1]. > > The changes in this set are: > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels > in the foreach loops when building library or driver components. > 2. For libraries, drop support for header-only libraries, which was added just > for the "compat" lib which had a single header, and is now part of EAL. This > similarly reduces indentation levels and makes the code easier to follow > 3. Since the larger blocks of meson code in our repo is seeing massive > whitespace changes, take the opportunity to switch our indentation style for > meson files from that of C-files using tabs, to Meson/Python style using > spaces. [More below on this for discussion] > 4. Remove the "librte_" prefix from all our library directories. While as useful > cleanup, the main driver for this was that it simplifies the matching for #5 > below. > 5. Add a "disable_libs" build option to allow the user to optionally not build > certain components. Include in this an explicit list of libraries which are > "known safe" to disable in the build. For now this is a short list of three > libs, all of which are safe because they are not buildable on FreeBSD. More > work is needed to expand this list in future. > > Of these changes, I expect #3 to be most controversial. The initial > implementation of meson build for DPDK should have originally been done using > the correct meson style using spaces[2], but sadly it was not done that way. If > we are to ever change, I believe it should be now while other rework such as > this is being done. Here are the arguments for/against, as I see them. > > Reasons to change: > * Align with official meson style, used on other projects > * Reduce indentation levels in code. NOTE: While not normally a consideration in > programming, this is a possible issue with meson compared to C or Python, > because we cannot create separate functions to move inner loops to lower > indentation levels. > * It's probably now or never. +1 and I think it is better to do it now, not never > Reasons not to change: > * Outstanding patches for meson would need respin > * More work involved in backports - though with the more complicated meson > blocks changing whitespace levels anyway due to #1 and #2 above, it's probably > no more difficult than it would otherwise be. The extra changes to e.g. list > indentation, require work to adjust whitespace, but are trivial to fix. > * Code churn > > Feedback on these patches and proposed changes welcome, as always. > > [1] http://patches.dpdk.org/project/dpdk/list/?series=15827 > [2] https://mesonbuild.com/Style-guide.html#tabs-or-spaces