From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Cc: nikhil.rao@intel.com
Subject: Re: [dpdk-dev] [PATCH] test/eventdev: add multi port test to suite
Date: Mon, 21 May 2018 17:09:13 +0530 [thread overview]
Message-ID: <e654728b-b14c-9593-ead4-a4ad11879cb5@intel.com> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7C93@BGSMSX101.gar.corp.intel.com>
Hi Vipin,
Thanks for posting V2.
On 5/21/2018 4:30 PM, Varghese, Vipin wrote:
> Hi Nikhil,
>
> Thanks for the inputs, I have shared the V2 with suggested changes. As
> for**
>
> <snipped>
>
> + adapter_free();
>
> Is it necessary to call adapter_free() above ?
>
> <Snipped>
>
> With the changes suggested above
> Acked-by: Nikhil Rao <nikhil.rao@intel.com> <mailto:nikhil.rao@intel.com>
>
> Yes it not required by current test sequence.
>
> This is added for safety, in case in previous free is incomplete or
> interrupted.
>
I don't see a case where the previous free can be incomplete or interrupted.
Nikhil
next prev parent reply other threads:[~2018-05-21 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 10:17 Vipin Varghese
2018-05-18 5:19 ` Rao, Nikhil
2018-05-21 11:00 ` Varghese, Vipin
2018-05-21 11:39 ` Rao, Nikhil [this message]
2018-05-21 13:54 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e654728b-b14c-9593-ead4-a4ad11879cb5@intel.com \
--to=nikhil.rao@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).