From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nikhil.rao@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9A2551AFEF
 for <dev@dpdk.org>; Mon, 21 May 2018 13:39:32 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 21 May 2018 04:39:31 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; 
 d="scan'208,217";a="230266842"
Received: from aravathk-mobl.gar.corp.intel.com (HELO [10.252.146.142])
 ([10.252.146.142])
 by fmsmga005.fm.intel.com with ESMTP; 21 May 2018 04:39:29 -0700
To: "Varghese, Vipin" <vipin.varghese@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Jain, Deepak K" <deepak.k.jain@intel.com>
References: <1526552256-56523-1-git-send-email-vipin.varghese@intel.com>
 <875b1678-b7bc-ca2e-b11f-c9f9bc33b9aa@intel.com>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7C93@BGSMSX101.gar.corp.intel.com>
From: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: nikhil.rao@intel.com
Message-ID: <e654728b-b14c-9593-ead4-a4ad11879cb5@intel.com>
Date: Mon, 21 May 2018 17:09:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7C93@BGSMSX101.gar.corp.intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] test/eventdev: add multi port test to suite
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2018 11:39:33 -0000

Hi Vipin,

Thanks for posting V2.

On 5/21/2018 4:30 PM, Varghese, Vipin wrote:

> Hi Nikhil,
>
> Thanks for the inputs, I have shared the V2 with suggested changes. As 
> for**
>
> <snipped>
>
>     +        adapter_free();
>
> Is it necessary to call adapter_free() above ?
>
> <Snipped>
>
> With the changes suggested above
> Acked-by: Nikhil Rao <nikhil.rao@intel.com> <mailto:nikhil.rao@intel.com>
>
> Yes it not required by current test sequence.
>

> This is added for safety, in case in previous free is incomplete or 
> interrupted.
>
I don't see a case where the previous free can be incomplete or interrupted.

Nikhil