From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3B6FA0547; Mon, 19 Apr 2021 08:41:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B596240683; Mon, 19 Apr 2021 08:41:07 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 5DF2840040 for ; Mon, 19 Apr 2021 08:41:06 +0200 (CEST) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FNxvv46FHzpZJ0 for ; Mon, 19 Apr 2021 14:38:03 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 14:40:57 +0800 To: "Li, Xiaoyun" , "dev@dpdk.org" CC: "Yigit, Ferruh" References: <1618469214-35316-1-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Mon, 19 Apr 2021 14:40:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, ÔÚ 2021/4/19 10:53, Li, Xiaoyun дµÀ: > Hi > >> -----Original Message----- >> From: Min Hu (Connor) >> Sent: Thursday, April 15, 2021 14:47 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> Subject: [PATCH] app/testpmd: support the query of link flow ctrl info >> >> From: Huisong Li >> >> This patch supports the query of the link flow control parameter on a port. >> >> The command format is as follows: >> show port flow_ctrl >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) >> --- >> app/test-pmd/cmdline.c | 83 +++++++++++++++++++++++++++++ >> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +++ >> 2 files changed, 90 insertions(+) >> > >> + printf("\n%s Flow control infos for port %-2d %s\n", >> + info_border, res->port_id, info_border); >> + printf("FC mode:\n"); >> + printf(" Rx: %s\n", rx_fc_en ? "On" : "Off"); >> + printf(" Tx: %s\n", tx_fc_en ? "On" : "Off"); >> + printf("FC autoneg status: %s\n", fc_conf.autoneg != 0 ? "On" : "Off"); > > "fc_conf.autoneg ? "On" : "Off"" is enough like the others in this patch.Got it. >> + printf("pause_time: 0x%x\n", fc_conf.pause_time); >> + printf("high_water: 0x%x\n", fc_conf.high_water); >> + printf("low_water: 0x%x\n", fc_conf.low_water); >> + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); >> + printf("mac ctrl frame fwd: %s\n", > > Follow others' format will be better like "Send Xon". > "Forward MAC control frames:" > I don not catch your meaning. Is that right?: change the statement " + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); + printf("mac ctrl frame fwd: %s\n",fc_conf.mac_ctrl_frame_fwd ? "On" : "Off") " to " + printf("Send Xon: %s\n", fc_conf.send_xon ? "On" : "Off"); + printf("Forward MAC control frames: %s\n",fc_conf.mac_ctrl_frame_fwd ? "On" : "Off") " >> + fc_conf.mac_ctrl_frame_fwd ? "On" : "Off"); >> + printf("\n%s************** End ***********%s\n", >> + info_border, info_border); >> +} >> + > >> >> -- >> 2.7.4 > > . >