From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD7A1A034C; Fri, 25 Feb 2022 19:01:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 460E24113D; Fri, 25 Feb 2022 19:01:30 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E0D31410FD for ; Fri, 25 Feb 2022 19:01:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645812089; x=1677348089; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=fIAJ+VEvZJi579wpLLS1hDtFL7KNo6lPCXg+99Pw9jY=; b=dGYBlZ8Pn2qMpgFqRj2c/VS9P8rfObc4b/HlD7jpLBPHO22hvBagqv9I D5YP0DeVeOcZ3R4yEiQIZjVO5KehXE5Uic5H/w/gACw+ahpTLxu/vzx2N x74lpUAVsB0R0DpBqeIsVlJKreCY19UZhnpcnqKUsc1KrlXfYPqX6eV+7 WlhIxpgqxyKY9go82udZvEj4/twSVY561yBSZwEiVCCR194YUrgx7VtHW yBc4sQf/Be+VM7Wd72hxOcaQI1PP19VV0BO3ivjiq2voRGoIElRtegQUR eNQB63eGiW9zyEB/G5pvUYI4gd09XVApdUm8lmhzWTjM5zkUyc1goW0wb g==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="236054903" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="236054903" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 10:01:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="533658067" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 25 Feb 2022 10:01:11 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 25 Feb 2022 10:01:11 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Fri, 25 Feb 2022 10:01:11 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 25 Feb 2022 10:01:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrdjTnYbFuOhf3Uyn1TErXOOjFdxwShkLJ75wPAGgI2GhcSCFVCcWXw6pxlggqBQ3Jr1xcVNkQEhS8UZNNhp0K4JUxazwg4GCbXz4K9nrbOSYDbkDHGsGp1RkMRWPPoTIF02/hDdBcU2f3I0gcUrqsYa6DaGDJXHJCb2SgWmCZXl8Zi8YpSKPvbxR3zcTcIfhl2zi6qa6WCGBvvFbcXFnl3Wgoo5ElfolMkeJiM2Nin3G+d/GQoJ+Ty8GHFjl8IB1G1QmCW40X+3G2kFTZNqxJs5aUb+jLygBb+vYr5YTS7DoYfK9DN8I3hAiSkSkuqGR5eoBdoWovF6CoZtSakV4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vg7BHxmI8/PpJAaOYAvBEECGSWtzW5mzmKpPzg9LROs=; b=HOdqDHELuZZt7jzhxKT/PBF3bMptiDtGZ28Mub6uvr+GdOHgiBrBgpzPaQoQChik9On1hfOq0mFoJealKCDHRy/icH89xhVuE76mcgSINfH1jA1kLGLXe6nh9PlmUF8RpFNZOR5q3fK1vFU7/zNcnolr88wML/rJ6lZNod96PfecCqFYzuThIVPoIdasj/gZW/tv56rKZqhergrxhc93h1f/bbrTLEk2cXsYxhPfjdWXCJyTW5sCOc3gTmYqHyiXsILQiYA2FODN56cMoFLM+isOj1Y89anQPOHJwtCCQLWsxLFH5NAj8SwCAR2agjk9PVOjDNBqn3DZ15IAFyi5mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BY5PR11MB4181.namprd11.prod.outlook.com (2603:10b6:a03:18c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 18:01:09 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%5]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022 18:01:09 +0000 Message-ID: Date: Fri, 25 Feb 2022 18:01:03 +0000 Content-Language: en-US To: Michael Baum , , Thomas Monjalon CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , David Marchand , Ray Kinsella References: <20220223184835.3061161-1-michaelba@nvidia.com> <20220224232511.3238707-1-michaelba@nvidia.com> <20220224232511.3238707-2-michaelba@nvidia.com> From: Ferruh Yigit Subject: Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal X-User: ferruhy In-Reply-To: <20220224232511.3238707-2-michaelba@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0414.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 649c7302-06a4-47ff-d1f3-08d9f888ccf3 X-MS-TrafficTypeDiagnostic: BY5PR11MB4181:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eekyYsWBU7R05ledmq7u9wYg/HReYBo+mqDMMUgeA8WezPMxn8hwZtyDO/cHzbTX78nKMLW1LuZG3QieL7LcNwqmS7LRU9VOq+/eXaPxYxYeDpbu6zRucUi7I5362OJpxrbD0LaPmAa/xQ67PlYTM0RuLGo/XGHXinTggYGXoBAGrJ+Nc2WTEewTPcbjhH1WB/yDiS3FER+Sfrk2z2PGWhMVsQ/+LJnBvZniG4mA7oNxLp9c8oMu9aDoRiKT/Ac46kdTdU/XD+FOoMqoJjR+OBrRSsfPlGMiIx2JT9arwgohX7t3BKq1OX+0LxOmlGDwS5DAQngnIHRrr16nJv4m74Kb7gGj7b0wl+kXgV2D47TaDbDWBy6dc1lUjbjoIQdq4PrKq7JIMvLFZiVDnLSirAiqBBZSCXzsqhXmuj3DXQOrvtrApC5eSwbRNQ6S3xqA/FHztyGs0ON1RHi7T6V9y6FiwN8okNVxjgqCa91ssuLSXs2gCxGRlCJfEOYsBFsefN70TZYku3PS5kK/ET258l7pb2oduh+WGPN18Vz4cKkHTYC3mKecoBH+0cTZ1TFzIE3O63LhTRz8oAnOk6ApKb2m+Nb+bVbYfcnQBtPgkB4Gyk+Rpc05/Kg+UyKs4ZVPfGaPJlBqxrodN+d9VLkyZjf6i77cVw7OeHVQWgaFVbtxsl2cKK6NtOoJjtiIpK6GEz6UPt2u1PktLgmoBYWN9w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(8936002)(38100700002)(2906002)(66476007)(8676002)(66946007)(66556008)(4326008)(53546011)(110136005)(31696002)(44832011)(5660300002)(6666004)(86362001)(6512007)(31686004)(54906003)(6486002)(316002)(186003)(2616005)(83380400001)(26005)(36756003)(4744005)(6506007)(508600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3dVMW9IU0t2dEl2L0NCa0ZPTHJRTzY3bFJvTlVMUHNrazJ0aDdmZWZla0k2?= =?utf-8?B?bm04VGNmdlo0NEJYWkdYckhUMWtHSHBDTk5mS1VSQm13dktBa3hteU1uMEpm?= =?utf-8?B?elNSRlVPdk45K1ZqZyszWG51LzBsdm5LYTZNWit4UUdtMThrS2hYRUJ0SEJw?= =?utf-8?B?R0NxREhaZjlPWi9hS0ZpQjZlelB1L1B3TldvMUo3VjF4a014QzgvRVZjM1ls?= =?utf-8?B?R0pLQ2V1cVNuSE1jdzV6WlVFKzBxSEI5VTV3YmFkN2VQVk9IUHR4ZlZoRjFP?= =?utf-8?B?QzdMRXA3RllTbFBnSWd3aWpqS2Z5a2hHelBMZWMvaVcvN0RrNFYwU2NTOUdB?= =?utf-8?B?dnVwSTNzeDUxQ0gyTlhlQ0RPR04vNXRGSzdpSjc0MkthUDhVVE5EN0M1VHUr?= =?utf-8?B?RXYvM04zandXVnlRMkJqVE12WUFJbDlFTkxIUldMZllMekd4QTc1aWJxdXFG?= =?utf-8?B?RTJuS3l3ajRUcU1KeHduNFZuZUZSSlBGSENKTStaODRoeHRyRjRKS1NseFpC?= =?utf-8?B?Y2VObzhDd0o4REM5aWhnK2tGS2diNUNDcjZGYmpRNHZzM3BuTnh0TWI2YzlX?= =?utf-8?B?dlBKRTdENDdtTUlhSHpMaElYV2ZwRkVPbVRDdmtBVVZrVUJkcjBNei95K2Zq?= =?utf-8?B?aUo5Y3pXSk1lK29XN3cwS3c0cWRGWkNiZ2Z0Y0I4c0dXSmlJdmJLaS9HbTBQ?= =?utf-8?B?UDlGbmpFUW41UGZhNS9VdnRQUmdFUmQ5bExmeVRZcUIyMWw3ckpScDREVytG?= =?utf-8?B?Vnc4eUJML1cxSnlNWGQvaFdnSHg3ZXpnbi94RGZYRTl5eFJUOHp3dVhqZDFp?= =?utf-8?B?Mm5zQVk3dUMwTm1JV0dqZ3U0bytCT1pmTTJDK09pRlpuVkFNTHBBUENzVGZ5?= =?utf-8?B?a2U4bFZ2OXFjTlk0K2I4Q05VZ05qRG1GSjJ6akUvSGVvWHBNdDl5dWF5K3dp?= =?utf-8?B?c3J0am45blptYkw4M0hoU1lZMEd1SG8yQXZPL3E1cjc1SjAyNDBvZTdTazhv?= =?utf-8?B?elI2ZWRVUmtQZFJSTVhndkxSVHNOV1FJOFk2dkxncHMvWHhXcUZTdU5YcFlO?= =?utf-8?B?K1JxaEZKaGVNd2g5UTYrczZid1FxTyt4NG82ZlR3K3lMK2JEQ0NFbUp0RTh5?= =?utf-8?B?SzQ3OHEzd3prR2tINGdRakp5ZjgxOVJEMk82ek9SYjNqRlRLK09KQ1JCOWhu?= =?utf-8?B?WWRwWXZNMDI4SVdBM3VLSmNqNnI3NUJzMGtWeWQ1SVdkNEJCQUFPQ1MwVkYw?= =?utf-8?B?Wk5JZzF1elNxRWhmRXVGR0JPSWR2YUUzbkxiVjhlOGdURXljNFVJQ2x4a0hD?= =?utf-8?B?bGlQQUZ4OGNDWkIvSlZGUVdGeDVMWjErT3VQTjVDckMrNWVUaHFKN2VyamVZ?= =?utf-8?B?bkh4d2lUMEFHcXV2aHZDd1lleTdOdnpEUG44YzVUck1WbnZIVWo1M0hEYUJ5?= =?utf-8?B?Nmh6cDJ3MHFKUUJVWmpwSmxRQXRRZktvRGU3VTdDSFg2czJhUkp4QVNzZXNj?= =?utf-8?B?aVpnaUFIQUI2NjNmTUp0YUJRTU9RZm5WeHN2b2JIcXNPdlFVaitIdzhRUEF4?= =?utf-8?B?ZFEwZEYyNGNkL01jQks3b3J1MEdiNllnUXBudzFCWGkxNFpjVXlZRkhzTUxw?= =?utf-8?B?TTRkUkhibG9rcnZyd1prNk83M3grL29mekhQY1ZpSnczdG9VK1hwL3Nmb08v?= =?utf-8?B?MGEvbU9ybnJaMFFqWlpwaDk0akNpNmlhTTRMVGYxNE5kKzJZN0tCWDNCMTJu?= =?utf-8?B?VFAwMHNWNzNuQ21FR2tFb284cjJYdzZYV2N2dHdCdWxESDhMaWwrbmhGRUZn?= =?utf-8?B?M2xIcGxScUpsSXpKazZVeTFrV05BV1JjWGtXUW9CbVhKQjBRdTk1cjd2d2tB?= =?utf-8?B?b3ltR0hqanhncGVla0ZGR0VtSzVLdzliTkc1NEN4M3hveVBYTlE2YW1jYnVy?= =?utf-8?B?Q0xKNzhtdjFwQnFFR0JyRC8vSkVSR3R4N0NNbEl2bVFXT0ZsTHRYd1dCcGVa?= =?utf-8?B?bWQ2ZFJxQmt4WmtYSGN1U1VIWE0yb1FyNWxqa1M0V0xyOHpKYlpENTBqRFZs?= =?utf-8?B?WFJIREFpZU1tNDFFL3lSbU5RUVE5R25ZcUNVSlFEVUNBRGhSZ0VBanZ4Vlha?= =?utf-8?B?d1NkUDJDVXJKMC9uNkwxb0ozdXlLdWRONFZPeDBJbkJwM2k4LzB1Qnd2b2pn?= =?utf-8?Q?Pc4wyT2wef4YlP+M4UcFYjE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 649c7302-06a4-47ff-d1f3-08d9f888ccf3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 18:01:08.9895 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 97TvPxVqB501a2huxoVxKj1SZErrbWw4xSosLKEzcp5mfTcbwKc82ScVgi++3X2rr4qdrefP0sUNoHQsz/zeoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4181 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/24/2022 11:25 PM, Michael Baum wrote: > The functions which are not explicitly marked as internal > were exported because the local catch-all rule was missing in the > version script. > After adding the missing rule, all local functions are hidden. > The function mlx5_get_device_guid is used in another library, > so it needs to be exported (as internal). > > Because the local functions were exported as non-internal > in DPDK 21.11, any change in these functions would break the ABI. > An ABI exception is added for this library, considering that all > functions are either local or internal. > When a function is not listed explicitly in .map file, it shouldn't be exported at all. So I am not sure if this exception is required, did you get warning for tool, or is this theoretical? cc'ed David and Ray for comment. > Signed-off-by: Michael Baum > Acked-by: Matan Azrad <...>