From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51065A0C4D; Fri, 13 Aug 2021 13:58:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E088B4069C; Fri, 13 Aug 2021 13:58:46 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 855FA40140 for ; Fri, 13 Aug 2021 13:58:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="301134589" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="301134589" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 04:58:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="440350239" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 13 Aug 2021 04:58:43 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 13 Aug 2021 04:58:43 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 04:58:42 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 04:58:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 04:58:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aWtxAFgcMc9TQuwHpQuVFM6X5/8XIS8SQCM9mgvbJ5VzS2q8qXGjb6q9mjh00uOE9e7zXS1odESVYdfEbBbm7/KB5ow188J0hHNNGOKBFrA1Sc29QYBNjYuCsDwCy+whkSOFKzxhtmuxn5+Rz9pej8GgYIhyp5g4iFmgeQhUWzLUZpLdG6HoijqdE1PK4clZbGeqAh/qiNIqP1wcwJCld6+/Aj9OXV4YPFj+H8a9C+NxKUhsutNwNXHe4XSBB9/BvsFPkRnrH59ztIvFx+oD36RrA/hIrzbxRz+OFtAA4a03+E9mx+qX5z7lMNkqkGJv3hyFZ+VLbBODlqOCEkJsZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXKlV83InNBsNfHkx49VG4AHmX5sio1nm7hvT3GFqT0=; b=jb0++0yTDz0s0SxHtmzPfnPA6Nf8IKtmU9rcbCkbQHL02jB8c2JTpzIK76KVPhvbnvjVBGpX/AbcAZMk6ZEZGaUhPLTDIMycsZkSIrOiC6bZu63VQzOrtKd0WwCZMZhqdprWf6TblwmN8jfTPvZtVEUnzGCu4VjQVDDxnGr8numoPoGOyyrROQFmyn527jn6J/GoNe4SsXQrPReVKut5GhMoX90Vx0/2T9lmvOFw7IkObHDALiMN/CZ6JNiPGgPfq3ZaSmSC8/gStZmfti+LQMSyGHoW/7nv8RF3XsxApmUAVIhCq7QBVhW3M0VtZE9lZ3fuJY85SR+nIeoqe4byPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XXKlV83InNBsNfHkx49VG4AHmX5sio1nm7hvT3GFqT0=; b=N9AURTLi6ri2V10PqaQcOoDlnzBI9L8Pv6T1c5mLim1e2UgrF8JwKg9o7w/oHXPjBqpYXQ/kBOKKpIHyu75rshXt1YkMfl4Tf/H4iBwWSYT/1HFISMPZASl0076SGbk6dCFLo8TS2KW3oG8Y3gUA3UYTJDYLc9ECuV4UNaic4hE= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4951.namprd11.prod.outlook.com (2603:10b6:510:43::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.19; Fri, 13 Aug 2021 11:58:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 11:58:39 +0000 To: Wenjun Wu , , , , References: <20210802083619.1003586-1-wenjun1.wu@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 13 Aug 2021 12:58:33 +0100 In-Reply-To: <20210802083619.1003586-1-wenjun1.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0048.eurprd04.prod.outlook.com (2603:10a6:10:234::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0048.eurprd04.prod.outlook.com (2603:10a6:10:234::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Fri, 13 Aug 2021 11:58:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0f6e4f2-3969-41db-1da1-08d95e51affa X-MS-TrafficTypeDiagnostic: PH0PR11MB4951: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6lEicyVqmVWc48tKB+h/nm01VYnvQR7jRsDiGr8aIvSh34EDevuXARbqLMdqGMZF4/iAbvqZ0RjkNcU+UdqHFG2eT1BIetdmdIDo4CcAoUVJINUMeRd9ThwxsY3IfbH5hEOuRtdfXhhC1Jh6PKNEzV0/YvrtviSNTtVwVrInBxgAk/Ng8xqOBiS3M60Bz+TUGeu7H1WOtV4LWFQTjrH20VEGyHlnp2QXEviuGybFkS8ovycFzS6pbv8RYy58GV8xiseEFq6p5t5Ik8ui6gonpgtranNizO/F3osoPLroeXV0tSMQpIKDn3nY+29lJJtDUUwn4hmYZziy4o15dFZ0UFai+OOOhWMKg2KcroLfsjs+wBJfeYYaxJr6Mg0mUq/1SOikxsDU7/czNKHo2b05KtFyPL6VKuHyViecUG2th1UHWh5Da8s67vWEC6U8KnQYSjo+mbqaSlbgJozPbubRKurMg9Kbpp3vpiKiiCbuZMmzt/ml7HHJG3KfcOW45Xrjav0mrARjJu92qTsX2pVgbQRfIrdYp0rlVwlwbo1ZUlOaSpuFMm0fM05VMQ3rlVBJA0taCc+lqqns6WonZdGb576kStwzuxSBFODsSy3u9k1+E0ORIopvUcpvoAkKMGsVw1ACEix8lfXXRcmtAYotzMUrogW0TasCwrGMiGWNuRi2qcjH0K+PnN60RrOOSmeOQfGXVSdsC7QkuvCRzVhk9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(366004)(38100700002)(66556008)(36756003)(478600001)(86362001)(66946007)(66476007)(53546011)(6666004)(8676002)(6486002)(83380400001)(5660300002)(26005)(8936002)(186003)(16576012)(31696002)(6636002)(31686004)(316002)(2906002)(44832011)(2616005)(956004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUpOdFZmL0JqK1MrUkxiQmY2dm11Z1dGcWEvNlVzZ1lwNDRid2w3TFptZFhk?= =?utf-8?B?SGs0ek9lZXUxTVNwaFVpNkRKK3QzUVNpdzR5N0FMTnV2dUczRGxaL25PTDQz?= =?utf-8?B?U0RoTU1UY3dZVGduTnFnK1NyNDh2VXdwSE5NcmVrRnMwdEVqQk9wa1VWcW1V?= =?utf-8?B?RTd4MWdOR08rU1ZVMnNDL2EzZmp5WExzYnp4TE96N1FhZ2pRQmkwVCt3V2tn?= =?utf-8?B?bTA0TkV4S2tFQitWWTZiOXA1Q2pReWJXbHo0bndQTVl6RHVncFEyNGU5RGt0?= =?utf-8?B?cUx1cUpxZ1hUVFowcDNNaEVJaVVGL0lsUWowOEhrc2EySnZzOTBBRTM5c243?= =?utf-8?B?a2JEVjlLdXZZcXFidHk2MENJUjZHeGRiWmlib3NhbGYrblpHL1NtME1aMWRQ?= =?utf-8?B?UGRwTUppRE9BZTVjbzFweUF6bDlMWmlRRUJKTW9rdUtjZ3dwOHA0ajhiTFVX?= =?utf-8?B?WW81c2NsbFFsRTVsTXkxcXAycGtIZlo5QVBjaGJZZzhiV2xKZ0hCR2tMeFB4?= =?utf-8?B?eTF3MzJCV1JMZlBQdHRENFJCM1U5ZmxZanJONVc5WExaUVNjaDNqOG5zblQ5?= =?utf-8?B?MDVNa1p0SENLKzk5aklFTWVBaHBNQnBha1hGbG1HRnJxejZkbnY5T3hoeHRD?= =?utf-8?B?dll1cURKUUY2K2VPcmEwU2I0Uy9BZjVmYkVtMGwyYWRGLy9GYUJoQjFidVBE?= =?utf-8?B?dTFHYW9JY0s2MmxsWk1GcnFGUmI0dGVNRWtUalBoM25HL2pjUVJHSHdIYkR0?= =?utf-8?B?WEx2bWt6K0JxRVlLRVgreVFjQmtGYituMGlobFFrd2lrNnhlanh6L1VUT2x2?= =?utf-8?B?VXg4SzJ4clBUaGpBQnNlK3B0MjBtMzROZlpWNCtlNlZrWmpoWW5xY2U0TGRw?= =?utf-8?B?bjNqSDVqeHRHUHYrcnhGNmVBaUhKbDNrbjNPS0RCdWZIMVhFOUhCTWRBemFX?= =?utf-8?B?QnNLRThKcjBKQ3p5Qk9GWDE4VzlpRXBrMndueFpEcEhCVDlYREI3QllxNU1q?= =?utf-8?B?eUxWa1JPRGc2M3MwdFBLMWlqMWtXQ0VySm5HaTNEd0Erb2IwNkRPYlVYd2Qy?= =?utf-8?B?azhZUWwyUlcvTElhdTFzVlpEWTYrK1JGUE9QTEFIN2gxZmc2QlJ5a1BLQ1ds?= =?utf-8?B?aS9VWjA4ZUgvODd4aSt0OWxnamtoRmFVRXd4R0JOYkRvU3RpRGxqVTlzY1R1?= =?utf-8?B?T2t4NEhNNkNtWVBSYTVoZG9ZTVZzaHU3Q21KVHowc09pS3JhUXhBVjJmTWJr?= =?utf-8?B?OE9iTEJRTjIyL25kcTBqRmdIcjlDbkc1U2J1TENhTUtVNTNiUU1MVFdvTExK?= =?utf-8?B?THpjSVlmMEQycnpPdzhMMFV1MzlDYVZ1T3JhUkVCb2k0ZGQwMFRLYWtKM2k1?= =?utf-8?B?MXVFOFNiTWQwVi9NTHJ2L1R5N2w1V2N5QXJoN0RBcUliOWhWVDFkamVvbWEx?= =?utf-8?B?bUMvTmlyRHB1eGo3a1pBTXltSjZPVlpNb0dpMTN6amdBK3JXSi9UZjVzY3Y4?= =?utf-8?B?QnpqSWdtMjEyQUEzeGtqYmY5Z0JjSmFZMmVTSmJZeWdqMXdMTW5CWENnUmtz?= =?utf-8?B?c2hzNWZoSUl4bVRWU0czeTdXeGdTTzdFOWNBQjEwdTZYUW40K01mMlIyL0xi?= =?utf-8?B?blVhVzZTZWhvaFJMbi85bTZ2dnR2cFRvWkJ6Z3JKczBGclg5a1R5STdNUk5T?= =?utf-8?B?Smx3U3Q4d3U3L0VHU0EwRm1mQ09RR0dUT0lWWkZXK3BFSHFOc0FEby9RK0kz?= =?utf-8?Q?loRFT7WbB4TLVESpO/pmFXKpa8ChV/C6AhLZ5cc?= X-MS-Exchange-CrossTenant-Network-Message-Id: c0f6e4f2-3969-41db-1da1-08d95e51affa X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 11:58:38.9234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H75/CRWrQt/mVF6JDXWP8/6JYcIKPughYr+iZgqCHiTxwo43FDss7tQVlvBdiVp1zxXHJeVc91jMCJfZRJXvMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4951 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/iavf: remove redundant default RSS field for IP fragment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/2/2021 9:36 AM, Wenjun Wu wrote: > This patch removes redundant default RSS field for IP fragment packets, > only src MAC address and dst MAC address are needed. > Hi Wenjun, The impact is not clear, from the description I take this as code refactoring without any impact but can you please clarify this in the commit log? Also patch title it too long, can we update as following: net/iavf: fix default RSS field for IP fragment packets If so can you please put the Fixes tag? This way patch can be backported too. > Signed-off-by: Wenjun Wu > --- > drivers/net/iavf/iavf_hash.c | 26 ++------------------------ > 1 file changed, 2 insertions(+), 24 deletions(-) > > diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c > index 2b03dad858..eba55ecea5 100644 > --- a/drivers/net/iavf/iavf_hash.c > +++ b/drivers/net/iavf/iavf_hash.c > @@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) > } > > if (rss_hf & ETH_RSS_FRAG_IPV4) { > - struct virtchnl_proto_hdrs hdr = { > - .tunnel_level = TUNNEL_LEVEL_OUTER, > - .count = 3, > - .proto_hdr = { > - proto_hdr_eth, > - proto_hdr_ipv4, > - { > - VIRTCHNL_PROTO_HDR_IPV4_FRAG, > - FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID), > - {BUFF_NOUSED}, > - }, > - }, > - }; > - rss_cfg.proto_hdrs = hdr; > + rss_cfg.proto_hdrs = outer_ipv4_tmplt; > iavf_add_del_rss_cfg(ad, &rss_cfg, add); > } > > if (rss_hf & ETH_RSS_FRAG_IPV6) { > - struct virtchnl_proto_hdrs hdr = { > - .tunnel_level = TUNNEL_LEVEL_OUTER, > - .count = 3, > - .proto_hdr = { > - proto_hdr_eth, > - proto_hdr_ipv6, > - proto_hdr_ipv6_frag, > - }, > - }; > - rss_cfg.proto_hdrs = hdr; > + rss_cfg.proto_hdrs = outer_ipv6_tmplt; > iavf_add_del_rss_cfg(ad, &rss_cfg, add); > } > >