From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C0EBA09FF; Wed, 6 Jan 2021 10:27:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B532160912; Wed, 6 Jan 2021 10:27:46 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id DEA881608E4; Wed, 6 Jan 2021 10:27:43 +0100 (CET) IronPort-SDR: QvTiOBxKLvcgQmp/ZQPz6hb8Gw/eNxJWNhSqKYIZmFoDgHB614pzzypVJgc2rVSjipXR6oJn4v bl4BNsmBKfPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="177406740" X-IronPort-AV: E=Sophos;i="5.78,479,1599548400"; d="scan'208";a="177406740" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 01:27:42 -0800 IronPort-SDR: C/Ps1Ujy0qrvmsnIw86Nob9wC0PzTFOIA+X8Bh/E9DHTdvLtzX58VyhSPoZ7p/UvD3pENaahVp vdMYO8Kah6+g== X-IronPort-AV: E=Sophos;i="5.78,479,1599548400"; d="scan'208";a="422100879" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.237.190]) ([10.213.237.190]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 01:27:38 -0800 To: Lance Richardson , Ajit Khaparde , Somnath Kotur , Venkat Duvvuru Cc: dev@dpdk.org, stable@dpdk.org References: <20201214185352.252477-1-lance.richardson@broadcom.com> From: Ferruh Yigit Message-ID: Date: Wed, 6 Jan 2021 09:27:32 +0000 MIME-Version: 1.0 In-Reply-To: <20201214185352.252477-1-lance.richardson@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: limit per-poll Rx representor pkts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/14/2020 6:53 PM, Lance Richardson wrote: > Limit number of representor packets transferred per poll > to requested burst size. > Hi Lance, Can you please describe the impact of the change? Since it has a fixes line, it seems it is fixing something but it is not clear what is fixed. > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Somnath Kotur > Cc: stable@dpdk.org > --- > drivers/net/bnxt/bnxt_rxr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index 2b1dd97617..ffdeeecc3a 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > } > > raw_cons = NEXT_RAW_CMP(raw_cons); > - if (nb_rx_pkts == nb_pkts || evt) > + if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt) > break; > /* Post some Rx buf early in case of larger burst processing */ > if (nb_rx_pkts == BNXT_RX_POST_THRESH) >