From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D89CFA04B1; Thu, 24 Sep 2020 08:31:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C8081DD5C; Thu, 24 Sep 2020 08:31:35 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id EC0161DD5B for ; Thu, 24 Sep 2020 08:31:33 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.62]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 6D0D560070; Thu, 24 Sep 2020 06:31:33 +0000 (UTC) Received: from us4-mdac16-35.ut7.mdlocal (unknown [10.7.66.154]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 6C1118009B; Thu, 24 Sep 2020 06:31:33 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.174]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id EA9A1280052; Thu, 24 Sep 2020 06:31:32 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 707C01C005F; Thu, 24 Sep 2020 06:31:32 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Sep 2020 07:31:27 +0100 To: Ferruh Yigit , References: <1600764594-14752-1-git-send-email-arybchenko@solarflare.com> <1600767288-12109-1-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Thu, 24 Sep 2020 09:31:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-15.885300-8.000000-10 X-TMASE-MatchedRID: u6ojmU07PKzmLzc6AOD8DfHkpkyUphL9Ww/S0HB7eoNKddiF2Wo8eXv6 cG7t9uXqolUZTg4Zq6FvKnkxoTqLSqH2g9syPs88SUAFemq7B2VXjjsM2/Dfxn/nRXkdtDN8T3R EsgyEnsMvplZGzOBLumrzAEwd2VSWyw0dUT70SVEyIyttzvQ995EZHK6QPaaA33Nl3elSfsrgav zPe1kdY+9+wSwBzTb/q4m5Bec/+bQMhII59u9STMjz0VPUnBA1AZn/4A9db2TXIZTIUrehXmzkk 6oK3QRZ+VlGbordmTCDCF4tTC3kcaDJ1a++6xHxFcK/QGNGRL19dEBz6zdEV9uykrHhg4PdWbq4 t1JEQ3jjdmFZNq4Wxxj0HnU1GKb90X+0CFhNLNc/ApMPW/xhXoiuaoNXJrK/WtcoU8Jtc7ltxpg yXPmRWa5xImOfnNdt0RYK3pgVNSXqxxOtz59fBCi9uJ8hAvsazDHtVtmAaYrcyeMym9BUk3G9F+ cXkyliiu/uRpOVBitPklatje1aJjPpmmeZK64q4h8r8l3l4ebBnL3AaGm9owaYevV4zG3ZaPMLn ExawDVuVzrvQYrEdcBdg85R0JnR2mwVXKpQ3Bdl1tleYYUuJ1F5adRR2Ej1xWwvfxzKj7v+ezfo g1uF0+vDauY34IML+aHVMaZTR5bxD0x0N5N00p4CIKY/Hg3AWQy9YC5qGvz6APa9i04WGCq2rl3 dzGQ1AYo5vLEYGEssDr2eGoYjGfjqqxBU34n0/v0DagtaD6eyGpn3V89DdQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.885300-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1600929093-HDwzUkH2b9Jb Subject: Re: [dpdk-dev] [PATCH v2 00/60] common/sfc_efx: support Riverhead NIC family X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On 9/23/20 8:45 PM, Ferruh Yigit wrote: > On 9/22/2020 10:33 AM, Andrew Rybchenko wrote: >> Riverhead is a new NIC family, the first one with EF100 architecture. >> Control interface is an MCDI similar to EF10. Datapath interface is >> completely new. >> >> The patch series is build tested with and without EFSYS_OPT_RIVERHEAD >> enabled. >> >> EF10-based NICs are tested with the patch series applied with and >> without EFSYS_OPT_RIVERHEAD enabled. >> >> net/sfc patches will follow. >> >> v2: >>   - fix spelling in few patches >>   - use tabs to indent instead of spaces >> >> Andrew Rybchenko (41): >>    common/sfc_efx/base: add EF100 registers definitions >>    common/sfc_efx/base: update MCDI headers >>    common/sfc_efx/base: add event queue operation to do polling >>    common/sfc_efx/base: add efsys option for Riverhead >>    common/sfc_efx/base: add Riverhead NIC family >>    common/sfc_efx/base: update registers check for Riverhead >>    common/sfc_efx/base: use EF10 MCDI methods for Riverhead >>    common/sfc_efx/base: use EF10 PHY methods for Riverhead >>    common/sfc_efx/base: move 14b prefix check out of caps get >>    common/sfc_efx/base: remove PF count get from caps get >>    common/sfc_efx/base: factor out helper to get board config >>    common/sfc_efx/base: set NIC features in generic place >>    common/sfc_efx/base: factor out MCDI entity reset helper >>    common/sfc_efx/base: add Riverhead support to NIC module >>    common/sfc_efx/base: use dummy tunnel ops for Riverhead >>    common/sfc_efx/base: use EF10 filter methods for Riverhead >>    common/sfc_efx/base: use EF10 MAC methods for Riverhead >>    common/sfc_efx/base: add interrupts module for Riverhead >>    common/sfc_efx/base: move EvQ init/fini wrappers to generic >>    common/sfc_efx/base: move EvQ create generic checks >>    common/sfc_efx/base: prepare to merge EvQ init functions >>    common/sfc_efx/base: merge versions of init EvQ wrappers >>    common/sfc_efx/base: add event queue module for Riverhead >>    common/sfc_efx/base: handle MCDI events on Riverhead >>    common/sfc_efx/base: move RxQ init/fini wrappers to generic >>    common/sfc_efx/base: move TxQ init/fini wrappers to generic >>    common/sfc_efx/base: switch TxQ init to extended version >>    common/sfc_efx/base: maintain RxQ counter in generic code >>    common/sfc_efx/base: free Rx queue structure in generic code >>    common/sfc_efx/base: move Rx index check to generic code >>    common/sfc_efx/base: implement Rx control path for Riverhead >>    common/sfc_efx/base: implement Tx control path for Riverhead >>    common/sfc_efx/base: fix Tx descriptor DMA sync on Riverhead >>    common/sfc_efx/base: handle Rx events for Riverhead >>    common/sfc_efx/base: handle Tx complete on Riverhead >>    common/sfc_efx: do not include libefx headers from efsys.h >>    common/sfc_efx/base: add API to get Rx prefix information >>    common/sfc_efx/base: group RxQ parameters into a structure >>    common/sfc_efx/base: choose smallest Rx prefix on Riverhead >>    common/sfc_efx/base: use EF10 EVB methods for Riverhead >>    common/sfc_efx/base: allocate vAdaptor on Riverhead >> >> Andy Moreton (7): >>    common/sfc_efx/base: add option for extended width events >>    common/sfc_efx/base: add 256bit type >>    common/sfc_efx/base: support creation of extended width EvQ >>    common/sfc_efx/base: poll extended width event queues >>    common/sfc_efx/base: handle normal events in extended width >>    common/sfc_efx/base: add option for descriptor proxy queues >>    common/sfc_efx/base: handle descriptor proxy queue events >> >> Igor Romanov (9): >>    common/sfc_efx/base: add function control window concept >>    common/sfc_efx/base: add function control window lookup API >>    common/sfc_efx/base: add efsys API to find a memory BAR >>    common/sfc_efx/base: add Xilinx capabilities table lookup >>    common/sfc_efx/base: add NIC magic check on BAR lookup >>    common/sfc_efx/base: introduce UDP tunnel destruct operation >>    common/sfc_efx/base: introduce states for UDP tunnel entries >>    common/sfc_efx/base: support UDP tunnel operations for EF100 >>    common/sfc_efx/base: replace PCI efsys macros with functions >> >> Ivan Malov (3): >>    common/sfc_efx/base: complete EvQ creation on Riverhead >>    common/sfc_efx/base: indicate support for TSO version 3 >>    common/sfc_efx/base: report restrictions for TSO version 3 >> > > Can you please check following checkpatch warnings, there are many > warnings but most of them ignored because of base files, but below > ones can be fixed I think: > > > WARNING:TYPO_SPELLING: 'inital' may be misspelled - perhaps 'initial'? > #7796: FILE: drivers/common/sfc_efx/base/efx_regs_mcdi.h:24607: > +/* The inital producer index for this queue's used ring. If this > queue is being > > WARNING:TYPO_SPELLING: 'inital' may be misspelled - perhaps 'initial'? > #7803: FILE: drivers/common/sfc_efx/base/efx_regs_mcdi.h:24614: > +/* The inital consumer index for this queue's available ring. If this > queue is > > WARNING:TYPO_SPELLING: 'endianess' may be misspelled - perhaps > 'endianness'? > #199: FILE: drivers/common/sfc_efx/base/efx.h:2794: > + * Location and endianess of a field in Rx prefix. > > WARNING:TYPO_SPELLING: 'requries' may be misspelled - perhaps 'requires'? > #74: FILE: drivers/common/sfc_efx/base/efx_pci.c:328: > +                * Xilinx Capabilities Table requries 32bit aligned > reads. Many thanks for the review. I'm sorry that I've overlooked it. Will definitely fix. Andrew.