From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 25BF6A04A7; Tue, 25 Jan 2022 09:51:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5DAF411A4; Tue, 25 Jan 2022 09:51:02 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6FE1B4013F for ; Tue, 25 Jan 2022 09:50:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643100660; x=1674636660; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=pHh/bDhNmFQC4VkfAOEKjmTXaEtLqp/9TqujA+4+Q3Q=; b=U4nYG7BtYYfPVzqytq2Hf5oUWytBAm7IQllE76dRWItC57dd34vO46sj 30M9cPFhOvSc0wNyY0cHa3od32HeML8Guc1pxUuJvgou9nxdUs/zGgItY JsL9L5ca7qwCs/ocEJ6R/7Abt4U0yeKt304O3VuhyCP7gJKVXD3gqLI4R bQyB3yGs2wiBF1yhgGqCAm0vjSIzOEh5iRXn/PZiWRZBVV73ewbEUQBE5 mzQp1sd1gvK68lHXUnvaF3C7d8blZT7/YeDtGMri/+2+27CB2xRsU4h10 HmZJbfL2JtwfFp2X7+4YRGcNll5QiA2PppgMLH2dLaswMMa01MLF5S1ch w==; X-IronPort-AV: E=McAfee;i="6200,9189,10237"; a="306972582" X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="306972582" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2022 00:50:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,314,1635231600"; d="scan'208";a="768967308" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga005.fm.intel.com with ESMTP; 25 Jan 2022 00:50:52 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 00:50:52 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 25 Jan 2022 00:50:52 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 25 Jan 2022 00:50:51 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 25 Jan 2022 00:50:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=djsk4uFWKGR+UdompvKIn36UQawLB/7tUhBjOn6rY9lFiQAUEe6pp5O8OOyYSfN4NB1qDXMsqJrQTTj+6DI4Rp6U5LMD8nVtB/cvjbWP4ZYZmYQOaI18rmQc2S20CYDjX99tLafioe0Iqf3en/FsSX6E+jqR4YTcq8/fAW2HbQoIVPtiaE5/3ocHhEPR4M3rcxiuU9XD/NG3PF/D0DeoNVMISSk07uohfb4M1y2fKuIQBcLTkr0/Q174t0FMz6g/yeIm/biTVYxjYWjL0ux4eFe9sWtcjZrZQhoBQbzvHOQO2v69P+jASzjm8m48fWt0OmHOYV+fo1yPDRi7fVEyOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4qvX9LjmP4GRb1+vQpYX4swLrUSASXNvVT5ayAEQuYU=; b=AyDimbodyx1AUZUgXHjUY2qXy6/9VOdEDyvL/diAIb9AObPS0pJ7axTF4/EWpZ1VU6t3TmOic4koGKho6rO4oVpLINHotYhJiKsdgb9ZLf3Yx3FvhwYQ8IcP//aj1mG9ZH+BW2KZAZWghbWJ2itGz6jrbvSNQB6V7PL94flXHeiv60wRzi58ixHlsQPq0i15OUkP/buSclG0pm2akvll0Us/0e5GElXvXHAqFoNTY8VhBTctER1aE0fVVWHPsYmKid0gcRYguTEPCrQdh0jT0g54ur/6HITrPdvyiLV11TyHzxJUMqCmAIVoHfeVZMb09IeKee17RwDOgs7zjXc3Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) by MWHPR11MB1471.namprd11.prod.outlook.com (2603:10b6:301:b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Tue, 25 Jan 2022 08:50:50 +0000 Received: from PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::85bf:bdfe:eb93:ac95]) by PH0PR11MB5047.namprd11.prod.outlook.com ([fe80::85bf:bdfe:eb93:ac95%4]) with mapi id 15.20.4909.017; Tue, 25 Jan 2022 08:50:49 +0000 Message-ID: Date: Tue, 25 Jan 2022 08:50:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.1 Subject: Re: [PATCH v2 82/83] power: remove unnecessary NULL checks To: Stephen Hemminger , References: <20220124000518.319850-1-stephen@networkplumber.org> <20220124174719.14417-1-stephen@networkplumber.org> <20220124174719.14417-83-stephen@networkplumber.org> From: David Hunt In-Reply-To: <20220124174719.14417-83-stephen@networkplumber.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0281.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::16) To PH0PR11MB5047.namprd11.prod.outlook.com (2603:10b6:510:3c::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04eeedcb-8d98-475e-9770-08d9dfdfc93f X-MS-TrafficTypeDiagnostic: MWHPR11MB1471:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rDKgME7vaiQvFl90ssmuQlDnChAxpEXarQ8LzIG+6WiAGG1mggF2wyAgg/DsOyMiTk7Qvs7ZGvbv3fb2/QedfX2ZKSIuyyhfg/pOSzvC/WqHYPh7LvbglCE5n5U6lEZE6p5yyowZNV1+R18JQd0Hj7oBp1iYQtheqXQo6VtBXuV6dowBG82+XE/c3TKerr8tKgDF6VJpbzdcgt9w2yePW4Z16OS6piwSOLAu1rL3MpYQ5/QOu3C+8J2icy0wJI8zVZ5OSmaWgu+29Fr4hIqeO7Vx+mwupRq0E9B1h4HEXBZufNSkgyFNhDwOOHunCOGXeyeisos0fJrcfLSlHKhFzJdr8qaCLS8Q2H1a4HfNVlRS14wHaNnK5ANgkS+dTfhD0VmQNGvB8M720a4A1MF7DYOaaq/+N7k8xq58F8joyKFC8+rv9w2AfjKwk1Hg6RZ7okBBG721L3jOEmVISCG0oAFFdUQUHyT4svKmBASk7nsVc25kIHvLq/ybAYWLxWgyzW0VCkHvJKM2JNJxF4inmCsAz+F7AWD95m3gu/K+TIQX/zAJdZ100mTPgUVSxp3Oc139Dg4DXhdwhtwmzFG0fEva70L2yvsVO1G4SC7/48mqPtMvCMb0UY7O4ueG+IEkWPFhdWaSYLsfCd2d985YZ7ixj5FMB+xBUSGc3Yov+NSoT3QtVYGOoxfGC1m+T7Y2cmWuCxRI2tj+oLA1+sMmpVHglAL2LGeaLF3TXYnE02O1JbBx4NIY8brAvUNl4XrR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5047.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66946007)(66556008)(66476007)(5660300002)(4744005)(2616005)(53546011)(31686004)(6506007)(6666004)(82960400001)(508600001)(8676002)(38100700002)(8936002)(186003)(86362001)(31696002)(2906002)(6486002)(36756003)(316002)(6512007)(44832011)(26005)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTFjM0tIakJNU2lTOWIzTWhwY3pRY2tsNWtXcFRMZ0xaeVIrRG4rRERLUWx6?= =?utf-8?B?eFpDU2JiUGM3a1VDSU1MS1pXNDdlQmlRbmkrRERBWDNsOTVOUmxwN2tZM1JB?= =?utf-8?B?dU5COFhCbmd5TTVvU3M1R3VtSDd0SzBsemVBdkVLUjJnZENDZDQxVVVsb2hq?= =?utf-8?B?U3JoZ0R1ejBHRUdCWHd6NUJJZk1lUDc5YTl1UjR2VFo1SFBROXJManpUYXdR?= =?utf-8?B?S1ZvUEdnUkNKU1cvbVMyaUFyU1lNbkZXSFN2Q1RmdGduNlVUUHNHTVpvdFlY?= =?utf-8?B?ellJK1JreEFBMEduZGFFQzZ4bVJNSTJQQnJjc1JlT0lIT0dHbG1TNkxrNFpn?= =?utf-8?B?ZGVOSVVkTnNVS0FldUZhZXVjbXRiZGZ2bkdBQWhUdWZSZTIwOTN2c3FmT3p2?= =?utf-8?B?aE1XNk5YMGFvaGM1Vm9UOEw1UWYrLzFvR2wwc29ERkpGaWpFL29Ed2J3SVk0?= =?utf-8?B?eTF0UmFEVlFPNzl2RnNpZHhXb01JV3pBZzJmRmNCRG9paXlLZ1FvbG9oV0J1?= =?utf-8?B?WGR3RU1zR2Qvak5Lc1NxalQ4UjRRWmY0VWhxaUR3ZktxRGdUdzk4YXhuc0hj?= =?utf-8?B?YXRaUkFrbzBBbUoyQjVKVHp0WnFBNFVtdllWSkxsd29OQmtUNUM2RlFhOFZU?= =?utf-8?B?WmxROFRWSk1rMk1NY2tlbzkzaGhNSVA5U05FNEw1ZHhOSmdza0FmRXRQTXdY?= =?utf-8?B?Ny9oOGdldFFjR2dxcnRzMDVsWnBZUG1WREo5czlhWlQrczNHV3JaYkp1UTZ5?= =?utf-8?B?Z0xESGEyWkpFMjNIY3JIVDlQNDNHbVpNSnJBY3V6V1NsQXpSekhrdCs4a1Fj?= =?utf-8?B?TmdEWHpVQ1lZQitTUnNnOE9XUlVwOUExV2FLM093c0FUS2lJZ1l1b2NDbGtV?= =?utf-8?B?VE1yRzVqTlg0OUpPRVZHdDRBTHZHZmR5YTVmZkk5MDQ5a0pmRWJBU0lTaVA3?= =?utf-8?B?ZW9JM0FsOGtPdTJpT1hhNGJ3WHNqc3RmUFRyZ2EvMW51bWhJVUFxditzQTRu?= =?utf-8?B?UlZVTStkYW1BVk5FN1YyL1VIdWY5UW43c080cS9WSUVtcnRUQUcwbzZqTDhk?= =?utf-8?B?QTE5OFF4K3hBVmlBUDk0T1dma3RuOGUwWU1iNWhqVlVMRFpHRXdML0RUZmpp?= =?utf-8?B?bVBwemNTTzlzRDlyb2Q1dXd5SW1ZNFVZMmlCM0R2R212dXQ4V0dWVXR6VzF3?= =?utf-8?B?aDFBeFhVSEo0Z0dzZjdFQTcwN2NDenRkck5zQXlGOWVEM1I1eDJmWkZSTGNn?= =?utf-8?B?cUtpOUYyQzQrb0V2ckdkRWhJUDVuajgxK3BkbHE4T200ZVc3MVB4ayt0Z2g2?= =?utf-8?B?UVJoZWl2SzBmYXhoTEhRUzZGcHRpVCtaWUp1V1hZV3pGSS9oRFJMWFJIbGw4?= =?utf-8?B?SEVlQ1JXSUo0Wlc2aHpwZjB5ZWtaWmFFaVRkZThxMzI3amxMTFg5WnBUZTdk?= =?utf-8?B?RnBDR2d0MmpFRldoamtaendHOURDR2p4dHo4QlJ0dGZxMEF1M0h3Vk0wU1By?= =?utf-8?B?K2xIUXVCSmgvTXhXZk54aGpiS1R0dHpkdUk0R0V3M2dOMmQ5RjZrc3pVeVNS?= =?utf-8?B?Um1vTWdXR1NuSWp3b2lESjRXYlhUQnEyc3VKdTc2ekptY0YxZHFidlUxaFhr?= =?utf-8?B?QmVVUlAxQmdNRmFITWR5cmlOQlhNMlJRZjk2WVg2anBOV3ozYWd2bFBVMEsr?= =?utf-8?B?VHUxeVBoVFNmam9Odm5kdHpDVkNPSEJ5R1FOb0s5Q0NoNWdub1FkY0Q1dE5v?= =?utf-8?B?MGZueHJyTWFpTFNtS1VWaS9waStMaWxHcE1EWTltQS9vQ01scXZuZzJ3S2U3?= =?utf-8?B?Mjh6NWxQUnlCRDMwY3pIc0J1azNNZVU0V0p6K1FFT2JFajF1VVJqYVUxUlpN?= =?utf-8?B?YUMvYVV5NFVpQmVOaHUydUozaVpZY1gyYWFqaGx5WEFtbjFYalpVcitiTlVh?= =?utf-8?B?eHMwNEVFMlV6NHNHZGV1WkRLTnV5RXl1UkZoK0RCUGdINDQraU5qNWVLcDFV?= =?utf-8?B?MnYvWVN3ZVRtaUlmVTlzanVvM28vWGQyNjNwSVAzbnZrVlFlaDBHUGcvaGtH?= =?utf-8?B?MEpjQUMxWjZIblFsS1VVS3NTR3Z2RXdDM21qSjJ1Q3k4MXVaV29OUmVBRStV?= =?utf-8?B?K1FxSjltQjRxb0Fnbmhhak1HTVZ4TnJyWmZkRmI3T00zTzBObWFneVdZMkc5?= =?utf-8?Q?D6lrkD0BEwQEBiL6KwOSaJ4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 04eeedcb-8d98-475e-9770-08d9dfdfc93f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5047.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 08:50:49.9223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HykPh05qUU5avy9R+jm+CBbYHMqRJBDnSvAwa0SRbj5hdHmGfpa5QXr0rv4Nx6IxbXBXUaOQnqzQhg0bNHq01g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1471 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/1/2022 5:47 PM, Stephen Hemminger wrote: > Remove redundant NULL pointer checks before free functions > found by nullfree.cocci > > Signed-off-by: Stephen Hemminger > --- > lib/power/rte_power_empty_poll.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c > index c4b5de9601cf..2261ce7820f6 100644 > --- a/lib/power/rte_power_empty_poll.c > +++ b/lib/power/rte_power_empty_poll.c > @@ -457,8 +457,7 @@ rte_power_empty_poll_stat_free(void) > > RTE_LOG(INFO, POWER, "Close the Empty Poll\n"); > > - if (ep_params != NULL) > - rte_free(ep_params); > + rte_free(ep_params); > } > > int Acked-by: David Hunt