DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions
@ 2016-09-20 16:17 Ferruh Yigit
  2016-09-20 16:17 ` [dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag Ferruh Yigit
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Ferruh Yigit @ 2016-09-20 16:17 UTC (permalink / raw)
  To: dev; +Cc: Olivier Matz

Fixes: 85226f9c526b ("mempool: introduce a function to create an empty pool")
Fixes: d1d914ebbc25 ("mempool: allocate in several memory chunks by default")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_mempool/rte_mempool.c | 4 +---
 lib/librte_mempool/rte_mempool.h | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index df8b68c..e96d14f 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -908,9 +908,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size,
 /*
  * Create the mempool over already allocated chunk of memory.
  * That external memory buffer can consists of physically disjoint pages.
- * Setting vaddr to NULL, makes mempool to fallback to original behaviour
- * and allocate space for mempool and it's elements as one big chunk of
- * physically continuos memory.
+ * Setting vaddr to NULL, makes mempool to fallback to original behaviour.
  */
 struct rte_mempool *
 rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 0243f9e..6fc331a 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -591,8 +591,6 @@ typedef void (rte_mempool_ctor_t)(struct rte_mempool *, void *);
  *
  * This function uses ``memzone_reserve()`` to allocate memory. The
  * pool contains n elements of elt_size. Its size is set to n.
- * All elements of the mempool are allocated together with the mempool header,
- * in one physically continuous chunk of memory.
  *
  * @param name
  *   The name of the mempool.
@@ -748,7 +746,7 @@ rte_mempool_xmem_create(const char *name, unsigned n, unsigned elt_size,
  *
  * The mempool is allocated and initialized, but it is not populated: no
  * memory is allocated for the mempool elements. The user has to call
- * rte_mempool_populate_*() or to add memory chunks to the pool. Once
+ * rte_mempool_populate_*() to add memory chunks to the pool. Once
  * populated, the user may also want to initialize each object with
  * rte_mempool_obj_iter().
  *
-- 
2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2016-10-04  9:18 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-20 16:17 [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions Ferruh Yigit
2016-09-20 16:17 ` [dpdk-dev] [PATCH 2/2] mempool: fix comments for no contiguous flag Ferruh Yigit
2016-09-21 15:12   ` Olivier Matz
2016-09-21 16:15     ` Ferruh Yigit
2016-09-22  7:23       ` Olivier Matz
2016-09-21 15:04 ` [dpdk-dev] [PATCH 1/2] mempool: fix comments for mempool create functions Olivier Matz
2016-09-21 16:16   ` Ferruh Yigit
2016-09-28 13:59 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2016-09-28 13:59   ` [dpdk-dev] [PATCH v2 2/2] mempool: fix comments for no contiguous flag Ferruh Yigit
2016-10-03 15:06   ` [dpdk-dev] [PATCH v2 1/2] mempool: fix comments for mempool create functions Olivier Matz
2016-10-04  9:18     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).