From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CC15A2EDB for ; Wed, 2 Oct 2019 17:12:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C2761BF13; Wed, 2 Oct 2019 17:12:05 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id EB0B71BF0A; Wed, 2 Oct 2019 17:12:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4853618C4283; Wed, 2 Oct 2019 15:12:02 +0000 (UTC) Received: from [10.36.118.72] (unknown [10.36.118.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7339A5D9D6; Wed, 2 Oct 2019 15:11:57 +0000 (UTC) To: Bruce Richardson , dev@dpdk.org Cc: Shreyansh Jain , Alejandro Lucero , Anatoly Burakov , stable@dpdk.org, Maxime Coquelin , Zhihong Wang , Luca Boccassi , Zhang XuemingX , stable@dpdk.org References: <20190527161509.50252-1-bruce.richardson@intel.com> <20190528110748.10772-1-bruce.richardson@intel.com> From: Kevin Traynor Message-ID: Date: Wed, 2 Oct 2019 16:11:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190528110748.10772-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Wed, 02 Oct 2019 15:12:02 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 28/05/2019 12:07, Bruce Richardson wrote: > This set fixes some issues seen on the automated CI system with building > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > unsupported parts of the build, and switch the 32-bit builds to always > having large file support, so that make and meson are consistent in that > regard. > > V2: add two additional patches to fix clang builds. This allows the > test-meson-builds.sh script to run successfully on 32-bit Ubuntu > 16.04 systems. > > Bruce Richardson (5): > net/nfp: disable nfp for 32-bit meson builds > build: enable large file support on 32-bit > build: remove unnecessary large file support defines > eal: mark unused function in 32-bit builds > build: add libatomic dependency for 32-bit clang compile > Hi Bruce, Intel validation team reported failures with some 32-bit builds with meson on 18.11.3-rc1. I've tested with these patches and it fixes the problems. I also took d23e141ffa52 ("build: set RTE_ARCH_64 based on pointer size"), to avoid rebasing the other patches to check 'void *' size multiple times. Any objection to applying for 18.11 branch? Kevin. > drivers/common/dpaax/dpaax_iova_table.c | 4 ++-- > drivers/event/octeontx/meson.build | 5 +++++ > drivers/event/opdl/meson.build | 5 +++++ > drivers/net/nfp/meson.build | 2 +- > examples/vhost_crypto/meson.build | 1 - > examples/vhost_scsi/meson.build | 1 - > lib/librte_eal/linux/eal/eal_memalloc.c | 1 - > lib/librte_eal/linux/eal/eal_memory.c | 2 +- > lib/librte_rcu/meson.build | 5 +++++ > lib/librte_vhost/Makefile | 2 +- > mk/arch/arm/rte.vars.mk | 2 +- > mk/arch/i686/rte.vars.mk | 2 +- > 12 files changed, 22 insertions(+), 10 deletions(-) >