From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>, dev@dpdk.org
Cc: thomas@monjalon.net, chenbo.xia@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] devtools: ignore PREFER_FALLTHROUGH
Date: Tue, 4 Aug 2020 08:43:29 +0100 [thread overview]
Message-ID: <e72bf24e-f124-ba8c-d4f4-0bf2d726663d@intel.com> (raw)
In-Reply-To: <20200804073837.88189-1-amorenoz@redhat.com>
On 8/4/2020 8:38 AM, Adrian Moreno wrote:
> The PREFER_FALLTHROUGH check warns if a passthrough comment is found
> because, in the kernel, the special macro "fallthrough" is prefered.
>
> Since that keyword is not defined in DPDK, ignore the warning.
>
> Ignoring this check does not affect the MISSING_BREAK check that will
> warn if a switch case/default is not preceded by break or a fallthrough
> comment.
>
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2020-08-04 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 7:38 Adrian Moreno
2020-08-04 7:43 ` Ferruh Yigit [this message]
2020-08-04 8:00 ` Xia, Chenbo
2020-08-05 9:12 ` Thomas Monjalon
2020-08-05 13:34 ` Adrian Moreno
2020-08-05 13:54 ` Thomas Monjalon
2020-08-07 11:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e72bf24e-f124-ba8c-d4f4-0bf2d726663d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).