From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 35F82F971 for ; Thu, 2 Mar 2017 14:06:49 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2017 05:06:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,231,1484035200"; d="scan'208";a="71388970" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.134.95]) ([10.255.134.95]) by fmsmga005.fm.intel.com with ESMTP; 02 Mar 2017 05:06:46 -0800 To: Rasesh Mody , dev@dpdk.org References: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> <1488181923-9649-18-git-send-email-rasesh.mody@cavium.com> Cc: Dept-EngDPDKDev@cavium.com From: Ferruh Yigit Message-ID: Date: Thu, 2 Mar 2017 13:06:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488181923-9649-18-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 18/21] net/qede/base: semantic fix X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 13:06:51 -0000 On 2/27/2017 7:52 AM, Rasesh Mody wrote: > No need to return - base on return at end of function. Does it make sense to update patch title to remove "fix" to prevent misunderstanding, perhaps to something like: "refactor return path" or "update semantic" > > Signed-off-by: Rasesh Mody <...>