DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace
Date: Mon, 1 Nov 2021 13:20:23 +0000	[thread overview]
Message-ID: <e7479e04-c274-6fc1-e79f-189d57acfaa2@intel.com> (raw)
In-Reply-To: <cba287c8-fdf1-d34f-cf1b-398b3b8de241@intel.com>

On 11/1/2021 12:48 PM, Ferruh Yigit wrote:
> On 11/1/2021 12:39 PM, Ferruh Yigit wrote:
>> On 11/1/2021 9:23 AM, Jiawen Wu wrote:
>>> On October 22, 2021 7:03 PM, Ferruh Yigit wrote:
>>>>
>>>> diff --git a/drivers/net/txgbe/txgbe_ethdev.c
>>>> b/drivers/net/txgbe/txgbe_ethdev.c
>>>> index 7b46ffb68635..0b0f9db7cb2a 100644
>>>> --- a/drivers/net/txgbe/txgbe_ethdev.c
>>>> +++ b/drivers/net/txgbe/txgbe_ethdev.c
>>>> @@ -2695,11 +2695,11 @@ txgbe_dev_link_update_share(struct rte_eth_dev
>>>> *dev,
>>>>       int wait = 1;
>>>>
>>>>       memset(&link, 0, sizeof(link));
>>>> -    link.link_status = ETH_LINK_DOWN;
>>>> -    link.link_speed = ETH_SPEED_NUM_NONE;
>>>> -    link.link_duplex = ETH_LINK_HALF_DUPLEX;
>>>> +    link.link_status = RTE_ETH_LINK_DOWN;
>>>> +    link.link_speed = RTE_ETH_SPEED_NUM_NONE;
>>>> +    link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX;
>>>>       link.link_autoneg = !(dev->data->dev_conf.link_speeds &
>>>> -            ETH_LINK_SPEED_FIXED);
>>>> +            RTE_ETH_LINK_AUTONEG);
>>>>
>>>
>>> Hi Ferruh,
>>> Is there some wrong that 'ETH_LINK_SPEED_FIXED' is changed to
>>> auto-negotiation?
>>>
>>
>> Not sure how it happened, but I will send a patch to fix it.
> 
> Ahh, there is another driver change [1] between this patch versions,
> that seems lead the conflict resolve error.
> 
> [1]
> Commit 196f0e123bcb ("net/txgbe: set fixed flag for exact link speed")
> 
>   -       link.link_autoneg = ETH_LINK_AUTONEG;
>   +       link.link_autoneg = !(dev->data->dev_conf.link_speeds &
>   +                       ETH_LINK_SPEED_FIXED);


Can you please check:
https://patches.dpdk.org/project/dpdk/patch/20211101131932.3398023-1-ferruh.yigit@intel.com/

      reply	other threads:[~2021-11-01 13:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 13:46 [dpdk-dev] [PATCH] " Ferruh Yigit
2021-06-29 15:02 ` Tyler Retzlaff
2021-06-30  6:29 ` David Marchand
2021-06-30  9:08   ` Ferruh Yigit
2021-08-27  1:19 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-08-27  7:59   ` Andrew Rybchenko
2021-08-27 20:24     ` Ferruh Yigit
2021-08-28 14:26     ` Ajit Khaparde
2021-08-29  7:47       ` Jerin Jacob
2021-08-29  8:17       ` Wisam Monther
2021-08-30  2:13         ` Xu, Rosen
2021-08-30  5:27           ` Xia, Chenbo
2021-08-30  6:24         ` Hemant Agrawal
2021-08-30  9:41   ` David Marchand
2021-08-30 17:01     ` Ferruh Yigit
2021-08-30 17:19   ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2021-08-31  7:59     ` Thomas Monjalon
2021-10-18 15:43     ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2021-10-20 19:23       ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2021-10-22  2:02         ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2021-10-22  6:44           ` Andrew Rybchenko
2021-10-22  8:25             ` Ferruh Yigit
2021-10-22  9:48           ` Pattan, Reshma
2021-10-22 11:03           ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2021-10-22 11:28             ` Andrew Rybchenko
2021-10-22 12:29               ` Somnath Kotur
2021-10-22 16:26                 ` Ferruh Yigit
2021-10-22 13:02               ` Ferruh Yigit
2021-11-01  9:23             ` Jiawen Wu
2021-11-01 12:39               ` Ferruh Yigit
2021-11-01 12:48                 ` Ferruh Yigit
2021-11-01 13:20                   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7479e04-c274-6fc1-e79f-189d57acfaa2@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).