From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29C90A0C57; Mon, 1 Nov 2021 14:20:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1737C40E28; Mon, 1 Nov 2021 14:20:35 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1B35C40DF6 for ; Mon, 1 Nov 2021 14:20:33 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="218200592" X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="218200592" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 06:20:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="448951205" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 01 Nov 2021 06:20:33 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 06:20:32 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 06:20:32 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 06:20:32 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 06:20:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LdWj4fjt2D4pFol37Hdhaygw3uGwOpF9wOK1LKHI0IRlGWuYLGQQ/QcAMoPG+DUXVhIm6KUdssAALbqo6Rdps5SpInjP23EdwYRZb+u0Ed5gk5z8WdYLFtGlk6GcafxiOcduB8qCx15w/8lXjOPJarhBg8jvzAJJtoNZpzF5Hpm0CXgauoKNZzRHpPC4uMlU24WCOAFoYI9KtLa7RDgNmSlDxz/BemJkCpbmSo6Ok6C1flXfrFpKVmgtxwKCZLrIciNXlOy8BMFKB5raO5eu4ddVoWrMTooh6qfAtWhwpGWCnx/lve4jxQmkocV2EaOZ/oNWw0PSHh9SHX+5KkmnSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IMd00xsDVLiHqa6Fj0m2htAtC+SOTEJ4ezN/UazJnyc=; b=IUF+PhEyaQJLLP41esk8ORil9WaXTCQyHBn84EopUqQ2WdsDQJq+wDc3rJsaXifqgbVxs1lGlXxqHyOrlbXocnbl+TMObLbI3UA72vlG7v1RPVl02b51hErZx+01IGUzfo3ZAr/d2FexAIeo5VE4uNi4YyGstq7Xxcv03Mky5cv4AolSERv8Jk1homZEi/VxgT8oFp7xq1h6+KnaEoxiqv6lsOxfEPZv5Ui0ton6I+RRM/Ffw75Rz0pEioykSrDKI5N+luzEvcBlpcDkd7VSVnbYpG1s+XvtHMM0BFnUJFw0SZ9wZ21rhdEtmL03YSDwVH7bewPZkDxsr/Msvfc8tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IMd00xsDVLiHqa6Fj0m2htAtC+SOTEJ4ezN/UazJnyc=; b=rzaF2RFiF1Fd1cKAmtbRLEVZExIlIGGwpmBrNLLHIg96pcaQB8MI8aKNiHHYLKx84wdIYS2YPsxBVN8fKB9+jsZUEsO6+rTWgT7ADW2r1rkP9/iYjfZzgfxfSvRhFoSVh/YnBVJAwXxFUyPNICLBGiFUZP2ogl2PmyBFS6gSqU4= Authentication-Results: trustnetic.com; dkim=none (message not signed) header.d=none;trustnetic.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5032.namprd11.prod.outlook.com (2603:10b6:510:3a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Mon, 1 Nov 2021 13:20:30 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 13:20:30 +0000 Message-ID: Date: Mon, 1 Nov 2021 13:20:23 +0000 Content-Language: en-US From: Ferruh Yigit To: Jiawen Wu CC: References: <20211022020243.2932559-1-ferruh.yigit@intel.com> <20211022110314.470843-1-ferruh.yigit@intel.com> <011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com> <4f7f64fa-dc6f-8725-3fd0-f3d41d0bce03@intel.com> X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR07CA0070.eurprd07.prod.outlook.com (2603:10a6:6:2a::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR07CA0070.eurprd07.prod.outlook.com (2603:10a6:6:2a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.4 via Frontend Transport; Mon, 1 Nov 2021 13:20:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad14402c-34db-4f2c-6709-08d99d3a603c X-MS-TrafficTypeDiagnostic: PH0PR11MB5032: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0aX/++JjEjF6q0brruchpASDCtylKGc8ToVq1alHux7x+2fWbL3cOAT+iom0LbrVEieyT9Es61B8dx94kIDtU23dQ37CaXpO1XSc0Rck54sZ06Fmax4ahXVmO9NehZhXjisaU+JKrwuVSfzDO/4DnGrahVq75tPSrMVhUk8XlwOLEtMiknxgjr0heSvTv4X3Kayn8OVkltoCDNI13te05ob1J45LpFiRvuRb8bTdMSMxSXDwxa2IL7Iqc/GNJsn9mZpjTzH+EKjHXwrJQssFSeB0TO2CYV7KjscseDUN1X/EqRFRQwAl1nzURdshmkyGXw8C0iKmvC8V3E/EXsSFreyg8liV6I1rT2Jl73lE1YHkGl4ufsqZ2SQui8ugR3vmv9JFgepQV5RVTyFuqhlZuZL2c6edMH7Us1EsgaPD6IirjarUGzlx4axxGyiEFFeTlU3NoO/BcYuXzI151BNPGu9G3KWtm10GzeRlkZZq38k7V/yIVr3ujZFmzruUwfLS5lL+4ow+hqRHCTtfqcnfcIJ3QGuL9SxrkXyWRhNRnG1exTqJYmXvbvgEmnLWgZyx2ekPBuTrqAcZKspfS/xRpdsfPx8gCbh2vm+Hc391q3exCTFVGhhz3+G0unHXICBe11pJrSQL/EEABHKZj6YZezBTTCRT9uwAaKLXTg6IlBbQKK/vwbvYAev24QhMzsB0Zr1KIbBR0tNTMwvd9e5aDjhTJbaXhLqYw5wDlvXksJzBHs0Kh5wtD+6rRNzMnZhSBRHv/YXh3zUwov+wReZZ8PUqsC4u6H+V1EilfeMG84c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(956004)(508600001)(44832011)(66476007)(66946007)(2616005)(5660300002)(66556008)(6666004)(53546011)(38100700002)(16576012)(26005)(82960400001)(6916009)(186003)(31696002)(83380400001)(316002)(31686004)(4326008)(8936002)(966005)(36756003)(8676002)(2906002)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MURnTEFQaWJCeEhCOXkrNGIxVGlKbVYvM2JxbmxqOWxYcnV4Y2U5aUZ3ZmZn?= =?utf-8?B?M3ZKRk8yTnYzbFVybTNEc3RGR2tEWnlCNFhldkNjb2RJVU82dmZlSjg0eFZF?= =?utf-8?B?U2EwSDMycTVPd0xRVDJjR1g5Vm01cjlvTjFjUHU2RE5xRnUydGpleHRpZU5N?= =?utf-8?B?M2tnN3dlazg5NmNEN28weGZDOVpaWTlzZzZBL3VmK0U2OHVLdTdqdGFDR1dZ?= =?utf-8?B?QU81QWpKK2dvMkZ4STJwWEN4b2NGbnlMTHVwcStGU1ljN0NiTHo5S1lyR0hO?= =?utf-8?B?T05uUzBJUGZsUXVJVkJsODZPWjMxTUhVUkNROHVuM05ha1NSWmV5Nk5LSGZh?= =?utf-8?B?RnhpZ1doRTBlblRFck1teEFkTENWZVJvUzJFN0k3VGphbzk1bFlmN0c0QXpJ?= =?utf-8?B?bzJRc0dBU3N4TzBSd28xSkNYMjNkb3drUjlwVXN4QUJTRFoybnFFeGlveTVL?= =?utf-8?B?dEVJR2N3aHNmYnJ3UFdsNVE5VHRUSTVRK25jM3Mxa0R4eUgzWWMwQW9RVlRU?= =?utf-8?B?c0wyUVc5bEF0S1BaWG1vZGlOb21NYyszNXVkcGxCampPQUU2eUdWSS92T3hT?= =?utf-8?B?Z3RYU1JDK011WWVYQ3Y2Nk5QM0U3VkNaVmJUY2ZzSDdmOW1MMitrcFhnOWFl?= =?utf-8?B?T1B5TXdmZDV2clRxalRQbk5iOHYwWWRKMUNZOStpV3ZWTXRCM0ErUG5NSmVl?= =?utf-8?B?Y1Y3VXhaZEZ4UzNlYnRhYmIzT21BY2xqc2x5c1JKWFZMMzhiZThJSTVvaDNu?= =?utf-8?B?MThhclQyVFkwc25YUG9pM0pyamdScXpDL3N1ejh1eDg2eEI5U0lOMDkxNG5N?= =?utf-8?B?VDNOaGlzUDB5M0lUZ21Sa1VsRzgyOHQ0ZjJVQVY5YktlR1dQYVVXZWtFNFQr?= =?utf-8?B?MHhUeHFLVVc3ZWJlLzZ4YTNSYVlJRzBaU0NjcmYwMlEvU0lzWmMwTS8xWUtL?= =?utf-8?B?WFNndVRST2Z5cGVaYllINnJjRG5ReTRNYlNkVXVpbWtsMjBVNHU1aXFiKy9k?= =?utf-8?B?RVBVZFdhNjhGUzR2b29JY0lnSXppVzBXSHZvak9TRW13UVB2SEVEVGVXV3Qr?= =?utf-8?B?bkdRSzFBYWltZzRNUlpvZGdwV3BkWjhmZDVUaHpEZWpCTW9HNUlaUE1GSTBt?= =?utf-8?B?SnBGTW8rekRNdFFPU0xRL09iZUI5ZjdyekptdVFPdEJnVlh2R1RiU29OdjYx?= =?utf-8?B?NHE4di94VlQxbTNld0RxTXVrbklOSFBLNjk0SFpoaFA2RXl5ZjhHK0swNEMv?= =?utf-8?B?bW54ZDdQNXJvSnkrOFdubTNFVVFNRVNHOTdmcUg0T2RGMEozWE5JT1luSWY5?= =?utf-8?B?WjcwVW5vbk90cDN0K3hOR2NVWnRodjlzTUw3UHpTOEJPQkRpWWI4ZTR0clJL?= =?utf-8?B?YndjS25uVmpUd1FqeHpNK3VKV05MY3dmUDBrQWpkQWNjbkxWbmV6b1dxK1V5?= =?utf-8?B?UjEwajhZMTRBUTBvSXdiUVQrcXlZbTlFYXVjNXhvMWZ1aE8yenJ2bTNVOHBJ?= =?utf-8?B?VnZ5c3N2SE8wZ2VRS0xwSllITWVXY1BUTjlnN1dwUERmRTlVTTFWUXI5Qkdp?= =?utf-8?B?UkJ5M2pLTnFIbFpUYmpoa1FkaERoelQzdURRWmFINWxOeHBIcGR2Mm9Fb0t4?= =?utf-8?B?RzRKZ1hlT0E3R3pEUlhOQUhsaXZya0luRmlRbTVLS2h4bUg2RnNjaDJ0UGlU?= =?utf-8?B?ZE5pdko5M1MvbmF0QXlyTXRjQmd5enZVNWZOVUdFSGJrZkMvZ21OU004OG95?= =?utf-8?B?TThuZGtuR05RTlRXRWJiK1cyZzJzWkNQaUtudk91STZXUE9vZE5hS0puS2xD?= =?utf-8?B?cE9MWURQUzlZbTh6ZUhqOEhJSmM2NzRCKzd6MEhHL01oei9Eck1YeUN5MTRG?= =?utf-8?B?Y2pVd0RxOFNpVGtWTC9tZHdHRlNzYXRGUmVOcEs3Q2xJWW5ET0IxWGlQdDM4?= =?utf-8?B?K3duYjBYT0o3bDM5L1AvZVR1WWVJcFBzK2VtbHlXcW9hc3N2ckdoRUxrUE1K?= =?utf-8?B?bGpySDBqK3IvMUh4Rk14YUkvQ3JVdmZvV1hJaHJJQTVhalA5Ris0S2pPdlp6?= =?utf-8?B?ZHN6cGNpOWMrOWZrZzI3WWJmejI1NWJEalJKU3libjd4dGVoTFkzakQ1K0du?= =?utf-8?B?aElib3RlbW9VVThFS2pFMjFuUE9Lczh5NGwrdnFLREdJY0szaFpZUzgvNXlN?= =?utf-8?Q?f5cKQghSKYwvBYA6RYAslBc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ad14402c-34db-4f2c-6709-08d99d3a603c X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 13:20:30.0290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YLxvoFYCV+baV7TaDHW4OYD1lgr2zvV/s/9nMnG52tkyQCdpXAyaPiyD2iVY1dvnroeghY9G61yA6cJYAHxZKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5032 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/1/2021 12:48 PM, Ferruh Yigit wrote: > On 11/1/2021 12:39 PM, Ferruh Yigit wrote: >> On 11/1/2021 9:23 AM, Jiawen Wu wrote: >>> On October 22, 2021 7:03 PM, Ferruh Yigit wrote: >>>> >>>> diff --git a/drivers/net/txgbe/txgbe_ethdev.c >>>> b/drivers/net/txgbe/txgbe_ethdev.c >>>> index 7b46ffb68635..0b0f9db7cb2a 100644 >>>> --- a/drivers/net/txgbe/txgbe_ethdev.c >>>> +++ b/drivers/net/txgbe/txgbe_ethdev.c >>>> @@ -2695,11 +2695,11 @@ txgbe_dev_link_update_share(struct rte_eth_dev >>>> *dev, >>>>       int wait = 1; >>>> >>>>       memset(&link, 0, sizeof(link)); >>>> -    link.link_status = ETH_LINK_DOWN; >>>> -    link.link_speed = ETH_SPEED_NUM_NONE; >>>> -    link.link_duplex = ETH_LINK_HALF_DUPLEX; >>>> +    link.link_status = RTE_ETH_LINK_DOWN; >>>> +    link.link_speed = RTE_ETH_SPEED_NUM_NONE; >>>> +    link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX; >>>>       link.link_autoneg = !(dev->data->dev_conf.link_speeds & >>>> -            ETH_LINK_SPEED_FIXED); >>>> +            RTE_ETH_LINK_AUTONEG); >>>> >>> >>> Hi Ferruh, >>> Is there some wrong that 'ETH_LINK_SPEED_FIXED' is changed to >>> auto-negotiation? >>> >> >> Not sure how it happened, but I will send a patch to fix it. > > Ahh, there is another driver change [1] between this patch versions, > that seems lead the conflict resolve error. > > [1] > Commit 196f0e123bcb ("net/txgbe: set fixed flag for exact link speed") > >  -       link.link_autoneg = ETH_LINK_AUTONEG; >  +       link.link_autoneg = !(dev->data->dev_conf.link_speeds & >  +                       ETH_LINK_SPEED_FIXED); Can you please check: https://patches.dpdk.org/project/dpdk/patch/20211101131932.3398023-1-ferruh.yigit@intel.com/