From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 5829645CE7;
Mon, 11 Nov 2024 10:08:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2C70E40E0C;
Mon, 11 Nov 2024 10:08:45 +0100 (CET)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com
(mail-co1nam11on2063.outbound.protection.outlook.com [40.107.220.63])
by mails.dpdk.org (Postfix) with ESMTP id B952440E01
for <dev@dpdk.org>; Mon, 11 Nov 2024 10:08:43 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=WSONVAhUAcKNSQpvsqao0ib+g/dm8YE2k2zeRU9rJxz+MIhLLxGarfmRcYYCD5hkCpJba3z/SQ+/JWJJQnvntcLW+0ipGYkrYuT3M8xcEdYmYQbnKn1j1AMVEnDi+2/AfXqyF97fh+FIoTv9nrmQgxIY66zm8PeUfLGg9RJoloreGQbeNzf2fiyucunLorvLkGYXIkNIN4DzGcNAMsgQxyZ26PPMtoi4XYCru4VPN2bZayi5UtAEbzpWQbwX0uPx/2jIZ/s3z/MbpGLjPYeaTeylDDTJ1WBWXEddapK0t3kI2+6R0lv1JRz5Hm5EWXg0BnMlXCY3ncXEl0uI14n0CQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=WjYKlrHMSCgwFnvC2ozwY83uwnkMDojM3enmLurrfGI=;
b=B+5wbhxNAJfx1PgAw6CwcpeTIFWt+eul8iWe5ro5QoggiYWjt0hL1fthVhzvYDzW++XiLNBSKAan8YqrCZUbcQQm2M12rpzwOD4cc1roj8li9UtnL49MPg1My0mPD3lXi4lhaP4Ed+blgSnLYzH4L+Gs+wmpyF4zyJq2nAiZ+gWvL8gKPJauI25AH1q5ar0oDyq4jpOBF5oNBCLbOEdzf4qb3NUA/a9sJR9t1atbSkUFcgKV+QH9oU45gUbIxwShTt4RI3CZydJEHARZDp8HpeanUUgvl5h0Enwyqy9ZzwXgQGKBDBUh0Q3UkHZWmTDS188J/7lJ0OU51onA3Fx8rw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=WjYKlrHMSCgwFnvC2ozwY83uwnkMDojM3enmLurrfGI=;
b=XKKvm9YO63hzAe5AqvblquTKM/+grRloyMQq9Fp0gSWPuo8q5gVQ9fscFheIXUHEp5qrBmNe4MTeq0HRJJUNtW9Ll1wkeA/oyHh73zjRnkQsV74x7Uf8ou74XaeZfGmmCFml7LHRfupqdsz136reXmpuoggBKYXj5lHop29ZGLo=
Authentication-Results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=amd.com;
Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9)
by CH2PR12MB4278.namprd12.prod.outlook.com (2603:10b6:610:ab::17)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov
2024 09:08:39 +0000
Received: from SJ2PR12MB8830.namprd12.prod.outlook.com
([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com
([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024
09:08:39 +0000
Message-ID: <e76c7a8f-5221-4930-93c9-16ff97d59a91@amd.com>
Date: Mon, 11 Nov 2024 09:08:34 +0000
User-Agent: Mozilla Thunderbird
Subject: =?UTF-8?B?UmU6IOetlOWkjTogW1BBVENIIHY2IDAxLzE3XSBuZXQvcjgxNjk6IGFk?=
=?UTF-8?Q?d_PMD_driver_skeleton?=
To: =?UTF-8?B?546L6aKi?= <howard_wang@realsil.com.cn>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "pro_nic_dpdk@realtek.com" <pro_nic_dpdk@realtek.com>
References: <20241108121123.248797-1-howard_wang@realsil.com.cn>
<20241108121123.248797-2-howard_wang@realsil.com.cn>
<efd1050c-9447-4ae7-8f89-3abc7079e887@amd.com>
<2a6d7c1303ec43f6a00dbbf0924c1bdd@realsil.com.cn>
Content-Language: en-US
From: Ferruh Yigit <ferruh.yigit@amd.com>
In-Reply-To: <2a6d7c1303ec43f6a00dbbf0924c1bdd@realsil.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LNXP265CA0075.GBRP265.PROD.OUTLOOK.COM
(2603:10a6:600:76::15) To SJ2PR12MB8830.namprd12.prod.outlook.com
(2603:10b6:a03:4d0::9)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CH2PR12MB4278:EE_
X-MS-Office365-Filtering-Correlation-Id: 213b8119-623f-4001-e2b4-08dd02306e58
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014;
X-Microsoft-Antispam-Message-Info: =?utf-8?B?NzBFejl5YmNFbDR0bHZQWWZZdUVBZklwdW82T3pISW9URlJLR0JuZmlPOU1X?=
=?utf-8?B?MXBZUnJZbFVGYVZYNWZLT1BLNUgydGM0VXd2eVNWM2x5WVR6ay9LMWFrM0Fj?=
=?utf-8?B?Q0RmU0lQTDlkT25sZFI2ckkvdEtBRE84RUltUmhwb0hrWGwxVXYrZnNuUUZH?=
=?utf-8?B?bjQyam1KNmNzWkZ0Q3Y5ZHhZRWpuVzY4a1pIUWE4V1ZVREVtcDFyb0VVL1Y1?=
=?utf-8?B?b2loUEtXZXdyRzdTQ2hIcDBlYi9iTmdPREg2SUlmbWc4TmxzVHlwb1p0NXBR?=
=?utf-8?B?MnByeGd0Rm8zWThTMDJ4MStvbWcwaUxDZmx1VkdoNDJIQytZY3hvTGgwdVdY?=
=?utf-8?B?SlVZelhCWU5PeU04Q0RlcjFnWEttZDdraWNlVXRsRy8rbEN2R1NRM0pSOG12?=
=?utf-8?B?UjdrL3VTcm1GZ1VnLzhVdlI4VnA5QSsydmwzL0xGcXp5SkFaQkhsNitMUWg2?=
=?utf-8?B?VWJhVXVtZnd0RVBKL2IrQXFOL0tScEJJQ0JoK0VyM3l2MXRwR1RGUXdkV1RU?=
=?utf-8?B?SFZFY2I2dHZSYlg0aWlxbFFMY0NxM2xZdmlVNHlxRlgrWXV5RERCcWNXWHNi?=
=?utf-8?B?QndEVDUxajhMN1ZqOFNmMU02c3RxZlJoT3ZnTHBVVGkzNU1HWjJuYjJJMkpz?=
=?utf-8?B?V2pMSEc1VzIrd25pOUJndGhIN1lOSVNEM1FiZnBwQ2xXdDE4RHc5dnN4Q3dL?=
=?utf-8?B?U3VGODVVQ1pRU3IrZ1BPWHFkUDRwVVY0WHIzVHhESDBVWktTKyt0QjNOdGw2?=
=?utf-8?B?SVZsQldiNUQwM2p0cnlqS1NXQXhKOTZpeWZmL0VSWDdCYXhEbFY5WkJyUmFP?=
=?utf-8?B?UnhjTTVwenJNVUVnazhoRFE1cTlOSHRYTnFCdVZjQWVNUHdkOXEyN3N1cWxH?=
=?utf-8?B?V1hxZndmRVVQQjZvWHhLL2FHaHZmSklLUkZicDFMR3A0Y2wvc243WUo5MUdm?=
=?utf-8?B?T0pxejRQY2gwbm1Nb3ZRRFZjcHpaWmJBZGtyRUVJaDBiOUNhcXhaVXh2TjhC?=
=?utf-8?B?bmY5bzhHcDRzckp6RUdjVXl4TjhWajlzakwrZ1lpVHlJMGRBcElZRVhLcmtD?=
=?utf-8?B?a0pZcHFRL1ZGUjFyQWxrOVhOMFk2T1RoTXpYRkthMmtpYkhzckQrWDBlalNS?=
=?utf-8?B?VE1UY3dkUElkNW1xQnVzNDFEQ09nYTlmY0VLY2FtR3hwakd4TUozSmdjaHFt?=
=?utf-8?B?aEhlSXZ6QXlnYmVvalVaZEhtbytoV0hibnRucGhUU0RDWU9TZjROUmRNZkVp?=
=?utf-8?B?b0FCcC9xUXY0OGErZmN4anVnM3pNa3hCV2FIaWFPbDZNRldPZnpuZGtpNTcy?=
=?utf-8?B?OUx1RGNzcktPcXQreXNTaWx3VCtnWVBCVDE3blpZTjA5RHVYSEpWWks2Yi9i?=
=?utf-8?B?UVBkZThBU3dZL0Q1MDJCWjZEbWZmVVdTZWtic1lYc3FVZ21NdFdWSHlmNVVv?=
=?utf-8?B?TFN0dFl2OGZmaVpMSjhVODZ0eEgvcDR0cXdZYlNFb1JHNnBxUkdRTlhVSHor?=
=?utf-8?B?NkpkSjhMYnZIR1Y2akZ4c3FtcHpZNlJqVWJSSDQ2WElWb05heHhFQnREWlVX?=
=?utf-8?B?a1FxTGJUeHUzdnBGRnRJdGpUWW5VaGpVWHF6cmNsUm9WL2UxTU9VUnBNb21r?=
=?utf-8?B?MFRvcURwK2lNaFV3UXRXZHpTZlM3ekxMZWprbmJlbEN2OFNMS2NXL2g0cnFv?=
=?utf-8?B?dy9zczczd2ZXenJDMXFhNC9xVUJYTzk0M1JxL0Y1WHZja2l5Q3JmQUNIQzNB?=
=?utf-8?Q?7V+aVOXhFZfuvt++cCR4sV4IRUIC70HekDUtBQ+?=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dExHT1pWRHJvS3JqZUhaOTBDUHpvSVBmL1VSOHhPNXF4Z3pCenZMWjNNOXdD?=
=?utf-8?B?dVBHZ29ONDVrTG5pRkJFVExWK2lpcUd5UXY0SlRlWTVEbURTNlRwQWxROTJ4?=
=?utf-8?B?a2M0QU9qU0VaUFlwRVA4NG9HYmM0NHJTUnZiWEl6UXRoNlBNaFVDZXU5d3pP?=
=?utf-8?B?YTNGcUZhcjI4TWkvT2ZEb0hXemtqTEdWTzIxWnJVUDV1R2pUc2NmQXZNWDBn?=
=?utf-8?B?YVhHQ3RVQmtqZEdLbFd2U1RxVjVKNXVTWUN2NFVqL2ZkM3BsU3kzVDJ2Vldy?=
=?utf-8?B?dW9hTHRGWHVEdWNIc2tIUG04RnRiejhZZ2Z3K1Q5bEQ4WXYrN3BCUU1RZ3V1?=
=?utf-8?B?SXRWcW9ubkVBbWhacGFQZGlDQkp4MmtXby9rQXFXTVUwZFA2azhFbVg2UHlU?=
=?utf-8?B?b1FpTXZPUDFZQ2FCZk9jRVZEY0MvSzRGazhuSXRQdC8xK2pxbWl1cFpIT21z?=
=?utf-8?B?Y05JN0JWcm4xTlU2dzl1Rng2bURhYUpranNyMzVHdGhPcjljWlZ5YllOb0dk?=
=?utf-8?B?TFljNXRuY0U4QXluUGhhR1NBRmx6TTBiK3hBZUR2WTk2eXZzUHBWVlJjKzVw?=
=?utf-8?B?UzVVQmdjTnZLcno2MlFOOFhQS05tRUxodEkxOCtxS2JsWkZWL2d0SWZXcndn?=
=?utf-8?B?YTlienhzbFcxdVhGbFRGOFl0cmJ5VEhQdGhUclJvM3FFTXVJTXFVSWJBL3JQ?=
=?utf-8?B?dlA0b01uMytkZ2xHeHNLK09yNGUvcUgxMGEzOHkzMzFrNVh5eFZEbUFpYnJH?=
=?utf-8?B?L0RxSFBOT0ZvZ0RnbEJOVmZBcHFMNkhpaFQxbGpJeCsrejJSRmkzeEsraWh1?=
=?utf-8?B?ZWRaWVhhaUp0YytIOWZKdHV1VVYyTDZDOGttRzhybUV5VVhJL1JsWGRoTjJM?=
=?utf-8?B?M0JwT25zWU90bXZzUEVIc3R4Z09EWXVXblpDOVAyeEFzK3hRSWd4UXE1MHNs?=
=?utf-8?B?cDdJZFhBa2JvNHp6WkVubzJxK3RxWFphZGRMTC82TUwva2JYSU5RV3dxTC9Z?=
=?utf-8?B?RSthallFVjlSMG5UNkpOOTRCeG8yb3ZmaG9QNmtuRFBReUQ5VHVCdUxxVElG?=
=?utf-8?B?TVM0ZERZaWpLUUZLb3dGUUtUbVFsVXk3REdBTmNMeHNrQXp2S1ZMbmtwNUZL?=
=?utf-8?B?SnA5d0d1RE5CaUxWd3JiQmkwZGc0WWF3UzJ0RDM3Wjc2c0twQUphVXJsa3ZD?=
=?utf-8?B?WFZtUUYraFUwRWRBWUliN2dtd0lpWmlHb3ZFVkVZYjc1T0VTVktvM21welpF?=
=?utf-8?B?U3ZZZHM4cXhCbWNLME1tR1J1VFhqd21zZWdkZzR4ZXZlM2ZHTm15aDQ1alMv?=
=?utf-8?B?MHdpMklRejV3WnU4ZkoxU3krQ2NMT0FJYWhudk5yTVhuZStaeWgwMTdXeXNF?=
=?utf-8?B?YkZmMjdnNHd6dlRDcjdDQTdEZTY5QzgxVUswT21FdGsrbVNqZURscFM4cmx2?=
=?utf-8?B?bVBWclcwNm5uQlFUdUhJVm9SLzRNUDBZZ3VJc3E5OC9sS1I2dWZrTDRraVA4?=
=?utf-8?B?K2xuUng5N09sNzlCUnZOVE4vNXR2UlBnVHZaNXdDUTRLUmxLUEFlRHRGL1Jr?=
=?utf-8?B?bjZmd24vdm9ZbnJvWFpDdFFXRWZJenovandqQXRBUWdhc0RzZHBpR2Q1Ky84?=
=?utf-8?B?UTF2dVE1OWFnNUtMYVZDTnhZTVFSUVVMUDdlN09NWnA1VXJjYVRZQU1ENUtH?=
=?utf-8?B?NmdxeEI2RGRuWTlTNGF5YU81b0lPY3hDV3VCL1NmSlNLb1RmQ0RUVTcvaGp5?=
=?utf-8?B?UGRLRnNtYnBGcFE1VHNCeGhHQjk5dVVNbXd2S0FuTjcvVlBnbU94MnpNK1hV?=
=?utf-8?B?cCtwajFDTmdaQmF4QnNmaXBVQmlQMWxFb0lNeGtZUjE1WHdGek9yNXhZSDN1?=
=?utf-8?B?TGRwOVhVaHdZQlFrV0VCOTg4cExPNGZXb2l2QktJZ3lCYTBlMW10MHlCNk9U?=
=?utf-8?B?eThYUkJGMEcrV3U1ZFhRejRxeHlRSnBxZkNjNGVla2wvQ1p5YnZOcGtxOUxD?=
=?utf-8?B?dGxWZ09IVEtvZWdldUVXWDc0L3JhbWY5ZDF3UXpGdjQzbmQrSzRqM0JrWkNY?=
=?utf-8?B?V293YytBdU94L1FHNWZla20zMkRwZnZ1L1pvSWhnd2g1emVLWjhwcTZkL3Yy?=
=?utf-8?Q?QbV2Vdda3LhIpU6pRXgVAYedJ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 213b8119-623f-4001-e2b4-08dd02306e58
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 09:08:39.1156 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ngaIaGwLJBLTSV7Al03YTzgoBu8dC26qEhhE44uGgYYOISfLNS4ZPVYOyBCkhMBt
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4278
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 11/11/2024 3:46 AM, 王颢 wrote:
> Dear Ferruh,
>
> I apologize for the issues that have arisen during the process of splitting a complete driver into several small patches.
>
> On 11/8/2024 12:11 PM, Howard Wang wrote:
>> Meson build infrastructure, r8169_ethdev minimal skeleton, header with
>> Realtek NIC device and vendor IDs.
>>
>> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
>
> <...>
>
> ===> I referred to Atlantic’s approach for this, and as a matter of fact, his first commit message was done in this manner.
> I will think again about how it should be modified.
>
No problem with the commit splits and orders, thanks for the update there.
Only comment in this patch is 'RTL_DEV_PRIVATE' macro is not used in the
patch and it can be added when you use the macro, so this is a simple issue.
Also I have a comment that build fails after some patchs, this also does
not require changing how patch split done, just fix build after each patch.
I am not sure if there is a misunderstanding but change requests are
mostly simple ones, I expect they can be fixed in one or two days, and I
am hopping to merge the driver in -rc2 or -rc3 at worst.
> net/atlantic: add PMD driver skeleton
> Makefile/meson build infrastructure, atl_ethdev minimal skeleton,
> header with aquantia aQtion NIC device and vendor IDs.
>
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> Signed-off-by: Pavel Belous <pavel.belous@aquantia.com>
>
>
>
> What do you think to add macros for the PCI device IDs, naming them makes it easier to know which devices are supported.
>
> ===> Regarding the device ID, for 0x8125, the supported device is indeed called 8125. So, should we name a macro like DEVICE_ID_RTL8125 to replace it?
>
Ahh, I see, matching is simple for 8125, device id and product number is
same :), is it same for all supported devices?
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8125) },
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8162) },
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8126) },
{ RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) },
>
> Best regards,
> Howard Wang
>
> -----邮件原件-----
> 发件人: Ferruh Yigit <ferruh.yigit@amd.com>
> 发送时间: 2024年11月11日 8:15
> 收件人: 王颢 <howard_wang@realsil.com.cn>; dev@dpdk.org
> 抄送: pro_nic_dpdk@realtek.com
> 主题: Re: [PATCH v6 01/17] net/r8169: add PMD driver skeleton
>
>
> External mail.
>
>
>
> On 11/8/2024 12:11 PM, Howard Wang wrote:
>> Meson build infrastructure, r8169_ethdev minimal skeleton, header with
>> Realtek NIC device and vendor IDs.
>>
>> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
>
> <...>
>
>> +/*
>> + * The set of PCI devices this driver supports */ static const
>> +struct rte_pci_id pci_id_r8169_map[] = {
>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8125) },
>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8162) },
>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8126) },
>> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x5000) },
>>
>
> What do you think to add macros for the PCI device IDs, naming them makes it easier to know which devices are supported.
>
> <...>
>
>> +
>> +#define RTL_DEV_PRIVATE(eth_dev) \
>> + ((struct rtl_adapter *)((eth_dev)->data->dev_private))
>> +
>>
>
> This macro is only used a few patches later, what do you think to add this macro when used?
>
>