From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FF8BA0A03; Mon, 18 Jan 2021 16:21:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42D47140F5B; Mon, 18 Jan 2021 16:21:14 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 38B22140F53 for ; Mon, 18 Jan 2021 16:21:12 +0100 (CET) IronPort-SDR: g6CluishBZ49qWCNUPLRj7AwbL+BOi1giU6nisPTfZ9Yq0+emfX2UEqI03qw+5PaxxWJ/ZHt7V tnEonvTLkZpA== X-IronPort-AV: E=McAfee;i="6000,8403,9867"; a="158588666" X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="158588666" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 07:20:38 -0800 IronPort-SDR: 0uqBImBMpNHTa85Z/rOC/dnE94iY2lYTEC4z5LDikHCB9NAMwm3MFVv1MvagGkjuT5W5VWdUi9 whPZSnvuUJrg== X-IronPort-AV: E=Sophos;i="5.79,356,1602572400"; d="scan'208";a="383604075" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.24]) ([10.213.241.24]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 07:20:36 -0800 To: George Prekas , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Stephen Hemminger , Harry van Haaren Cc: dev@dpdk.org References: <20201205054238.12469-1-prekageo@amazon.com> <20210107204228.20934-1-prekageo@amazon.com> From: Ferruh Yigit Message-ID: Date: Mon, 18 Jan 2021 15:20:33 +0000 MIME-Version: 1.0 In-Reply-To: <20210107204228.20934-1-prekageo@amazon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix IP checksum calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/7/2021 8:42 PM, George Prekas wrote: > Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c and > the calculated IP checksum is wrong. Use attribute __may_alias__ to fix > the problem. > > Signed-off-by: George Prekas Fixes: e9e23a617eb8 ("app/testpmd: add flowgen forwarding engine") Cc: stable@dpdk.org Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.