From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 558421B727 for ; Mon, 17 Dec 2018 17:52:17 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2812C070E37; Mon, 17 Dec 2018 16:52:16 +0000 (UTC) Received: from [10.36.112.10] (unknown [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D871260C62; Mon, 17 Dec 2018 16:52:10 +0000 (UTC) To: Jens Freimann , dev@dpdk.org Cc: tiwei.bie@intel.com, Gavin.Hu@arm.com References: <20181214155916.1142-1-jfreimann@redhat.com> <20181214155916.1142-10-jfreimann@redhat.com> From: Maxime Coquelin Message-ID: Date: Mon, 17 Dec 2018 17:52:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <20181214155916.1142-10-jfreimann@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 17 Dec 2018 16:52:16 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v13 09/10] net/virtio-user: fail if q used with packed vq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2018 16:52:17 -0000 I think you meant control queue in the title? On 12/14/18 4:59 PM, Jens Freimann wrote: > Until we have support for ctrl virtqueues let's disable it and > fail device initalization if specified as a parameter. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index 697ba4ae8..14597eb73 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -467,10 +467,16 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, > if (!in_order) > dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER); > > - if (packed_vq) > + if (packed_vq) { > + if (cq) { > + PMD_INIT_LOG(ERR, "control vq not supported with " Maybe change to "not supported *yet*". > + "packed virtqueues\n"); > + return -1; > + } > dev->device_features |= (1ull << VIRTIO_F_RING_PACKED); > - else > + } else { > dev->device_features &= ~(1ull << VIRTIO_F_RING_PACKED); > + } > > if (dev->mac_specified) { > dev->device_features |= (1ull << VIRTIO_NET_F_MAC); >