From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1703FA00C2; Fri, 11 Feb 2022 20:01:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8C3740683; Fri, 11 Feb 2022 20:01:52 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id D786E40140 for <dev@dpdk.org>; Fri, 11 Feb 2022 20:01:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644606111; x=1676142111; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=UWmKzESfsEsN+vOZHIGJuTBtHGvROyBiUZuC1gOodyQ=; b=a6phjrkbmGcCEM8as0NPD+bGVb8bWYdfJZuNvEnsM/TMJhvtIqLQu8Mg ZtTwoTxCw4kRIGZS/Zp1c5B+6evXYeEpit5jCwbNbIjxxxXorJnyqRHu2 2d84CGtYixmuI0a04Qmp8NPZ0chJG2gxpAMBMQzUXc4/vqVT90+L/Z3ZZ PMw4yOzs6XXotQUT0XN/CJi95Xkbmsaqu6tUIlhfW3SmlB9tpnHJdoidx SF1jlYcMLkqd3N0wn/bGuHZe/hbVjYAKXXRcI3/qGCLfScB2SWL6anRGO 7mzQ3YFcNAkAnGz64adA95aggyMER8u4KXcfdsRhSLZjjWYHHSEY02t4W g==; X-IronPort-AV: E=McAfee;i="6200,9189,10255"; a="230432801" X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="230432801" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2022 11:01:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,361,1635231600"; d="scan'208";a="542207795" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 11 Feb 2022 11:01:49 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 11:01:48 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 11 Feb 2022 11:01:48 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 11 Feb 2022 11:01:48 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 11 Feb 2022 11:01:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCnPZY+DyfGY3jOgiXXK7ICoCWCBVjDQ+CukoZ9YbjkwEcGcK/ozpcXD62/8LblcRq87fT6YX9crn/4pqKRII4tzr5MWJlanJabXfM7ukdCvrLbNcGvwksAq2xvMpt/yWG/95r94UnDcXXVuHDE3MHDQ+R9Yc9H4XP5PZzkcmJ5JmjVyT0/6Oc0pY3qnxoNGtasmlpoGG2eGO6YWzDYsGeT//p/Y3LkJnDk/Z6maGzXuh3Gdth2QsC1TWGIm6fvrTOmIjOBCN57JYfZM/7IUsnmIaXisZN95H52CxgkQxE2oNyE6vYqwig07g+qNySoZDjIml8oO95HYkmazVrFZDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A74jPcvKXR/8toiTex2dTRuUBn2IUhh0RLuSwx7JGx8=; b=D4babbvzhxz/HS1HQrLiLSGzsrqPNUMZkF0VrGfbukyTM8RhxmG0kTHroQ7e/Sf/bOSKqi5qKSM3Ar2aqQG0TcjTjPFkrz06FZHTIDlyRvlQNU2ullPFKa6TgLh1isRCxp4wIK8ofiUZEtfDrCjrlxALdAcK3rJTpGZgn7ORtM/RzAowOTygM/NLdiyDnsWpfFOPgmHTjsbwv1gvEUrDAwaXqQXbM5Ja58SoGuuu5pU+eANkZRk3ff+xZOpq3srSeSkZu/YedgY+dQxZXMjZT1hIK3ZQgK76eb8+RKM46Aonyq/OxLrg5AZSDC+ZwOpi9H2MDmKqIChTPmadHrmDbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB1457.namprd11.prod.outlook.com (2603:10b6:405:8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Fri, 11 Feb 2022 19:01:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Fri, 11 Feb 2022 19:01:44 +0000 Message-ID: <e7b4e03e-f954-7004-0b26-b5ff5cce5034@intel.com> Date: Fri, 11 Feb 2022 19:01:37 +0000 Subject: Re: [PATCH v4 2/2] ethdev: move driver interface functions to its own file Content-Language: en-US To: Thomas Monjalon <thomas@monjalon.net> CC: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Anatoly Burakov <anatoly.burakov@intel.com>, <dev@dpdk.org> References: <20220208194437.426143-1-ferruh.yigit@intel.com> <20220211183832.1904132-1-ferruh.yigit@intel.com> <20220211183832.1904132-2-ferruh.yigit@intel.com> <3252260.usfYGdeWWP@thomas> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy In-Reply-To: <3252260.usfYGdeWWP@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0097.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bab2ba50-2992-46e7-23c6-08d9ed90f25f X-MS-TrafficTypeDiagnostic: BN6PR11MB1457:EE_ X-Microsoft-Antispam-PRVS: <BN6PR11MB14577BEBF8236DC82B2EF98B95309@BN6PR11MB1457.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: altBhTNConOWK+fvbaq2fFPNYqH3kw6vX0JR9PZ/YdMdnMzhrKo5RVpZXJ18A/IBKm/qAhire3bWFodhFOFGKAV/OifXlfyoNGzAmfVQa5/MTu3GlTiyEB9t9rJo1ENgiZNHtXR4WS1rwSmtcxKyUik+/UwColNbLjczi1hY8mmTbsQF5HGLi1AQc1VdYGxOIV/vtibXfFSSkEgYYLTvmO0aOfSMeb1tq4AVyhsQv9guG/y1OraJ/ONJD8mWWteKoBPxbUQct9IWS2U/HKTE7ooYRRD3c6AN1yygO+/VkB7zswdtuh8b2OuOOpSXtSa+Gf/HBcoKpAkTBXeEjXeYty7WdBJtrysWXRgi/ZXntjOrqfNx0uMgZPZTNA8WOfdrmNiri4iwb1icUB0hwJU7l/ZFuh+ul81OjzBivSWih601Jn3HjbOThgiUnGS4f86HTvDsldLmMnc0rewpMkjmQo3yE4LedkQj0GokhKF5U6HbCWF5+Rq9mhqx39QNXbrcODHEl2a8CR1F+IApWOoS7AH305vOwkInaCfZiVaty4adXu2s6divPYBQsNclwUVWdxABSSeZ4tZugg6BsyFTYC96wSbi5uTD6sRpCwdUpBO0/3dVSFx4X78FeXsGaL3NHDqJYzUOAOXcnaYLhOY3V9cUI3d4SWD4d0CkZ+x7+avLq0vCXTzbli/Os3huTm9HgT4Ios8trUndH1ZGZ1nlmg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(86362001)(8676002)(8936002)(55236004)(6486002)(82960400001)(54906003)(53546011)(316002)(6506007)(4326008)(6666004)(6916009)(66556008)(66946007)(66476007)(6512007)(508600001)(31686004)(26005)(83380400001)(31696002)(5660300002)(44832011)(2616005)(38100700002)(36756003)(2906002)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3gwMDl2NzNmZ2d0RlJ6KytMVmErc3QrOVRjOTgyM2tkNlZzMXFISTV6YnE3?= =?utf-8?B?bnRDYVJNaTNLbndodTR5Nm5NVWN0eXJlNjY0TWtiM1B4VnNPS24rYVRMOGdo?= =?utf-8?B?VHhEU1NxdWRBTk5lRmovV2pCN2wycU9YVm9yb3J2cHluU250QjB3RnpaRUJS?= =?utf-8?B?amZKQnZURDJSU0gwMVV3RGRzQWx4Qis3ZmlKVkFVVnVobmJqMzZHS01JZllm?= =?utf-8?B?MzNWZitoMys4NjZFbDVORzY2WnFGVEJZdzZ2czZGSFMzSlZCTitLZCtkUGM3?= =?utf-8?B?c3NZZmxxQm42a3hsQmcxU3U4R1N0RXJKeFVzMVVMZUpMaEduUTh0b3ZVN1Vl?= =?utf-8?B?YWx1SzlJMFpIWWsrdndKL0NjL1JmSFA3WXBMdks1THltRGNnOW9SM1A3bU9a?= =?utf-8?B?bmtJTks4N0Jtall2RHArMGdlM1FBaURuNFlISko0V3ZoSGRWZEtNd0QyNzA2?= =?utf-8?B?Q2piVS90QW5zNjkyNENpZ1FjN0VxN2NFSmI3UndmZDBJVFd2M05QTXNCTnJO?= =?utf-8?B?Z1YwbUVVOWxuNUVvTEVONmxSQi9wRFN4bzcwMDh5NENPNTJjRC9TVHh0dHZS?= =?utf-8?B?eVd1ZFB6ZUNBS3dzclhvek1iYXFlRWFmWDR2RGFXcEU0aW1mRHdPZ3M4S1RZ?= =?utf-8?B?Qk1yMU1jWmVLOThKVzFlVkdDbjZjMDZ5ZU9MaVZsYzc0RlRPakR1YWpuQ0Jr?= =?utf-8?B?OTE3OW9PVVFTNVZBS3lMTkdBS2RMTk5RRG5FdzhYWnc0blRnbnRCd1JSTFdP?= =?utf-8?B?elM1M2krVUZuUlp3ZkE0Qzdwd1VLMUxMQ0QxL3lUbjdxRUg3VWhUSDRWUTZh?= =?utf-8?B?b2dvYmlwMkxaZzVjNDRzL3RYVlVDSHhIUDFGYVdiZVlFVlRWV0k2YzJZaXQx?= =?utf-8?B?QlE5MDVnb2wrVno2eGtYSE05cmJIV0Q4cXdLUzczSUIwTEhQd0piTnNxOTVO?= =?utf-8?B?c3M4eFJHNERIbWkxMm5tajVJenBBZVp5aGpPWHp0cU1lTzdDZVR6L1d2ZjZm?= =?utf-8?B?eVhIMTliZzB6MWplb1pkTUNpaTFkRXUxbFB5dXFKeWNqaEhvZkFjUy9LZ0NI?= =?utf-8?B?cCtGVm9MaFI1bWh3RS9NcEV5R045YlV5QXRxUzE2RmZTYk1rQ0JGWHBQY3A0?= =?utf-8?B?V2diVlVaYWxoUlJWR3ZvaytyNTJEU1VmV3BmZ21rZklvc1owbkNjZUk1Vlhl?= =?utf-8?B?cjYyS2Y1QlVRbWJ1czNGbFQzM292a290NEpIaFVKM05qTGp6dEdnTHFqK3F1?= =?utf-8?B?Z0dSNFpPcDBVNFhNcDF5TTBPMGJCVU80V0UrK0NoaFA2WE9QNzdLcjRORDd4?= =?utf-8?B?Wmw5K0VNZzlaY0FxcEprOTEzVUZnQis4aXNaTDFnZTIvaEpTaHlWVWMwZy9M?= =?utf-8?B?VXh2dU5ieGRvWXIxUFRuRmhZWFBrV0hRdWoyQWhvK0k2cFJlR1lpS2RLMDlj?= =?utf-8?B?R3FTV0RXRWoyYUZrdmdiWFlLSTNsQ3JSS2l6OFBLVWFUalEyUXFWcWFZTEhS?= =?utf-8?B?UG5iQlUrVmpiZU5HQnV5NyswMUl4MHFXSzVVVlJOR0hmSUdNV0VnY0p0ZktE?= =?utf-8?B?dnFiQlZTOGNyVW0zd05PZjZjSUF0SGtKNkVkaHVxVDdVUk5WK054R2VkUnZM?= =?utf-8?B?aUtxakZ6blhhcGFZRno1dzU3Z2VUaUs4aUtkYUd3RVlLZ1B4OXh0QWNnd0FZ?= =?utf-8?B?WXhFcWdWbm8zVFJhRVRmODN0M0lvSjNSUWxQZzNOc3JqMFhuNFJMY2ZIanZB?= =?utf-8?B?aHRTWTRFZHhzN0JBNExMSkZOd0FJUjc2NS80WmxLZVBtU0dERCszNlZTbmM2?= =?utf-8?B?bFI0MmF5U1RHdklUNVNlVnRHUnJLTGo1ZnlaWTRLcDc1bmExMVBHampBYnVk?= =?utf-8?B?VlJmUzRtazgxOC9kYzhET2hCUzJjOGI4NDVpS3ZmTXhXcDVQWUc0MTBWUDFP?= =?utf-8?B?ZC9MUmRyRENwZlgvbkxvT3BoMlpNeXFIejdiOCtGM3QzMmhMaHRLK1hjSFg4?= =?utf-8?B?RzliRjhkeWVYVVdMUWtMeXFuTE9Xc2RQM21yZ2FNeDRVRnprM0ZHdWFDc3ND?= =?utf-8?B?Rm1qV3lZa3V5cFdBbkhyWTZvK01COWNUVFptenhpc2FpZHQwTjZYL1dpNC9O?= =?utf-8?B?bFlKWnZSSzJkaWxCUHpIdDVzZGlHbGVYc3VoUXFiZkJVemhLQnBwV3pFcXNh?= =?utf-8?Q?YU6zVeCVvQ8OOHxstJNw1U0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bab2ba50-2992-46e7-23c6-08d9ed90f25f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2022 19:01:44.9374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g4naVv0Kr34eIC3T1PCvNZUBgr0wlBEkdtuAevOj9EKcxf4UkUfzf1JWBOtT+1D4pvHSJq6xKyO7LIC2XG6g8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1457 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/11/2022 6:55 PM, Thomas Monjalon wrote: > 11/02/2022 19:38, Ferruh Yigit: >> ethdev has two interfaces, one interface between applications and >> library, these APIs are declared in the ethdev.h public header. will update file name as 'rte_ethdev.h' >> Other interface is between drivers and library, these functions are >> declared in ethdev_driver.h and marked as internal. >> >> But all functions are defined in rte_ethdev.c file. This patch moves >> functions for drivers to its own file, ethdev_driver.c for cleanup, no >> functional change in functions. >> >> Some public APIs and driver APIs call common internal functions, which > > here > >> were mostly static since both were in same file. To be able to move >> driver APIs, common functions are moved into ethdev_private.c. > > and there, "driver APIs" should be "driver helpers", right? > I wasn't sure what to say them, I will update as "driver helpers" >> (ethdev_private.c is used for functions that are internal to the library >> and shared by multiple .c files in the ethdev library.) >> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Acked-by: Thomas Monjalon <thomas@monjalon.net> > >