From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E13FA04FD; Wed, 26 Oct 2022 21:15:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B977400D5; Wed, 26 Oct 2022 21:15:46 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id D88FE40041 for ; Wed, 26 Oct 2022 21:15:44 +0200 (CEST) Received: from [192.168.1.126] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2298B5A; Wed, 26 Oct 2022 22:15:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2298B5A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666811744; bh=ucQx3qGUDewjk+fAlrfNhnfxZJXYoHZangWsxL9dGGU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QU+Zy2ep0emXs0fDOReIWdrkMIavAaVrfGtMHwO3S8nrd1tOChTTxHu2Mr7OiDFYu sJaCPDL7+9LSCDg++WSsm8LmNDIIgJ0aVjqC7AhjHxOnFPXkiSrVzSdFWa3tI97HzK NEOuoxxgt+4c9Yxrmb2InXcduRDAAVlsvDxgN9CY= Message-ID: Date: Wed, 26 Oct 2022 22:15:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 2/3] ethdev: add queue-based API to report aged flow rules Content-Language: en-US To: Michael Baum , dev@dpdk.org Cc: Matan Azrad , Raslan Darawsheh , Ori Kam References: <20221019131228.2538941-1-michaelba@nvidia.com> <20221019144904.2543586-1-michaelba@nvidia.com> <20221019144904.2543586-3-michaelba@nvidia.com> From: Andrew Rybchenko In-Reply-To: <20221019144904.2543586-3-michaelba@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/19/22 17:49, Michael Baum wrote: > When application use queue-based flow rule management and operate the > same flow rule on the same queue, e.g create/destroy/query, API of > querying aged flow rules should also have queue id parameter just like > other queue-based flow APIs. > > By this way, PMD can work in more optimized way since resources are > isolated by queue and needn't synchronize. > > If application do use queue-based flow management but configure port > without RTE_FLOW_PORT_FLAG_STRICT_QUEUE, which means application operate > a given flow rule on different queues, the queue id parameter will > be ignored. > > Signed-off-by: Michael Baum > Acked-by: Ori Kam Few minor notes below, other than that Acked-by: Andrew Rybchenko [snip] > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index a8b99c8c19..8e21b2a5b7 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -2894,9 +2894,10 @@ following sections. > [meters_number {number}] [flags {number}] > > - Create a pattern template:: > + unrelated style fixes, should be in a separate patch > flow pattern_template {port_id} create [pattern_template_id {id}] > [relaxed {boolean}] [ingress] [egress] [transfer] > - template {item} [/ {item} [...]] / end > + template {item} [/ {item} [...]] / end unrelated style fixes > > - Destroy a pattern template:: > > @@ -2995,6 +2996,10 @@ following sections. > > flow aged {port_id} [destroy] > > +- Enqueue list and destroy aged flow rules:: > + > + flow queue {port_id} aged {queue_id} [destroy] > + > - Tunnel offload - create a tunnel stub:: > > flow tunnel create {port_id} type {tunnel_type} > @@ -4236,7 +4241,7 @@ Disabling isolated mode:: > testpmd> > > Dumping HW internal information > -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ unrelated changes > > ``flow dump`` dumps the hardware's internal representation information of > all flows. It is bound to ``rte_flow_dev_dump()``:: > @@ -4252,10 +4257,10 @@ Otherwise, it will complain error occurred:: > Caught error type [...] ([...]): [...] > > Listing and destroying aged flow rules > -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > ``flow aged`` simply lists aged flow rules be get from api ``rte_flow_get_aged_flows``, > -and ``destroy`` parameter can be used to destroy those flow rules in PMD. > +and ``destroy`` parameter can be used to destroy those flow rules in PMD:: unrelated style fixes > > flow aged {port_id} [destroy] > > @@ -4290,7 +4295,7 @@ will be ID 3, ID 1, ID 0:: > 1 0 0 i-- > 0 0 0 i-- > > -If attach ``destroy`` parameter, the command will destroy all the list aged flow rules. > +If attach ``destroy`` parameter, the command will destroy all the list aged flow rules:: unrelated style fixes [snip]