From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6A320A0548;
Tue, 30 Mar 2021 14:50:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E8B6D406B4;
Tue, 30 Mar 2021 14:50:18 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id 9598940691
for <dev@dpdk.org>; Tue, 30 Mar 2021 14:50:17 +0200 (CEST)
IronPort-SDR: 2TOyyEduW/i7OppXvu6242XyuAb4YGK4q2xXQE9GXXebyAj0sTSA7lp+TpKHrX3/gX5wnLG8Qj
e+xuUgs9UGAg==
X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="211971430"
X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="211971430"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Mar 2021 05:50:15 -0700
IronPort-SDR: +2dUnKsVbF9TOxkfXVZHhRScmp4buav+U1bq8XeKxHlXMJ2FuxDH2IJVXbEBIbY3jLdUsSY70Y
0r7X19wO8amw==
X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="418157220"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.213.217])
([10.213.213.217])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
30 Mar 2021 05:50:13 -0700
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>, thomas@monjalon.net
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, bruce.richardson@intel.com,
Shepard Siegel <shepard.siegel@atomicrules.com>,
David Marchand <david.marchand@redhat.com>
References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com>
<1615587606-29329-1-git-send-email-roretzla@linux.microsoft.com>
<33c030de-ba1c-cfd3-da28-800f151d964f@intel.com>
<20210324043238.GA31805@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
<7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com>
X-User: ferruhy
Message-ID: <e7c2b941-65ce-c9b1-4547-623bd762289a@intel.com>
Date: Tue, 30 Mar 2021 13:50:08 +0100
MIME-Version: 1.0
In-Reply-To: <7e48bf43-5bee-045e-aef2-f56dc72d8736@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to
install driver headers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 3/24/2021 11:27 AM, Ferruh Yigit wrote:
> On 3/24/2021 4:32 AM, Tyler Retzlaff wrote:
>> On Tue, Mar 23, 2021 at 05:04:08PM +0000, Ferruh Yigit wrote:
>>>> diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build
>>>> index c37b2e377..4353fa6b7 100644
>>>> --- a/lib/librte_ethdev/meson.build
>>>> +++ b/lib/librte_ethdev/meson.build
>>>> @@ -20,8 +20,14 @@ headers = files('rte_ethdev.h',
>>>> 'rte_mtr_driver.h',
>>>> 'rte_tm.h',
>>>> 'rte_tm_driver.h')
>>>> +
>>>> indirect_headers += files(
>>>> 'rte_ethdev_core.h',
>>>> 'rte_eth_ctrl.h')
>>>> +driver_sdk_headers += files(
>>>> + 'ethdev_driver.h',
>>>> + 'ethdev_pci.h',
>>>> + 'ethdev_vdev.h')
>>>> +
>>>> deps += ['net', 'kvargs', 'meter', 'telemetry']
>>>
>>
>> i feel like i missed a reply here. but just to clarify only ethdev will
>> be covered by this patch. inclusion of other driver headers was
>> discussed off list (sorry) and it emerged that it would result in
>> withdraw a number of driver api/abi that had not been marked as
>> __rte_internal.
>>
>> for driver api that were being exported as 'stable' a deprecation notice
>> will need to be issued in order to make them part of the
>> driver_sdk_headers. for that reason only ethdev is being made available
>> under this option for now.
>>
>> please ack/nack the patch as-is
>>
>
> I am OK the patch for the ethdev part, hence
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/main, thanks.