From: "Lam, Tiago" <tiago.lam@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, linville@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU
Date: Wed, 28 Nov 2018 13:12:18 +0000 [thread overview]
Message-ID: <e7c817bb-07af-365b-e2cd-2cf304052d5d@intel.com> (raw)
In-Reply-To: <59e1bdba-331b-e337-56e7-dc4f52057d56@intel.com>
On 27/11/2018 17:43, Ferruh Yigit wrote:
> On 11/20/2018 10:26 AM, Tiago Lam wrote:
>> Use the underlying MTU to calculate the framsize to be used for the mmap
>> RINGs. This is to make it more flexible on deployments with different
>> MTU requirements, instead of using a pre-defined value of 2048B.
>
> This behavior change should be documented in af_packet documentation which is
> missing unfortunately.
> Would you able to introduce the initial/basic af_packet doc to at least to
> document device argument? If not please let me know, I can work on it.
>
Thanks for the review, Ferruh.
Yeah, I don't mind cooking something up and submitting here for review;
I'll wait a couple of days for a reply from John W. before proceeding,
though.
But given there's no documentation for af_packet yet, do you prefer to
wait for that to be available, and apply it all together? Or could that
be applied later as part of another patch?
Tiago.
next prev parent reply other threads:[~2018-11-28 13:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 9:54 [dpdk-dev] [PATCH 1/3] net/af_packet: set_mtu() decrements sockaddr twice Tiago Lam
2018-11-20 9:54 ` [dpdk-dev] [PATCH 2/3] net/af_packet: Move parse and validation of iface Tiago Lam
2018-11-20 9:54 ` [dpdk-dev] [PATCH 3/3] net/af_packet: Get 'framesz' from the iface's MTU Tiago Lam
2018-11-20 10:26 ` [dpdk-dev] [PATCH v2 1/3] net/af_packet: set_mtu() decrements sockaddr twice Tiago Lam
2018-11-20 10:26 ` [dpdk-dev] [PATCH v2 2/3] net/af_packet: move parse and validation of iface Tiago Lam
2018-11-27 17:42 ` Ferruh Yigit
2018-11-20 10:26 ` [dpdk-dev] [PATCH v2 3/3] net/af_packet: get 'framesz' from the iface's MTU Tiago Lam
2018-11-27 17:43 ` Ferruh Yigit
2018-11-27 17:45 ` Ferruh Yigit
2018-11-28 13:12 ` Lam, Tiago [this message]
2018-11-28 13:33 ` Ferruh Yigit
2018-12-17 9:21 ` Lam, Tiago
2018-12-21 12:21 ` Ferruh Yigit
2019-02-18 18:01 ` Yigit, Ferruh
2019-03-19 13:16 ` Yigit, Ferruh
2019-03-19 13:16 ` Yigit, Ferruh
2018-11-20 10:29 ` [dpdk-dev] [PATCH v2 1/3] net/af_packet: set_mtu() decrements sockaddr twice Kevin Traynor
2018-11-20 10:45 ` Lam, Tiago
2018-11-27 17:42 ` Ferruh Yigit
2018-12-21 12:29 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7c817bb-07af-365b-e2cd-2cf304052d5d@intel.com \
--to=tiago.lam@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).