From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6807A04B4; Fri, 8 Nov 2019 15:21:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 829AE1C1C7; Fri, 8 Nov 2019 15:21:31 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 69B3D1C132 for ; Fri, 8 Nov 2019 15:21:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573222889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oNzI7FNmJ51XsPGLTEZ3sHlykoimE0BNVAd+CydieeA=; b=hlGwfKFQqEWHbxCNNxWdfSGLAUZkJhg749PxSxGgt7mH9UYQqgA+xNXmTCegZkBLO1JrHk xNpPwuuGVkOVr1AJ476hntti/FRXy89tfcRZP6WVK2bfnjOLeEV9b5tdFktb0ekRtVx5ZY lKnj6JMe5q6Z8uvwm9wcf4oniXxrdJM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-qnWK0RfQPZSsN9VrRqtGSg-1; Fri, 08 Nov 2019 09:21:26 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7FEC1005502; Fri, 8 Nov 2019 14:21:24 +0000 (UTC) Received: from [10.36.118.56] (unknown [10.36.118.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A90060CD0; Fri, 8 Nov 2019 14:21:18 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: Marko Kovacevic , Ori Kam , Bruce Richardson , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , Pavan Nikhilesh References: <1573207482-32642-1-git-send-email-david.marchand@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Fri, 8 Nov 2019 14:21:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <1573207482-32642-1-git-send-email-david.marchand@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: qnWK0RfQPZSsN9VrRqtGSg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-event: fix build on RHEL 7.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/11/2019 10:04, David Marchand wrote: > CC l2fwd_event_generic.o > .../l2fwd_event_generic.c: In function > =E2=80=98l2fwd_rx_tx_adapter_setup_generic=E2=80=99: > .../l2fwd_event_generic.c:203:3: error: missing initializer for field > =E2=80=98impl_opaque=E2=80=99 of =E2=80=98struct =E2=80=99 > [-Werror=3Dmissing-field-initializers] > } > ^ > In file included from .../l2fwd_event_generic.c:10:0: > .../include/rte_eventdev.h:1057:12: note: =E2=80=98impl_opaque=E2=80=99 d= eclared here > uint8_t impl_opaque; > ^ >=20 > CC l2fwd_event_internal_port.o > .../l2fwd_event_internal_port.c: In function > =E2=80=98l2fwd_rx_tx_adapter_setup_internal_port=E2=80=99: > .../l2fwd_event_internal_port.c:201:3: error: missing initializer for > field =E2=80=98impl_opaque=E2=80=99 of =E2=80=98struct =E2= =80=99 > [-Werror=3Dmissing-field-initializers] > } > ^ > In file included from .../l2fwd_event_internal_port.c:10:0: > .../include/rte_eventdev.h:1057:12: note: =E2=80=98impl_opaque=E2=80=99 d= eclared here > uint8_t impl_opaque; > ^ >=20 > Fixes: 50f05aa6ed9a ("examples/l2fwd-event: setup Rx/Tx adapter") >=20 Acked-by: Kevin Traynor > Signed-off-by: David Marchand > --- > examples/l2fwd-event/l2fwd_event_generic.c | 11 ++++------- > examples/l2fwd-event/l2fwd_event_internal_port.c | 11 ++++------- > 2 files changed, 8 insertions(+), 14 deletions(-) >=20 > diff --git a/examples/l2fwd-event/l2fwd_event_generic.c b/examples/l2fwd-= event/l2fwd_event_generic.c > index f996081..b7e467c 100644 > --- a/examples/l2fwd-event/l2fwd_event_generic.c > +++ b/examples/l2fwd-event/l2fwd_event_generic.c > @@ -195,13 +195,7 @@ static void > l2fwd_rx_tx_adapter_setup_generic(struct l2fwd_resources *rsrc) > { > =09struct l2fwd_event_resources *evt_rsrc =3D rsrc->evt_rsrc; > -=09struct rte_event_eth_rx_adapter_queue_conf eth_q_conf =3D { > -=09=09.rx_queue_flags =3D 0, > -=09=09.ev =3D { > -=09=09=09.queue_id =3D 0, > -=09=09=09.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL, > -=09=09} > -=09}; > +=09struct rte_event_eth_rx_adapter_queue_conf eth_q_conf; > =09uint8_t event_d_id =3D evt_rsrc->event_d_id; > =09uint8_t rx_adptr_id =3D 0; > =09uint8_t tx_adptr_id =3D 0; > @@ -210,6 +204,9 @@ l2fwd_rx_tx_adapter_setup_generic(struct l2fwd_resour= ces *rsrc) > =09uint32_t service_id; > =09int32_t ret, i =3D 0; > =20 > +=09memset(ð_q_conf, 0, sizeof(eth_q_conf)); > +=09eth_q_conf.ev.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL; > + > =09/* Rx adapter setup */ > =09evt_rsrc->rx_adptr.nb_rx_adptr =3D 1; > =09evt_rsrc->rx_adptr.rx_adptr =3D (uint8_t *)malloc(sizeof(uint8_t) * > diff --git a/examples/l2fwd-event/l2fwd_event_internal_port.c b/examples/= l2fwd-event/l2fwd_event_internal_port.c > index bed9475..b382763 100644 > --- a/examples/l2fwd-event/l2fwd_event_internal_port.c > +++ b/examples/l2fwd-event/l2fwd_event_internal_port.c > @@ -193,13 +193,7 @@ static void > l2fwd_rx_tx_adapter_setup_internal_port(struct l2fwd_resources *rsrc) > { > =09struct l2fwd_event_resources *evt_rsrc =3D rsrc->evt_rsrc; > -=09struct rte_event_eth_rx_adapter_queue_conf eth_q_conf =3D { > -=09=09.rx_queue_flags =3D 0, > -=09=09.ev =3D { > -=09=09=09.queue_id =3D 0, > -=09=09=09.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL, > -=09=09} > -=09}; > +=09struct rte_event_eth_rx_adapter_queue_conf eth_q_conf; > =09uint8_t event_d_id =3D evt_rsrc->event_d_id; > =09uint16_t adapter_id =3D 0; > =09uint16_t nb_adapter =3D 0; > @@ -207,6 +201,9 @@ l2fwd_rx_tx_adapter_setup_internal_port(struct l2fwd_= resources *rsrc) > =09uint8_t q_id =3D 0; > =09int ret; > =20 > +=09memset(ð_q_conf, 0, sizeof(eth_q_conf)); > +=09eth_q_conf.ev.priority =3D RTE_EVENT_DEV_PRIORITY_NORMAL; > + > =09RTE_ETH_FOREACH_DEV(port_id) { > =09=09if ((rsrc->enabled_port_mask & (1 << port_id)) =3D=3D 0) > =09=09=09continue; >=20