From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C2DFA00C2; Mon, 26 Sep 2022 15:17:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E1694069B; Mon, 26 Sep 2022 15:17:50 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 675DC40695 for ; Mon, 26 Sep 2022 15:17:48 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AEC965E; Mon, 26 Sep 2022 16:17:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AEC965E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664198267; bh=UpK2boBsZlUWX2hrncIem5e4SxdKAUIMQjeZeJCFCIk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AVlO8BO2NOB3wP3+98hSvCFDScZSEra5BWpzkznrsXdSNIHdV34+f2EXIA7IpyIME J4kLHceGMAkynyDPESvqNYplyxr7Rs+RRWIfBlvza5Sf75ql9NwJKzBIovLEVgOyaw 7/av/J7gF1ULh2UnWML42lvqOoUafM0b3ecXWbSk= Message-ID: Date: Mon, 26 Sep 2022 16:17:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2] ethdev: queue rate parameter changed from 16b to 32b Content-Language: en-US To: skoteshwar@marvell.com, Aman Singh , Yuying Zhang , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Qiming Yang , Wenjun Wu , Jiawen Wu , Jian Wang , Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org, ferruh.yigit@amd.com, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, jerinj@marvell.com References: <1663939018-18898-1-git-send-email-skoteshwar@marvell.com> <1663940715-19619-1-git-send-email-skoteshwar@marvell.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <1663940715-19619-1-git-send-email-skoteshwar@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/23/22 16:45, skoteshwar@marvell.com wrote: > From: Satha Rao > > The rate parameter modified to uint32_t, so that it can work > for more than 64 Gbps. > > Signed-off-by: Satha Rao Overall LGTM, but please update release notes and cleanup deprecation in the next version. However, the patch requires Acks from bnxt and ixgbe maintainers. > diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c > index 77ecbef..4dc38a2 100644 > --- a/drivers/net/bnxt/rte_pmd_bnxt.c > +++ b/drivers/net/bnxt/rte_pmd_bnxt.c > @@ -172,12 +172,12 @@ int rte_pmd_bnxt_set_vf_mac_addr(uint16_t port, uint16_t vf, > } > > int rte_pmd_bnxt_set_vf_rate_limit(uint16_t port, uint16_t vf, > - uint16_t tx_rate, uint64_t q_msk) > + uint32_t tx_rate, uint64_t q_msk) Deprecateion announces rte_eth_set_queue_rate_limit() changes, but above is a separate API which is not directly related. I'm OK with the change, but it requires maintainer Ack. > { > struct rte_eth_dev *eth_dev; > struct rte_eth_dev_info dev_info; > struct bnxt *bp; > - uint16_t tot_rate = 0; > + uint32_t tot_rate = 0; > uint64_t idx; > int rc; > [snip] > diff --git a/drivers/net/cnxk/cnxk_ethdev.h b/drivers/net/cnxk/cnxk_ethdev.h > index c09e9bf..17c820a 100644 > --- a/drivers/net/cnxk/cnxk_ethdev.h > +++ b/drivers/net/cnxk/cnxk_ethdev.h > @@ -557,17 +557,14 @@ int cnxk_nix_timesync_write_time(struct rte_eth_dev *eth_dev, > > uint64_t cnxk_nix_rxq_mbuf_setup(struct cnxk_eth_dev *dev); > int cnxk_nix_tm_ops_get(struct rte_eth_dev *eth_dev, void *ops); > -int cnxk_nix_tm_set_queue_rate_limit(struct rte_eth_dev *eth_dev, > - uint16_t queue_idx, uint16_t tx_rate); > -int cnxk_nix_tm_mark_vlan_dei(struct rte_eth_dev *eth_dev, int mark_green, > - int mark_yellow, int mark_red, > - struct rte_tm_error *error); > -int cnxk_nix_tm_mark_ip_ecn(struct rte_eth_dev *eth_dev, int mark_green, > - int mark_yellow, int mark_red, > - struct rte_tm_error *error); > -int cnxk_nix_tm_mark_ip_dscp(struct rte_eth_dev *eth_dev, int mark_green, > - int mark_yellow, int mark_red, > - struct rte_tm_error *error); Above changes for 3 functions look unrelated. Please, avoid it. > +int cnxk_nix_tm_set_queue_rate_limit(struct rte_eth_dev *eth_dev, uint16_t queue_idx, > + uint32_t tx_rate); > +int cnxk_nix_tm_mark_vlan_dei(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow, > + int mark_red, struct rte_tm_error *error); > +int cnxk_nix_tm_mark_ip_ecn(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow, > + int mark_red, struct rte_tm_error *error); > +int cnxk_nix_tm_mark_ip_dscp(struct rte_eth_dev *eth_dev, int mark_green, int mark_yellow, > + int mark_red, struct rte_tm_error *error); > > /* MTR */ > int cnxk_nix_mtr_ops_get(struct rte_eth_dev *dev, void *ops); > diff --git a/drivers/net/cnxk/cnxk_tm.c b/drivers/net/cnxk/cnxk_tm.c > index d45e70a..a36f45d 100644 [snip] > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index 1dfad0e..9ff8ee0 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2475,7 +2475,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev) > > int > ixgbe_set_vf_rate_limit(struct rte_eth_dev *dev, uint16_t vf, > - uint16_t tx_rate, uint64_t q_msk) > + uint32_t tx_rate, uint64_t q_msk) Requires Ack from ixgbe maintainer [snip]